I have attached the video and bugreport.
Issue is reproducing in Nexus 5x also.

askatte@, can you take a look?

I could repro this crash on Bullhead / Nexus 5X / 8.0. 

The bugreport says,
java.lang.IllegalArgumentException: Bitmap must not be null.
07-21 14:48:03.903 10059 28727 28727 W System.err: 	at android.graphics.drawable.Icon.createWithBitmap(Icon.java:557)
07-21 14:48:03.903 10059 28727 28727 W System.err: 	at com.google.android.apps.chrome.webapps.ChromeShortcutManagerInternal.addShortcutToHomeScreen(ChromeShortcutManagerInternal.java:18)
07-21 14:48:03.903 10059 28727 28727 W System.err: 	at org.chromium.chrome.browser.ShortcutHelper$Delegate.addShortcutToHomescreen(ShortcutHelper.java:2)
07-21 14:48:03.903 10059 28727 28727 W System.err: 	at org.chromium.chrome.browser.ShortcutHelper.addShortcut(ShortcutHelper.java:16)
07-21 14:48:03.903 10059 28727 28727 W System.err: 	at org.chromium.chrome.browser.webapps.AddToHomescreenManager.nativeAddShortcut(Native Method)
07-21 14:48:03.903 10059 28727 28727 W System.err: 	at org.chromium.chrome.browser.webapps.AddToHomescreenManager.addShortcut(AddToHomescreenManager.java:7)
07-21 14:48:03.903 10059 28727 28727 W System.err: 	at org.chromium.chrome.browser.webapps.AddToHomescreenDialog$4.onClick(AddToHomescreenDialog.java:6)
07-21 14:48:03.903 10059 28727 28727 W System.err: 	at android.support.v7.app.AlertController$ButtonHandler.handleMessage(AlertController.java:5)
07-21 14:48:03.903 10059 28727 28727 W System.err: 	at android.os.Handler.dispatchMessage(Handler.java:105)
07-21 14:48:03.903 10059 28727 28727 W System.err: 	at android.os.Looper.loop(Looper.java:164)
07-21 14:48:03.903 10059 28727 28727 W System.err: 	at android.app.ActivityThread.main(ActivityThread.java:6541)
07-21 14:48:03.903 10059 28727 28727 W System.err: 	at java.lang.reflect.Method.invoke(Native Method)
07-21 14:48:03.903 10059 28727 28727 W System.err: 	at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
07-21 14:48:03.903 10059 28727 28727 W System.err: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)
07-21 14:48:03.904 10059 28727 28727 F chromium: [FATAL:jni_android.cc(243)] Please include Java exception stack in crash report

dominickn@ or martiw@ can you please take a look?

I could repro this crash on both Pixel and Nexus 6P on 8.0.
It is much easier to repro by following the steps of Scenario 2 and connecting GIN-2g wi-fi.

The root cause:
When trying to add shortcut but the Page is not loaded.
Chrome will try to add a shortcut with a NULL as icon at addShortcutWithShortcutManager() and cause the crash.

Possible solution:
- Should we disable "Add to Home Screen" in menu when the page is not loaded?
- Or should we prepare an "Empty icon" (like R.drawable.navigation_empty_icon) and use it when icon is NULL?

In Chrome 55 on Android 7.1.2., in the same situation,  no shortcut will be added.  (although there will be toast said "shortcut added", nothing happened indeed.)

Issue 749418 has been merged into this issue.

Thanks for investigating Marti.

The icon should never end up null. If we fail to fetch an icon we should be generating one. I'm travelling and don't have an Android O device with me to investigate exactly what is going on here - if you have a chance, can you please put some LOG statements into add_to_homescreen_data_fetcher to work out what is going on when OnDataTimedout is being called?

Hi Dominick, when I reproduced the crash, in add_to_homescreen_data_fetcher:

- OnDataTimedout wasn't called.

- CreateLauncherIconInBackground was called (by CreateLauncherIconFromFaviconInBackground)

- primary_icon.getPixels()==nullptr at the end of CreateLauncherIconInBackground

Thanks for investigating. I've taken a look and figured out what is going wrong. It's a bit of a cascading series of failures:

1. icon generation relies on having |shortcut_info_.url| set to a non-null URL.
2. |shortcut_info_.url| is set based on content::WebContents::GetLastCommittedURL
3. |shortcut_info_.url| will be blank if add to homescreen is invoked *before* navigation commit

Hence, invoking add to homescreen before navigation commit means that icon generation fails and we get a null icon back.

I think the fix here is to disable add to homescreen prior to navigation commit as per the suggestion in c#7. I can prepare a CL for this.

Based on discussion with martiw@, we actually think falling back to the visible URL is the better way here:

1. last committed URL will be non-empty if we had previous navigations in the same tab
2. every thing else in the menu relies on the visible URL.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e915a0344793b323a2fcb79216f9585912781dbe

commit e915a0344793b323a2fcb79216f9585912781dbe
Author: Dominick Ng <dominickn@chromium.org>
Date: Thu Aug 10 05:23:30 2017

Use the current visible URL for add to homescreen.

This addresses a bug where invoking add to homescreen prior to
navigation commit led to a null icon being generated for the page. This
causes either:

a) no shortcut to be added (pre Android O); or
b) a crash (Android O+)

The fix replaces the use of the last committed URL with the current
visible URL. This is arguably more correct since all other items in the
Chrome menu determine their enabled state based on the visible URL, not
the last committed URL.

BUG= 747959 

Change-Id: If1f431ca29f5948ee6f562e2db773d408218bde7
Reviewed-on: https://chromium-review.googlesource.com/604819
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493263}
[modify] https://crrev.com/e915a0344793b323a2fcb79216f9585912781dbe/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
[modify] https://crrev.com/e915a0344793b323a2fcb79216f9585912781dbe/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java
[modify] https://crrev.com/e915a0344793b323a2fcb79216f9585912781dbe/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenManager.java
[modify] https://crrev.com/e915a0344793b323a2fcb79216f9585912781dbe/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenManagerTest.java
[modify] https://crrev.com/e915a0344793b323a2fcb79216f9585912781dbe/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
[modify] https://crrev.com/e915a0344793b323a2fcb79216f9585912781dbe/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc
[modify] https://crrev.com/e915a0344793b323a2fcb79216f9585912781dbe/chrome/browser/android/webapps/add_to_homescreen_manager.cc

askatte, can you check the fix in M62?

Verified fix in 62.0.3192.0 / Nexus 5X / OPR1.170623.011
Thanks!

[Auto-generated comment by a script] We noticed that this issue is targeted for M-61; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-61 label, otherwise remove Merge-TBD label. Thanks.

This has been an issue for quite some time. I think we're okay not merging to 61 and waiting until 62.