New issue
Advanced search Search tips

Issue 747944 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 791559



Sign in to add a comment

Make update URL option for force-install extensions policies

Project Member Reported by emaxx@chromium.org, Jul 24 2017

Issue description

* The title should be read as: "Make update URL optional for force-install extensions policies"

Currently, the policy format for force-install extensions policies requires the update URL to be always specified:
* ExtensionInstallForcelist: https://www.chromium.org/administrators/policy-list-3#ExtensionInstallForcelist
* DeviceLoginScreenAppInstallList: https://www.chromium.org/administrators/policy-list-3#DeviceLoginScreenAppInstallList

However, in many cases, the normal "https://clients2.google.com/service/update2/crx" update URL would just work. So this requirement often leads to inconveniences during development and testing (e.g. when setting up policies manually via YAPS or when copying policy protos on the DMServer side).
Moreover, the format for the public session accounts already has the update URL optional.

So the suggestion is to relax the update URL requirement for the ExtensionInstallForcelist and the DeviceLoginScreenAppInstallList policies.


Implementation-side note: here's the link to the code in Chrome that handles the absent update URL for the kiosk apps:
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc?l=871&rcl=d914a23721d371b22715a5805ada2e65bc7d2cf8
 

Comment 1 by emaxx@chromium.org, Jul 24 2017

Description: Show this description

Comment 2 by emaxx@chromium.org, Mar 28 2018

Blocking: 791559
Labels: -Pri-3 Pri-2

Comment 3 by emaxx@chromium.org, Mar 28 2018

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eaac2ff8f223413939db4b8f73eeb2010fbb6a6c

commit eaac2ff8f223413939db4b8f73eeb2010fbb6a6c
Author: Maksim Ivanov <emaxx@chromium.org>
Date: Mon Apr 16 16:23:24 2018

Make update URL optional for ExtensionInstallForcelist policy

Don't require the "update" URL to be specified for the
extension force installation policy. It should default to the
Web Store URL.

BUG=chromium:747944
TEST=unit and browser tests

Change-Id: I1dcf028573af5260f15a1dc92608192bd6a554a2
Reviewed-on: https://chromium-review.googlesource.com/1008183
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550995}
[modify] https://crrev.com/eaac2ff8f223413939db4b8f73eeb2010fbb6a6c/chrome/browser/extensions/policy_handlers.cc
[modify] https://crrev.com/eaac2ff8f223413939db4b8f73eeb2010fbb6a6c/chrome/browser/extensions/policy_handlers_unittest.cc
[modify] https://crrev.com/eaac2ff8f223413939db4b8f73eeb2010fbb6a6c/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/eaac2ff8f223413939db4b8f73eeb2010fbb6a6c/components/policy/resources/policy_templates.json

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eaac2ff8f223413939db4b8f73eeb2010fbb6a6c

commit eaac2ff8f223413939db4b8f73eeb2010fbb6a6c
Author: Maksim Ivanov <emaxx@chromium.org>
Date: Mon Apr 16 16:23:24 2018

Make update URL optional for ExtensionInstallForcelist policy

Don't require the "update" URL to be specified for the
extension force installation policy. It should default to the
Web Store URL.

BUG=chromium:747944
TEST=unit and browser tests

Change-Id: I1dcf028573af5260f15a1dc92608192bd6a554a2
Reviewed-on: https://chromium-review.googlesource.com/1008183
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550995}
[modify] https://crrev.com/eaac2ff8f223413939db4b8f73eeb2010fbb6a6c/chrome/browser/extensions/policy_handlers.cc
[modify] https://crrev.com/eaac2ff8f223413939db4b8f73eeb2010fbb6a6c/chrome/browser/extensions/policy_handlers_unittest.cc
[modify] https://crrev.com/eaac2ff8f223413939db4b8f73eeb2010fbb6a6c/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/eaac2ff8f223413939db4b8f73eeb2010fbb6a6c/components/policy/resources/policy_templates.json

Sign in to add a comment