Issue metadata
Sign in to add a comment
|
19.8% regression in loading.desktop at 488288:488461 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jul 24 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8973193455068271856
,
Jul 24 2017
=== Auto-CCing suspected CL author geofflang@chromium.org === Hi geofflang@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Geoff Lang Commit : df412bd5a319c948a882c7d9b620696facd5ff51 Date : Thu Jul 20 18:29:29 2017 Subject: Lazily create shader translators and implement glReleaseShaderCompiler Bisect Details Configuration: winx64_high_dpi_perf_bisect Benchmark : loading.desktop Metric : timeToFirstMeaningfulPaint_avg/pcv1-warm/amazon.co.jp Change : 17.69% | 589.829642862 -> 694.188777778 Revision Result N chromium@488287 589.83 +- 205.029 14 good chromium@488309 571.285 +- 19.0866 6 good chromium@488315 571.802 +- 50.885 6 good chromium@488316 559.598 +- 70.791 6 good chromium@488317 680.569 +- 64.4665 6 bad <-- chromium@488318 712.919 +- 177.028 6 bad chromium@488320 684.747 +- 66.1889 6 bad chromium@488331 683.119 +- 98.6855 6 bad chromium@488374 675.145 +- 106.322 9 bad chromium@488461 694.189 +- 211.692 9 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=amazon.co.jp loading.desktop More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8973193455068271856 For feedback, file a bug with component Speed>Bisection
,
Jul 24 2017
I'm going to put the status to "Assigned" if you don't think this found the right CL please assign back to me and put the status to "Untriaged". Thanks!
,
Jul 24 2017
,
Jul 24 2017
Issue 747878 has been merged into this issue.
,
Jul 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65d1cd6e7454a3fd383d0deeaaad67918f97be3b commit 65d1cd6e7454a3fd383d0deeaaad67918f97be3b Author: Geoff Lang <geofflang@chromium.org> Date: Tue Jul 25 17:34:04 2017 Revert "Lazily create shader translators and implement glReleaseShaderCompiler" This reverts commit df412bd5a319c948a882c7d9b620696facd5ff51. Reason for revert: Translator released too early from shader objects causing the program binary cache to miss more often. BUG=748202 BUG= 747865 Original change's description: > Lazily create shader translators and implement glReleaseShaderCompiler > > ANGLE's shader translators hold a significant amount of memory for the > builtin symbols. By lazily creating the shader translator, it may never > be intialized at all if all compiles hit the program binary cache. > > BUG= 695135 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > > Change-Id: I095dd2efa33e111726db893cd14c3c3574bdd6ce > Reviewed-on: https://chromium-review.googlesource.com/570540 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Geoff Lang <geofflang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#488317} TBR=geofflang@chromium.org,kbr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 695135 Change-Id: Ieb3ec4069b263654f86818cd3d1f5ab83fc1c4ab Cq-Include-Trybots: master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/585087 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#489354} [modify] https://crrev.com/65d1cd6e7454a3fd383d0deeaaad67918f97be3b/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/65d1cd6e7454a3fd383d0deeaaad67918f97be3b/gpu/command_buffer/service/shader_manager.cc
,
Jul 27 2017
,
Jul 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ab76823251e56cfd00174f8621a7f63abfe0f25 commit 6ab76823251e56cfd00174f8621a7f63abfe0f25 Author: Geoff Lang <geofflang@chromium.org> Date: Mon Jul 31 13:59:58 2017 Revert "Lazily create shader translators and implement glReleaseShaderCompiler" This reverts commit df412bd5a319c948a882c7d9b620696facd5ff51. Reason for revert: Translator released too early from shader objects causing the program binary cache to miss more often. BUG=748202 BUG= 747865 Original change's description: > Lazily create shader translators and implement glReleaseShaderCompiler > > ANGLE's shader translators hold a significant amount of memory for the > builtin symbols. By lazily creating the shader translator, it may never > be intialized at all if all compiles hit the program binary cache. > > BUG= 695135 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > > Change-Id: I095dd2efa33e111726db893cd14c3c3574bdd6ce > Reviewed-on: https://chromium-review.googlesource.com/570540 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Geoff Lang <geofflang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#488317} TBR=geofflang@chromium.org, kbr@chromium.org (cherry picked from commit 65d1cd6e7454a3fd383d0deeaaad67918f97be3b) Bug: 695135 Change-Id: Ieb3ec4069b263654f86818cd3d1f5ab83fc1c4ab Cq-Include-Trybots: master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/585087 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#489354} Reviewed-on: https://chromium-review.googlesource.com/593853 Cr-Commit-Position: refs/branch-heads/3163@{#149} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/6ab76823251e56cfd00174f8621a7f63abfe0f25/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/6ab76823251e56cfd00174f8621a7f63abfe0f25/gpu/command_buffer/service/shader_manager.cc |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jul 24 2017