New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 747855 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : 'Google Profile photo' Preview is seen blurred in chrome://md-settings/changePicture page

Project Member Reported by mmanchala@chromium.org, Jul 24 2017

Issue description

Chrome Version: 62.0.3164.0/9773.0.0 dev channel Kip,Daisy and Minnie
OS: Chrome

Pre-condition : Sign into user for which 'Google Profile photo' is not available

What steps will reproduce the problem?
(1)Sign into User -> Go to chrome://md-settings/changePicture page
(2)Now click on 'Google profile photo' option and observe Preview(Please refer screenshot)

Expected:  'Google Profile photo' Preview should not be blurred i.e. preview should be seen clearly 
Actual: Instead  'Google Profile photo' Preview is seen blurred 

This is Regression Issue as same is working fine in 
61.0.3160.0/9758.0.0 dev-channel Daisy

@stevenjb : Please confirm the Issue
 
Actual_BlurredPreview.jpg
114 KB View Download
Expected.jpg
110 KB View Download
Labels: M-62
Status: Started (was: Assigned)
Hmm, looks like the 1x image I used was smaller that it is supposed to be; will fix.

Regression was introduced in  issue 709917 


Project Member

Comment 4 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d59304b92c4640010cd4858ed89e62e0a1b3683d

commit d59304b92c4640010cd4858ed89e62e0a1b3683d
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Jul 27 22:53:51 2017

WebUI: Change Picture: Always use high res default avatar image

We need to use a hi-res (512x512) version of the default avatar image
even at 1x because we store the encoded image as a URL and use that
across all devices. Until / unless we redesign the system (e.g. to
support animations) this is the simplest solution for now.

BUG= 747855 

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib0ea4a4c50a5bbea3f755ed4c6e1a8462bb81371
Reviewed-on: https://chromium-review.googlesource.com/583470
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490043}
[modify] https://crrev.com/d59304b92c4640010cd4858ed89e62e0a1b3683d/ui/chromeos/resources/default_100_percent/default_user_images/avatar_anonymous.png
[delete] https://crrev.com/a3daa18dd96ac0a538c89e36152289bed4cfedbb/ui/chromeos/resources/default_200_percent/default_user_images/avatar_anonymous.png
[modify] https://crrev.com/d59304b92c4640010cd4858ed89e62e0a1b3683d/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.html
[modify] https://crrev.com/d59304b92c4640010cd4858ed89e62e0a1b3683d/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.js

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
9807.0.0, 62.0.3176.0
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 12 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/215f7f7a33edefc1f50eaa3e36445457a5424b74

commit 215f7f7a33edefc1f50eaa3e36445457a5424b74
Author: David Reveman <reveman@chromium.org>
Date: Sat Aug 12 05:20:03 2017

WebUI: Change Picture: Always use high res default avatar image

We need to use a hi-res (512x512) version of the default avatar image
even at 1x because we store the encoded image as a URL and use that
across all devices. Until / unless we redesign the system (e.g. to
support animations) this is the simplest solution for now.

BUG= 747855 
TBR=stevenjb@chromium.org

(cherry picked from commit d59304b92c4640010cd4858ed89e62e0a1b3683d)

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib0ea4a4c50a5bbea3f755ed4c6e1a8462bb81371
Reviewed-on: https://chromium-review.googlesource.com/583470
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490043}
Reviewed-on: https://chromium-review.googlesource.com/612763
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#503}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/215f7f7a33edefc1f50eaa3e36445457a5424b74/ui/chromeos/resources/default_100_percent/default_user_images/avatar_anonymous.png
[delete] https://crrev.com/6643745d08e818708aee506b49790a948ed528bf/ui/chromeos/resources/default_200_percent/default_user_images/avatar_anonymous.png
[modify] https://crrev.com/215f7f7a33edefc1f50eaa3e36445457a5424b74/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.html
[modify] https://crrev.com/215f7f7a33edefc1f50eaa3e36445457a5424b74/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.js

Sign in to add a comment