New issue
Advanced search Search tips

Issue 747851 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Truncation of error messages at chrome:policy

Project Member Reported by emaxx@chromium.org, Jul 24 2017

Issue description

Chrome Version: ToT

What steps will reproduce the problem?
(1) Set up a policy with an erroneous value - e.g. use YAPS (test policy server) for setting up the ExtensionInstallForcelist policy with value "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa".
(2) Visit chrome://policy.

What is the expected result?
The following error message is displayed for the ExtensionInstallForcelist policy:
    List entry "0": Value doesn't match format.

What happens instead?
The error message is truncated to:
    List entry "0": Value doesn't mat...


The workarounds are to hover the message and wait for the tooltip (which however doesn't help copy-pasting it) or to open the JS DevTools Console.
 

Comment 1 by emaxx@chromium.org, Jul 24 2017

To improve this, the overflow logic, which is currently used only for the policy values ([1]), could be extended onto the error messages.

[1] https://cs.chromium.org/chromium/src/chrome/browser/resources/policy.js?l=172&rcl=e8bee36f0d78e63f56f1a9aacd5333053ed852b4
Labels: Enterprise-Triaged Hotlist-GoodFirstBug
Owner: olsen@chromium.org
Status: Assigned (was: Untriaged)
Cc: olsen@chromium.org
Owner: acostinas@google.com
> (which however doesn't help copy-pasting it)

actually, I'm fairly sure if your text selection includes the ellipsis (…) it'll automatically copy the elided text.
I can confirm that on Windows and Linux copying the text with ellipsis will copy the elided text. Is this enough or should the same overflow behavior of the column value be applied to status?
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22de452e00724282c0213c84260e4430f521b767

commit 22de452e00724282c0213c84260e4430f521b767
Author: Andreea Costinas <acostinas@google.com>
Date: Fri Dec 28 14:47:29 2018

Add toggle link for status col. in chrome://policy

The patch adds the same overflow behaviour to the status column as
the value column. If the text doesn't fit the column width it will be
replaced with a link that toggles the visibility of a row containing
the full status text.

Bug:  747851 
Change-Id: I628666586481239e655b5c98f86bb3f719c4e9bf
Reviewed-on: https://chromium-review.googlesource.com/c/1371477
Commit-Queue: Andreea-Elena Costinas <acostinas@google.com>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: A Olsen <olsen@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Ivan Šandrk <isandrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619153}
[modify] https://crrev.com/22de452e00724282c0213c84260e4430f521b767/chrome/browser/resources/policy.html
[modify] https://crrev.com/22de452e00724282c0213c84260e4430f521b767/chrome/browser/resources/policy_android.css
[modify] https://crrev.com/22de452e00724282c0213c84260e4430f521b767/chrome/browser/resources/policy_base.js
[modify] https://crrev.com/22de452e00724282c0213c84260e4430f521b767/chrome/browser/resources/policy_common.css
[modify] https://crrev.com/22de452e00724282c0213c84260e4430f521b767/chrome/browser/resources/policy_tool.html
[modify] https://crrev.com/22de452e00724282c0213c84260e4430f521b767/chrome/browser/resources/policy_tool.js
[modify] https://crrev.com/22de452e00724282c0213c84260e4430f521b767/chrome/browser/ui/webui/policy_tool_ui.cc
[modify] https://crrev.com/22de452e00724282c0213c84260e4430f521b767/chrome/browser/ui/webui/policy_tool_ui_browsertest.cc
[modify] https://crrev.com/22de452e00724282c0213c84260e4430f521b767/chrome/browser/ui/webui/policy_ui.cc
[modify] https://crrev.com/22de452e00724282c0213c84260e4430f521b767/chrome/browser/ui/webui/policy_ui_browsertest.cc
[modify] https://crrev.com/22de452e00724282c0213c84260e4430f521b767/components/policy_strings.grdp

Status: Verified (was: Assigned)

Sign in to add a comment