New issue
Advanced search Search tips

Issue 747848 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

DCHECK hit on CalledOnValidSequence in AndroidDeviceManager

Project Member Reported by emaxx@chromium.org, Jul 24 2017

Issue description

Chrome Version: ToT (M61)

What steps will reproduce the problem?
(1) Build and deploy Chrome with enabled DCHECKs to Chrome OS.
(2) Run for a few minutes.

What happens instead?
[FATAL:android_device_manager.cc(461)] Check failed: (sequence_checker_).CalledOnValidSequence(). 
#0 0x7fb0392a64bd base::debug::StackTrace::StackTrace()
#1 0x7fb0392a4f2c base::debug::StackTrace::StackTrace()
#2 0x7fb0392f2f93 logging::LogMessage::~LogMessage()
#3 0x7fb03e213f0b AndroidDeviceManager::Device::~Device()
#4 0x7fb03e214199 AndroidDeviceManager::Device::~Device()
#5 0x7fb032feb65b base::RefCountedThreadSafe<>::DeleteInternal()
#6 0x7fb032feb625 base::DefaultRefCountedThreadSafeTraits<>::Destruct()
#7 0x7fb03e22679c base::RefCountedThreadSafe<>::Release()
#8 0x7fb03e226759 scoped_refptr<>::Release()
#9 0x7fb03e21961a scoped_refptr<>::~scoped_refptr()
#10 0x7fb03e225aa5 std::_Destroy<>()
#11 0x7fb03e2313d3 _ZNSt11_Tuple_implILm1EJ13scoped_refptrIN20AndroidDeviceManager6DeviceEES0_IN23DevToolsDeviceDiscovery13RemoteBrowserEEEED2Ev
#12 0x7fb03e23139f _ZNSt11_Tuple_implILm0EJ13scoped_refptrIN23DevToolsDeviceDiscovery16DiscoveryRequestEES0_IN20AndroidDeviceManager6DeviceEES0_INS1_13RemoteBrowserEEEED2Ev
#13 0x7fb03e231365 _ZNSt5tupleIJ13scoped_refptrIN23DevToolsDeviceDiscovery16DiscoveryRequestEES0_IN20AndroidDeviceManager6DeviceEES0_INS1_13RemoteBrowserEEEED2Ev
#14 0x7fb03e231333 _ZN4base8internal9BindStateIMN23DevToolsDeviceDiscovery16DiscoveryRequestEFv13scoped_refptrIN20AndroidDeviceManager6DeviceEES4_INS2_13RemoteBrowserEEiRKSsEJS4_IS3_ES7_S9_EED2Ev
#15 0x7fb03e231297 _ZN4base8internal9BindStateIMN23DevToolsDeviceDiscovery16DiscoveryRequestEFv13scoped_refptrIN20AndroidDeviceManager6DeviceEES4_INS2_13RemoteBrowserEEiRKSsEJS4_IS3_ES7_S9_EE7DestroyEPKNS0_13BindStateBaseE
#16 0x7fb039280c65 base::internal::BindStateBaseRefCountTraits::Destruct()
#17 0x7fb0392816d8 base::RefCountedThreadSafe<>::Release()
#18 0x7fb039281695 scoped_refptr<>::Release()
#19 0x7fb03928163a scoped_refptr<>::~scoped_refptr()
#20 0x7fb039281155 base::internal::CallbackBase<>::~CallbackBase()
#21 0x7fb032e2eb85 base::internal::CallbackBase<>::~CallbackBase()
#22 0x7fb032e2dcf5 base::Callback<>::~Callback()
#23 0x7fb032ff8b75 std::_Head_base<>::~_Head_base()
#24 0x7fb032ff8b55 _ZNSt11_Tuple_implILm1EJN4base8CallbackIFvN11google_apis17DriveApiErrorCodeERKSsELNS0_8internal8CopyModeE1ELNS7_10RepeatModeE1EEEEED2Ev
#25 0x7fb0342d0fbf _ZNSt11_Tuple_implILm1EJ13scoped_refptrIN4base22SingleThreadTaskRunnerEENS1_8CallbackIFvvELNS1_8internal8CopyModeE1ELNS6_10RepeatModeE1EEEEED2Ev
#26 0x7fb03e221585 _ZNSt5tupleIJ13scoped_refptrIN4base22SingleThreadTaskRunnerEENS1_8CallbackIFviRKSsELNS1_8internal8CopyModeE1ELNS8_10RepeatModeE1EEEEED2Ev
#27 0x7fb03e221553 _ZN4base8internal9BindStateIPFv13scoped_refptrINS_22SingleThreadTaskRunnerEERKNS_8CallbackIFviRKSsELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEiS7_EJS4_SB_EED2Ev
#28 0x7fb03e2214c7 _ZN4base8internal9BindStateIPFv13scoped_refptrINS_22SingleThreadTaskRunnerEERKNS_8CallbackIFviRKSsELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEiS7_EJS4_SB_EE7DestroyEPKNS0_13BindStateBaseE
#29 0x7fb039280c65 base::internal::BindStateBaseRefCountTraits::Destruct()
#30 0x7fb0392816d8 base::RefCountedThreadSafe<>::Release()
#31 0x7fb039281695 scoped_refptr<>::Release()
#32 0x7fb03928163a scoped_refptr<>::~scoped_refptr()
#33 0x7fb039281155 base::internal::CallbackBase<>::~CallbackBase()
#34 0x7fb032e2eb85 base::internal::CallbackBase<>::~CallbackBase()
#35 0x7fb032e2dcf5 base::Callback<>::~Callback()
#36 0x7fb032ff8b75 std::_Head_base<>::~_Head_base()
#37 0x7fb032ff8b55 _ZNSt11_Tuple_implILm1EJN4base8CallbackIFvN11google_apis17DriveApiErrorCodeERKSsELNS0_8internal8CopyModeE1ELNS7_10RepeatModeE1EEEEED2Ev
#38 0x7fb03e221eef _ZNSt11_Tuple_implILm3EJSsN4base8CallbackIFviRKSsELNS0_8internal8CopyModeE1ELNS5_10RepeatModeE1EEEEED2Ev
#39 0x7fb03e221eaf _ZNSt11_Tuple_implILm2EJSsSsN4base8CallbackIFviRKSsELNS0_8internal8CopyModeE1ELNS5_10RepeatModeE1EEEEED2Ev
#40 0x7fb03e221e6f _ZNSt11_Tuple_implILm1EJSsSsSsN4base8CallbackIFviRKSsELNS0_8internal8CopyModeE1ELNS5_10RepeatModeE1EEEEED2Ev
#41 0x7fb03e221e2f _ZNSt11_Tuple_implILm0EJ13scoped_refptrIN20AndroidDeviceManager14DeviceProviderEESsSsSsN4base8CallbackIFviRKSsELNS4_8internal8CopyModeE1ELNS9_10RepeatModeE1EEEEED2Ev
#42 0x7fb03e221df5 _ZNSt5tupleIJ13scoped_refptrIN20AndroidDeviceManager14DeviceProviderEESsSsSsN4base8CallbackIFviRKSsELNS4_8internal8CopyModeE1ELNS9_10RepeatModeE1EEEEED2Ev
#43 0x7fb03e221dc3 _ZN4base8internal9BindStateIMN20AndroidDeviceManager14DeviceProviderEFvRKSsS5_S5_RKNS_8CallbackIFviS5_ELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEEJ13scoped_refptrIS3_ESsSsSsSA_EED2Ev
#44 0x7fb03e221cf7 _ZN4base8internal9BindStateIMN20AndroidDeviceManager14DeviceProviderEFvRKSsS5_S5_RKNS_8CallbackIFviS5_ELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEEJ13scoped_refptrIS3_ESsSsSsSA_EE7DestroyEPKNS0_13BindStateBaseE
#45 0x7fb039280c65 base::internal::BindStateBaseRefCountTraits::Destruct()
#46 0x7fb0392816d8 base::RefCountedThreadSafe<>::Release()
#47 0x7fb039281695 scoped_refptr<>::Release()
#48 0x7fb03928163a scoped_refptr<>::~scoped_refptr()
#49 0x7fb039281155 base::internal::CallbackBase<>::~CallbackBase()
#50 0x7fb032e2eb85 base::internal::CallbackBase<>::~CallbackBase()
#51 0x7fb03312eec2 _ZNO4base8CallbackIFvvELNS_8internal8CopyModeE0ELNS2_10RepeatModeE0EE3RunEv
#52 0x7fb03950c662 base::debug::TaskAnnotator::RunTask()
#53 0x7fb039316e8d base::MessageLoop::RunTask()
#54 0x7fb039317127 base::MessageLoop::DeferOrRunPendingTask()
#55 0x7fb03931745b base::MessageLoop::DoWork()
#56 0x7fb03932defe base::MessagePumpLibevent::Run()
#57 0x7fb039316818 base::MessageLoop::Run()
#58 0x7fb0393b4e3d base::RunLoop::Run()
#59 0x7fb039441ef4 base::Thread::Run()
#60 0x7fb03944275a base::Thread::ThreadMain()
#61 0x7fb039423c9c base::(anonymous namespace)::ThreadFunc()
 

Comment 1 by emaxx@chromium.org, Jul 24 2017

Owner: caseq@chromium.org
caseq@: Andrey, could you please check whether change 5c4bbafa0d3cee8b39639b62e3990832a3df7522 could cause this?
That's the latest change that touched android_device_manager.cc.

Comment 2 by caseq@chromium.org, Jul 24 2017

Status: Started (was: Untriaged)
Yup, that's likely me, looking!
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb5f143fc17d812ec1bdc9371dc0e33921a104da

commit eb5f143fc17d812ec1bdc9371dc0e33921a104da
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Wed Jul 26 00:20:09 2017

DevTools: destroy AndroidDeviceManader::Device on correct thread

We can't really assume on what thread it gets destroyed, so make sure it gets destroyed on the same thread that it is created.

Bug:  747848 
Change-Id: Ib180acf588af949e65d786f5b5a7a2c4412486bb
Reviewed-on: https://chromium-review.googlesource.com/583991
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489492}
[modify] https://crrev.com/eb5f143fc17d812ec1bdc9371dc0e33921a104da/chrome/browser/devtools/device/android_device_manager.cc
[modify] https://crrev.com/eb5f143fc17d812ec1bdc9371dc0e33921a104da/chrome/browser/devtools/device/android_device_manager.h

Comment 4 by caseq@chromium.org, Jul 26 2017

Status: Fixed (was: Started)
Couldn't repro this, so the fix is speculative, but please give it a try.

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment