Issue metadata
Sign in to add a comment
|
Regression:Underline of the dropdown is not seen in chrome://settings/clearBrowserData when zoomed to 90% |
||||||||||||||||||||||
Issue descriptionChrome Version:62.0.3165.0 OS:Ubuntu 14.04, Windows What steps will reproduce the problem? (1)Launch chrome and navigate to chrome://settings/clearBrowserData (2)Zoom to 90% and observe Expected:Underline of the dropdown should be seen Actual:Instead, it's not seen This is a Regression issue broken in M-62 Manual Bisect info: =================== Good Build:61.0.3163.0 Bad Build: 62.0.3164.0
,
Jul 24 2017
Able to reproduce the issue on Win-10 using latest canary #62.0.3165.0. Issue is not seen in OS-Mac
,
Jul 24 2017
Using per revision bisect providing bisect results below. Bisect Information: -------------------- You are probably looking for a change made after 488563 (known good), but no later than 488564 (first known bad). Change Log URL: ----------------- https://chromium.googlesource.com/chromium/src/+log/41b2241e9840a5d98f1f6c48f0dd899c59722e88..80f42ed65b2efec437ac51c31ebcc782dae85328 dschuyler@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thanks!!
,
Jul 24 2017
,
Jul 25 2017
Not sure if the abev bisection is correct. I am suspecting that https://chromium-review.googlesource.com/c/566826/ is the culprit, which change the height of the underline.
,
Jul 25 2017
I checked on #5 and that lines up. Removing the height: 0; in that CL fixes this issue. Trivia: I also found that setting the height can also fix the issue.
,
Jul 25 2017
I also looked into keeping the height: 0; and found that this seems to be workable, but it's a hack, so I'm not keen on it: https://chromium-review.googlesource.com/c/584093/
,
Jul 25 2017
Thanks for investigating Dave. I agree that 584093 is a bit hacky. Probably cleaner to partially revert the original CL 566826.
,
Jul 25 2017
Issue 748397 has been merged into this issue.
,
Jul 25 2017
I created a CL to remove 'height: 0' again http://crrev.com/c/584667. My initial CL is in M61, should I merge the fix after it is submitted?
,
Jul 25 2017
Yes, let's request a merge since this would affect all md-select instances, not just the one in CBD.
,
Jul 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45ba68f36c1ac34f7a5a584bde8621394c2618ae commit 45ba68f36c1ac34f7a5a584bde8621394c2618ae Author: Christian Dullweber <dullweber@chromium.org> Date: Tue Jul 25 21:42:35 2017 Remove 'height: 0' from md-select-underline Setting 'height: 0' in http://crrev.com/c/566826 caused issues when zooming out. This CL removes the height attribute and increases the margin in Clear Browsing Data to keep the dropdown and the label on the same height. Screenshot 100% https://screenshot.googleplex.com/jJAZs5TFgiD.png Screenshot 90% https://screenshot.googleplex.com/ZrDWbud2VVs.png Bug: 747842 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic3d08a1e0b3a28e25ddde70a35a373bf089cb277 Reviewed-on: https://chromium-review.googlesource.com/584667 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#489447} [modify] https://crrev.com/45ba68f36c1ac34f7a5a584bde8621394c2618ae/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html [modify] https://crrev.com/45ba68f36c1ac34f7a5a584bde8621394c2618ae/ui/webui/resources/html/md_select_css.html
,
Jul 26 2017
I would like to request a merge to M61 for a css fix that partially reverts a change introduced in M61.
,
Jul 27 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f22d13b53812146dbbafac9d3afc2e918f5d736 commit 8f22d13b53812146dbbafac9d3afc2e918f5d736 Author: Christian Dullweber <dullweber@chromium.org> Date: Thu Jul 27 10:52:07 2017 Remove 'height: 0' from md-select-underline Setting 'height: 0' in http://crrev.com/c/566826 caused issues when zooming out. This CL removes the height attribute and increases the margin in Clear Browsing Data to keep the dropdown and the label on the same height. Screenshot 100% https://screenshot.googleplex.com/jJAZs5TFgiD.png Screenshot 90% https://screenshot.googleplex.com/ZrDWbud2VVs.png TBR=dullweber@chromium.org (cherry picked from commit 45ba68f36c1ac34f7a5a584bde8621394c2618ae) Bug: 747842 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic3d08a1e0b3a28e25ddde70a35a373bf089cb277 Reviewed-on: https://chromium-review.googlesource.com/584667 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#489447} Reviewed-on: https://chromium-review.googlesource.com/588909 Reviewed-by: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#75} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/8f22d13b53812146dbbafac9d3afc2e918f5d736/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html [modify] https://crrev.com/8f22d13b53812146dbbafac9d3afc2e918f5d736/ui/webui/resources/html/md_select_css.html
,
Jul 27 2017
,
Aug 1 2017
Verified the issue on latest 61 i.e;61.0.3163.25 dev and is fixed. So, adding verified labels. Thanks!!
,
Aug 1 2017
Note: Above issue is fixed on latest Dev version:61.0.3163.25 (Official Build) on Windows,Linux Please find the attachment. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by keerthan...@techmahindra.com
, Jul 24 2017