New issue
Advanced search Search tips

Issue 747838 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

MDC autoroller is broken

Project Member Reported by gambard@chromium.org, Jul 24 2017

Issue description

MDC autoroller is broken because MDC deprecated customTitleColor.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/656e2b07d03c0bbf0a13e722e917793e88755f6c

commit 656e2b07d03c0bbf0a13e722e917793e88755f6c
Author: gambard <gambard@chromium.org>
Date: Mon Jul 24 18:40:11 2017

Replace customTitleColor with setTitleColor:forState:

As MDC deprecates customTitleColor, its uses should be removed.

Bug:  747838 
Change-Id: Ibb156a8aaa3fe984cd8aec0b234d5c11369c185e
Reviewed-on: https://chromium-review.googlesource.com/581688
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489030}
[modify] https://crrev.com/656e2b07d03c0bbf0a13e722e917793e88755f6c/ios/chrome/browser/passwords/password_generation_prompt_view.mm
[modify] https://crrev.com/656e2b07d03c0bbf0a13e722e917793e88755f6c/ios/chrome/browser/ui/alert_coordinator/loading_alert_coordinator.mm
[modify] https://crrev.com/656e2b07d03c0bbf0a13e722e917793e88755f6c/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm
[modify] https://crrev.com/656e2b07d03c0bbf0a13e722e917793e88755f6c/ios/chrome/browser/ui/authentication/signed_in_accounts_view_controller.mm
[modify] https://crrev.com/656e2b07d03c0bbf0a13e722e917793e88755f6c/ios/chrome/browser/ui/authentication/signin_promo_view.mm
[modify] https://crrev.com/656e2b07d03c0bbf0a13e722e917793e88755f6c/ios/chrome/browser/ui/bookmarks/bookmark_promo_cell.mm
[modify] https://crrev.com/656e2b07d03c0bbf0a13e722e917793e88755f6c/ios/chrome/browser/ui/contextual_search/contextual_search_promo_view.mm
[modify] https://crrev.com/656e2b07d03c0bbf0a13e722e917793e88755f6c/ios/chrome/browser/ui/fancy_ui/primary_action_button.mm
[modify] https://crrev.com/656e2b07d03c0bbf0a13e722e917793e88755f6c/ios/chrome/browser/ui/infobars/infobar_view.mm
[modify] https://crrev.com/656e2b07d03c0bbf0a13e722e917793e88755f6c/ios/chrome/browser/ui/ntp/incognito_panel_controller.mm
[modify] https://crrev.com/656e2b07d03c0bbf0a13e722e917793e88755f6c/ios/chrome/browser/ui/open_in_toolbar.mm
[modify] https://crrev.com/656e2b07d03c0bbf0a13e722e917793e88755f6c/ios/chrome/browser/ui/payments/payment_items_display_view_controller.mm
[modify] https://crrev.com/656e2b07d03c0bbf0a13e722e917793e88755f6c/ios/chrome/browser/ui/payments/payment_request_view_controller.mm
[modify] https://crrev.com/656e2b07d03c0bbf0a13e722e917793e88755f6c/ios/chrome/browser/ui/sad_tab/sad_tab_view.mm
[modify] https://crrev.com/656e2b07d03c0bbf0a13e722e917793e88755f6c/ios/chrome/browser/ui/settings/cells/copied_to_chrome_item.mm
[modify] https://crrev.com/656e2b07d03c0bbf0a13e722e917793e88755f6c/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_overlay_view.mm
[modify] https://crrev.com/656e2b07d03c0bbf0a13e722e917793e88755f6c/remoting/ios/app/first_launch_view_controller.mm
[modify] https://crrev.com/656e2b07d03c0bbf0a13e722e917793e88755f6c/remoting/ios/app/host_setup_footer_view.mm

Status: Fixed (was: Assigned)

Sign in to add a comment