Regression: Default mouse pointer is seen instead of hand pointer while hovering on crash bubble |
||||||||||
Issue descriptionChrome Version: 62.0.3165.0 OS: Ubuntu 14.04,Windows Pre-Condition: Add any extension that is seen in browser containment area [Ex: https://chrome.google.com/webstore/detail/grammarly-for-chrome/kbfnbcaeplbcioakkpcpgfkobkghlhen?utm_source=chrome-ntp-icon ] What steps will reproduce the problem? (1)Launch chrome and add above extension >> Now from task manager kill that extension and hover on crash bubble of that extension and observe Expected: Hand pointer should be seen while hovering on bubble. Actual: Instead default mouse pointer is seen. This is a regression issue broken in M61. Manual Bisect Info: ==================== Good Build: 61.0.3149.0 dev Bad Build: 61.0.3150.0 dev
,
Jul 24 2017
Using per revision bisect providing bisect results below. Bisect Information: -------------------- You are probably looking for a change made after 484218 (known good), but no later than 484219 (first known bad). Change Log URL: ----------------- https://chromium.googlesource.com/chromium/src/+log/28c838c598c2e513ac94512f828c4ee43af4e5d6..12cad72cd90108551c79ebde78ed564832478707 yoshiki@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thanks!!
,
Jul 25 2017
Thank you for reporting. Let me fix.
,
Jul 26 2017
URGENT - PTAL. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the M61 branch #3163 ASAP to have enough baking time in Beta before Stable promotion. Thank you! Know that this issue shouldn't block the release? Remove the ReleaseBlock-Stable label.
,
Jul 27 2017
The CL is in the CQ: https://chromium-review.googlesource.com/c/584633/
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf18cf3b5c6e9ef66e9852c94dc5274a48960b60 commit cf18cf3b5c6e9ef66e9852c94dc5274a48960b60 Author: yoshiki iguchi <yoshiki@chromium.org> Date: Thu Jul 27 09:02:50 2017 Revert back NotificationView::TargetForRect This method was once removed crrev.com/12cad72cd, but it caused the issue. This patch reverts back the method and fixes the issue. Bug: 747809 Change-Id: Iec144426af09161e009c96f8ddfb4ffe8f157552 Reviewed-on: https://chromium-review.googlesource.com/584633 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#489886} [modify] https://crrev.com/cf18cf3b5c6e9ef66e9852c94dc5274a48960b60/ui/arc/notification/arc_notification_content_view_unittest.cc [modify] https://crrev.com/cf18cf3b5c6e9ef66e9852c94dc5274a48960b60/ui/message_center/views/notification_control_buttons_view.cc [modify] https://crrev.com/cf18cf3b5c6e9ef66e9852c94dc5274a48960b60/ui/message_center/views/notification_control_buttons_view.h [modify] https://crrev.com/cf18cf3b5c6e9ef66e9852c94dc5274a48960b60/ui/message_center/views/notification_view.cc [modify] https://crrev.com/cf18cf3b5c6e9ef66e9852c94dc5274a48960b60/ui/message_center/views/notification_view.h [modify] https://crrev.com/cf18cf3b5c6e9ef66e9852c94dc5274a48960b60/ui/message_center/views/notification_view_unittest.cc
,
Jul 27 2017
,
Jul 27 2017
,
Jul 28 2017
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 28 2017
Before we approve merge to M61, could you please confirm cl listed at #6 is well baked/verified in Canary, having enough automation tests coverage and will be a safe merge to M61?
,
Aug 2 2017
Above issue is fixed on latest Canary version: 62.0.3174.0 (Official Build) Thanks you.
,
Aug 2 2017
I also verified the fix on Mac (62.0.3174.0).
,
Aug 2 2017
Approving merge to M61 branch 3163 based on comment #11 and #12.
,
Aug 3 2017
Pls merge you change to M61 branch 3163 by 5:00 PM PT, Friday (08/04) so we can take it in for next week M61 Beta release. Thank you.
,
Aug 4 2017
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49c5032973af575c69a15d04a80b9d0ab9ed7dd3 commit 49c5032973af575c69a15d04a80b9d0ab9ed7dd3 Author: yoshiki iguchi <yoshiki@chromium.org> Date: Fri Aug 04 02:17:26 2017 Revert back NotificationView::TargetForRect This method was once removed crrev.com/12cad72cd, but it caused the issue. This patch reverts back the method and fixes the issue. TBR=yoshiki@chromium.org (cherry picked from commit cf18cf3b5c6e9ef66e9852c94dc5274a48960b60) Bug: 747809 Change-Id: Iec144426af09161e009c96f8ddfb4ffe8f157552 Reviewed-on: https://chromium-review.googlesource.com/584633 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#489886} Reviewed-on: https://chromium-review.googlesource.com/601607 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#304} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/49c5032973af575c69a15d04a80b9d0ab9ed7dd3/ui/arc/notification/arc_notification_content_view_unittest.cc [modify] https://crrev.com/49c5032973af575c69a15d04a80b9d0ab9ed7dd3/ui/message_center/views/notification_control_buttons_view.cc [modify] https://crrev.com/49c5032973af575c69a15d04a80b9d0ab9ed7dd3/ui/message_center/views/notification_control_buttons_view.h [modify] https://crrev.com/49c5032973af575c69a15d04a80b9d0ab9ed7dd3/ui/message_center/views/notification_view.cc [modify] https://crrev.com/49c5032973af575c69a15d04a80b9d0ab9ed7dd3/ui/message_center/views/notification_view.h [modify] https://crrev.com/49c5032973af575c69a15d04a80b9d0ab9ed7dd3/ui/message_center/views/notification_view_unittest.cc
,
Aug 4 2017
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by brajkumar@chromium.org
, Jul 24 2017Status: Untriaged (was: Unconfirmed)