Issue metadata
Sign in to add a comment
|
115.2% regression in v8.runtimestats.browsing_mobile at 488678:488775 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jul 24 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8973206221808446784
,
Jul 24 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8973206210715725712
,
Jul 24 2017
,
Jul 24 2017
=== Auto-CCing suspected CL author ulan@chromium.org === Hi ulan@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Ulan Degenbaev Commit : 858052930221bf05230d8e0eb0e681bf9b532980 Date : Thu Jul 20 13:47:22 2017 Subject: [heap] Remove clearing of caches and counter of shared function info in Bisect Details Configuration: android_one_perf_bisect Benchmark : v8.runtimestats.browsing_mobile Metric : Optimize:duration_avg/browse_social/browse_social_instagram Change : 184.85% | 112.454333333 -> 314.148888889 Revision Result N chromium@488677 112.454 +- 134.395 6 good chromium@488726 143.319 +- 61.5859 9 good chromium@488739 140.79 +- 65.2678 9 good chromium@488745 153.786 +- 123.39 9 good chromium@488745,v8@b23b8c088c 165.821 +- 74.3149 6 good chromium@488745,v8@1084d20978 173.854 +- 63.0513 6 good chromium@488745,v8@b30ea1646a 166.54 +- 47.3857 6 good chromium@488745,v8@8580529302 314.115 +- 65.1378 6 bad <-- chromium@488745,v8@ecd06ed09f 307.506 +- 81.8883 6 bad chromium@488745,v8@f24b6f96f8 306.985 +- 89.3106 6 bad chromium@488745,v8@8ab48b6c04 301.373 +- 78.8628 6 bad chromium@488746 311.007 +- 33.3586 6 bad chromium@488747 278.253 +- 303.031 9 bad chromium@488748 267.946 +- 292.141 9 bad chromium@488751 262.81 +- 415.142 14 bad chromium@488775 314.149 +- 45.0645 9 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.social.instagram v8.runtimestats.browsing_mobile More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8973206221808446784 For feedback, file a bug with component Speed>Bisection
,
Jul 24 2017
=== BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Ulan Degenbaev Commit : 858052930221bf05230d8e0eb0e681bf9b532980 Date : Thu Jul 20 13:47:22 2017 Subject: [heap] Remove clearing of caches and counter of shared function info in Bisect Details Configuration: android_one_perf_bisect Benchmark : v8.runtimestats.browsing_mobile Metric : Optimize:duration_avg/browse_social/browse_social_instagram Change : 182.86% | 134.287166667 -> 379.8435 Revision Result N chromium@488677 134.287 +- 158.493 6 good chromium@488726 171.678 +- 147.833 9 good chromium@488739 185.999 +- 258.153 14 good chromium@488745 173.262 +- 108.926 9 good chromium@488745,v8@b23b8c088c 187.217 +- 25.9094 6 good chromium@488745,v8@1084d20978 181.601 +- 77.7743 6 good chromium@488745,v8@b30ea1646a 163.847 +- 59.5465 6 good chromium@488745,v8@8580529302 406.377 +- 93.1383 6 bad <-- chromium@488745,v8@ecd06ed09f 436.965 +- 227.963 6 bad chromium@488745,v8@f24b6f96f8 400.427 +- 45.4476 5 bad chromium@488745,v8@8ab48b6c04 362.21 +- 158.069 6 bad chromium@488746 399.302 +- 91.6473 6 bad chromium@488747 390.441 +- 155.995 6 bad chromium@488748 373.615 +- 92.0916 6 bad chromium@488751 354.486 +- 454.513 9 bad chromium@488775 379.843 +- 150.564 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.social.instagram v8.runtimestats.browsing_mobile More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8973206210715725712 For feedback, file a bug with component Speed>Bisection
,
Jul 25 2017
,
Jul 25 2017
Revert in progress.
,
Jul 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/6e3d7ee6cb8d2ad2b4052ce84e03ae0181840d49 commit 6e3d7ee6cb8d2ad2b4052ce84e03ae0181840d49 Author: Ulan Degenbaev <ulan@chromium.org> Date: Tue Jul 25 10:42:56 2017 Revert "[heap] Remove clearing of caches and counter of shared function info in" This reverts commit 858052930221bf05230d8e0eb0e681bf9b532980. Reason for revert: increased memory usage on benchmarks. BUG= chromium:747806 Original change's description: > [heap] Remove clearing of caches and counter of shared function info in > marking visitors. > > This makes incremental and concurrent visitors of share function infos > side-effect free. > > BUG= chromium:694255 > > Change-Id: I85ee7bac17f17bdbc101ef64ecfb46020b5b3458 > Reviewed-on: https://chromium-review.googlesource.com/574851 > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#46796} TBR=ulan@chromium.org,mlippautz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:694255 Change-Id: Id28551ce8378820b0272721b7efb388727c442d4 Reviewed-on: https://chromium-review.googlesource.com/584288 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#46864} [modify] https://crrev.com/6e3d7ee6cb8d2ad2b4052ce84e03ae0181840d49/src/heap/concurrent-marking.cc [modify] https://crrev.com/6e3d7ee6cb8d2ad2b4052ce84e03ae0181840d49/src/heap/mark-compact.cc [modify] https://crrev.com/6e3d7ee6cb8d2ad2b4052ce84e03ae0181840d49/src/heap/objects-visiting-inl.h [modify] https://crrev.com/6e3d7ee6cb8d2ad2b4052ce84e03ae0181840d49/src/heap/objects-visiting.h [modify] https://crrev.com/6e3d7ee6cb8d2ad2b4052ce84e03ae0181840d49/test/cctest/heap/test-heap.cc
,
Aug 21 2017
The culprit was reverted. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jul 24 2017