Regression: Unable to select Ask (default) option from Location drop down.
Reported by
db...@etouch.net,
Jul 24 2017
|
|||
Issue descriptionChrome Version:62.0.3165.0 Revision ebd65246aab3b4b1cb5bd462388344195420078d-refs/heads/master@{#488876}(32/64 bit) OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.3) What steps will reproduce the problem? (1) Launch chrome, navigate to https://permission.site, click on location and Allowed it. (2) Then navigate to chrome://settings/content/location and click on link(site details opened) (3) Click on 'Location' drop down and try to select Ask (default) option, observe. Actual: Unable to select Ask (default) option from Location drop down. Expected: Ask (default) option should get select or Ask (default) option should not seen. This is a regression issue, broken in 'M-61', will soon update the bisect info: Good Build: 61.0.3162.0 Bad Build: 61.0.3163.0
,
Jul 25 2017
This is caused by the UI in Site Details always adding new patterns instead of setting origin-scoped permissions. A CL to fix this should be landing soon here: https://chromium-review.googlesource.com/c/569551
,
Jul 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f603c205cd6a8ddabb2884658e2ab0ebce0b07e3 commit f603c205cd6a8ddabb2884658e2ab0ebce0b07e3 Author: Patricia Lor <patricialor@chromium.org> Date: Tue Jul 25 04:44:12 2017 MD Settings: Add a non-pattern way to set origin permissions for Site Details. Currently, setting origin-scoped permissions in "Site Details" calls HostContentSettingMap::SetContentSettingCustomScope(). This is technically supposed to only be used for setting ContentSettingPatterns, which can cross over multiple origins, if the pattern allows for it. To fix, implement a new method SiteSettingsHandler::HandleSetOriginPermissions, which uses HostContentSettingMap::SetNarrowestContentSetting(), which only handles origin-scoped permissions. This is more appropriate for Site Details, which shows permissions for a specific origin. "Site settings". When the "Site Details" page opens, change a few of the permissions listed there away from the original setting, and verify that a) The drop-down doesn't immediately switch back to the original setting. b) Switching back to the tab with https://permission.site and opening the Page Info bubble shows the change that was just made accurately. c) Refreshing the "Site Details" page still shows the new setting in the drop-downs. Also try clicking the "Clear and Reset" button underneath all the permissions, and verify that it sets all the permissions back to their default values (which will show up in "Site Details" on refresh), and that this is reflected in the Page Info bubble as well as "Site Details". Bug: 656758 , 747794 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9fdae9214389a7da11bb03e5407f3b57c0da46dd Test: Navigate to https://permission.site. Open the Page Info bubble, then click Reviewed-on: https://chromium-review.googlesource.com/569551 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Raymes Khoury <raymes@chromium.org> Reviewed-by: Tim Sergeant <tsergeant@chromium.org> Cr-Commit-Position: refs/heads/master@{#489232} [modify] https://crrev.com/f603c205cd6a8ddabb2884658e2ab0ebce0b07e3/chrome/browser/extensions/api/content_settings/content_settings_api.cc [modify] https://crrev.com/f603c205cd6a8ddabb2884658e2ab0ebce0b07e3/chrome/browser/extensions/api/content_settings/content_settings_store.cc [modify] https://crrev.com/f603c205cd6a8ddabb2884658e2ab0ebce0b07e3/chrome/browser/resources/settings/site_settings/add_site_dialog.js [modify] https://crrev.com/f603c205cd6a8ddabb2884658e2ab0ebce0b07e3/chrome/browser/resources/settings/site_settings/edit_exception_dialog.js [modify] https://crrev.com/f603c205cd6a8ddabb2884658e2ab0ebce0b07e3/chrome/browser/resources/settings/site_settings/site_details.js [modify] https://crrev.com/f603c205cd6a8ddabb2884658e2ab0ebce0b07e3/chrome/browser/resources/settings/site_settings/site_details_permission.js [modify] https://crrev.com/f603c205cd6a8ddabb2884658e2ab0ebce0b07e3/chrome/browser/resources/settings/site_settings/site_list.js [modify] https://crrev.com/f603c205cd6a8ddabb2884658e2ab0ebce0b07e3/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js [modify] https://crrev.com/f603c205cd6a8ddabb2884658e2ab0ebce0b07e3/chrome/browser/ui/webui/settings/site_settings_handler.cc [modify] https://crrev.com/f603c205cd6a8ddabb2884658e2ab0ebce0b07e3/chrome/browser/ui/webui/settings/site_settings_handler.h [modify] https://crrev.com/f603c205cd6a8ddabb2884658e2ab0ebce0b07e3/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc [modify] https://crrev.com/f603c205cd6a8ddabb2884658e2ab0ebce0b07e3/chrome/test/data/webui/settings/site_details_permission_tests.js [modify] https://crrev.com/f603c205cd6a8ddabb2884658e2ab0ebce0b07e3/chrome/test/data/webui/settings/site_list_tests.js [modify] https://crrev.com/f603c205cd6a8ddabb2884658e2ab0ebce0b07e3/chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js [modify] https://crrev.com/f603c205cd6a8ddabb2884658e2ab0ebce0b07e3/components/content_settings/core/browser/content_settings_utils.cc [modify] https://crrev.com/f603c205cd6a8ddabb2884658e2ab0ebce0b07e3/components/content_settings/core/browser/content_settings_utils_unittest.cc
,
Jul 25 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by db...@etouch.net
, Jul 24 2017Owner: patricia...@chromium.org
Status: Assigned (was: Unconfirmed)