New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 747792 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Browser crashes on clicking report an issue of cast in guest mode

Project Member Reported by keerthan...@techmahindra.com, Jul 24 2017

Issue description

Chrome Version:62.0.3164.0
OS: Ubuntu 14.04, Windows

What steps will reproduce the problem?
1. Launch chrome and navigate to guest mode
2. Click on cast and on report an issue 
3. Chrome crashes

Crash id: 80638bee88000000
          8b34f3ee88000000
 
CrashGuest.ogv
1.4 MB View Download
Cc: kavvaru@chromium.org ajha@chromium.org brajkumar@chromium.org
Components: Internals>Cast
Labels: Stability-Crash
Labels: OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce this issue on Mac OS 10.12.5 using chrome latest dev #62.0.3164.0.
Manual Bisect Info:
====================
Good Build:61.0.3153.0
Bad Build: 61.0.3154.0
Labels: -Needs-Bisect ReleaseBlock-Beta
Owner: taku...@chromium.org
Status: Assigned (was: Untriaged)
Stack Trace:
-------------
Thread 0 (id: 7868) CRASHED [EXCEPTION_ACCESS_VIOLATION_READ @ 0x00000018 ] MAGIC SIGNATURE THREAD
Stack Quality100%Show frame trust levels
0x00007ffadd471f01	(chrome.dll -media_router_contextual_menu.cc:190 )	MediaRouterContextualMenu::ReportIssue()
0x00007ffadd471d83	(chrome.dll -media_router_contextual_menu.cc:171 )	MediaRouterContextualMenu::ExecuteCommand(int,int)
0x00007ffadca673f2	(chrome.dll -simple_menu_model.cc:388 )	ui::SimpleMenuModel::ActivatedAt(int,int)
0x00007ffadc20f6f8	(chrome.dll -menu_model_adapter.cc:154 )	views::MenuModelAdapter::ExecuteCommand(int,int)
0x00007ffadc200402	(chrome.dll -menu_runner_impl.cc:172 )	views::internal::MenuRunnerImpl::OnMenuClosed(views::internal::MenuControllerDelegate::NotifyType,views::MenuItemView *,int)
0x00007ffadc20b68c	(chrome.dll -menu_controller.cc:2565 )	views::MenuController::ExitMenu()
0x00007ffadc207a11	(chrome.dll -menu_controller.cc:726 )	views::MenuController::OnMouseReleased(views::SubmenuView *,ui::MouseEvent const &)
0x00007ffadc20eaca	(chrome.dll -menu_host_root_view.cc:28 )	views::MenuHostRootView::OnMouseReleased(ui::MouseEvent const &)
0x00007ffadc1c59b7	(chrome.dll -widget.cc:1220 )	views::Widget::OnMouseEvent(ui::MouseEvent *)
0x00007ffadca8e709	(chrome.dll -event_handler.cc:27 )	ui::EventHandler::OnEvent(ui::Event *)
0x00007ffadca8ed9f	(chrome.dll -event_dispatcher.cc:191 )	ui::EventDispatcher::DispatchEvent(ui::EventHandler *,ui::Event *)
0x00007ffadca8e922	(chrome.dll -event_dispatcher.cc:86 )	ui::EventDispatcherDelegate::DispatchEventToTarget(ui::EventTarget *,ui::Event *)
0x00007ffadca8e7a4	(chrome.dll -event_dispatcher.cc:58 )	ui::EventDispatcherDelegate::DispatchEvent(ui::EventTarget *,ui::Event *)
0x00007ffadca90d4a	(chrome.dll -event_processor.cc:46 )	ui::EventProcessor::OnEventFromSource(ui::Event *)
0x00007ffadca90a17	(chrome.dll -event_source.cc:51 )	ui::EventSource::SendEventToSink(ui::Event *)
0x00007ffadc1dcf30	(chrome.dll -desktop_window_tree_host_win.cc:842 )	views::DesktopWindowTreeHostWin::HandleScrollEvent(ui::ScrollEvent const &)
0x00007ffadc1f08fa	(chrome.dll -hwnd_message_handler.cc:2656 )	views::HWNDMessageHandler::HandleMouseEventInternal(unsigned int,unsigned __int64,__int64,bool)
0x00007ffadc1eacbc	(chrome.dll -hwnd_message_handler.h:355 )	views::HWNDMessageHandler::_ProcessWindowMessage(HWND__ *,unsigned int,unsigned __int64,__int64,__int64 &,unsigned long)
0x00007ffadc1ec9e0	(chrome.dll -hwnd_message_handler.cc:935 )	views::HWNDMessageHandler::OnWndProc(unsigned int,unsigned __int64,__int64)
0x00007ffadc6f00c0	(chrome.dll -window_impl.cc:303 )	gfx::WindowImpl::WndProc(HWND__ *,unsigned int,unsigned __int64,__int64)
0x00007ffadc6f0156	(chrome.dll -wrapped_window_proc.h:80 )	base::win::WrappedWindowProc<&gfx::WindowImpl::WndProc(HWND__ *,unsigned int,unsigned __int64,__int64)>(HWND__ *,unsigned int,unsigned __int64,__int64)
0x00007ffb0f941c23	(USER32.dll + 0x00011c23 )	UserCallWinProcCheckWow
0x00007ffb0f94156b	(USER32.dll + 0x0001156b )	DispatchMessageWorker
0x00007ffadc36b5fb	(chrome.dll -message_pump_win.cc:363 )	base::MessagePumpForUI::ProcessMessageHelper(tagMSG const &)
0x00007ffadc36b201	(chrome.dll -message_pump_win.cc:169 )	base::MessagePumpForUI::DoRunLoop()
0x00007ffadc36aea3	(chrome.dll -message_pump_win.cc:56 )	base::MessagePumpWin::Run(base::MessagePump::Delegate *)
0x00007ffadc3403a8	(chrome.dll -run_loop.cc:111 )	base::RunLoop::Run()
0x00007ffadc24c503	(chrome.dll -chrome_browser_main.cc:1956 )	ChromeBrowserMainParts::MainMessageLoopRun(int *)
0x00007ffadbc22c5b	(chrome.dll -browser_main_runner.cc:142 )	content::BrowserMainRunnerImpl::Run()
0x00007ffadbc1b2e4	(chrome.dll -browser_main.cc:46 )	content::BrowserMain(content::MainFunctionParams const &)
0x00007ffadc19fa06	(chrome.dll -content_main_runner.cc:686 )	content::ContentMainRunnerImpl::Run()
0x00007ffadc1bbee1	(chrome.dll -main.cc:469 )	service_manager::Main(service_manager::MainParams const &)
0x00007ffadc19f32b	(chrome.dll -content_main.cc:19 )	content::ContentMain(content::ContentMainParams const &)
0x00007ffadb8cdd51	(chrome.dll -chrome_main.cc:132 )	ChromeMain
0x00007ff66a14761e	(chrome.exe -main_dll_loader_win.cc:199 )	MainDllLoader::Launch(HINSTANCE__ *,base::TimeTicks)
0x00007ff66a142668	(chrome.exe -chrome_exe_main_win.cc:268 )	wWinMain
0x00007ff66a20e982	(chrome.exe -exe_common.inl:253 )	__scrt_common_main_seh
0x00007ffb11de8363	(KERNEL32.DLL + 0x00008363 )	BaseThreadInitThunk
0x00007ffb11f570d0	(ntdll.dll + 0x000670d0 )	RtlUserThreadStart


Used code search for the file "media_router_contextual_menu.cc" from above stack trace and suspecting the below change 

Review-Url: https://codereview.chromium.org/2970273002

takumif@: Could you please check if this is caused with respect to your change, if not please help us in reassign the issue to the right owner. Since this is a recent regression observed on M61 adding RB-Beta, please feel free to edit if this is not the case.

Thanks!

Comment 5 by w...@chromium.org, Jul 24 2017

Labels: -M-62 M-61
Looks like this landed in M61, so correcting labels.
Status: Started (was: Assigned)
Working on a fix. The menu item was never working for incognito/guest-mode afaik, so I'm going to disable it.
https://chromium-review.googlesource.com/c/583408/

Comment 7 by gov...@chromium.org, Jul 24 2017

A friendly reminder that M61 Beta promotion is coming soon! Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix and request a merge to M61 branch 3163 latest by 4:00 PM PT, Thursday (07/27). Thank you.
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/192631d496023f444b4de1fa4191df76ccd599e2

commit 192631d496023f444b4de1fa4191df76ccd599e2
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Tue Jul 25 00:22:26 2017

[Media Router Action] Disable "Report an issue" context menu item for incognito

The menu item for sending feedback was either no-op (guest mode) or showing an
error page (incognito) before the regression that made it crash. This CL
disables the menu item for incognito and guest mode.

Bug:  747792 
Change-Id: I8338015b5305273c95ad022afdc056a55ffb2591
Reviewed-on: https://chromium-review.googlesource.com/583408
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489157}
[modify] https://crrev.com/192631d496023f444b4de1fa4191df76ccd599e2/chrome/browser/media/router/event_page_request_manager_factory.cc
[modify] https://crrev.com/192631d496023f444b4de1fa4191df76ccd599e2/chrome/browser/media/router/event_page_request_manager_factory.h
[modify] https://crrev.com/192631d496023f444b4de1fa4191df76ccd599e2/chrome/browser/ui/toolbar/media_router_contextual_menu.cc
[modify] https://crrev.com/192631d496023f444b4de1fa4191df76ccd599e2/chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc

Cc: ranjitkan@chromium.org
Labels: TE-Verified-M62 TE-Verified-62.0.3166.0
Rechecked this issue on Windows 10, MAC 10.12.5, Ubuntu 14.04 using chrome version 62.0.3166.0 and fix is working as intended. "Report an issue" context menu item for incognito window is not displayed. 

Can this be merged to M61 as M61 is set to be pushed to beta soon and issue is tagged with a Beta blocker label.

Adding TE-Verified labels for M62

Cc: pbomm...@chromium.org
takumif@ can you please request the Cl merge to M61 branch 3163,so that the Cl would be picked for tomorrows Dev release.
Labels: Merge-Request-61
Yup, requesting merge to M61.
It appears that the merge is not applied on build 61.0.3163.13 (Dev candidate). can this be addressed.

Thanks.!
Project Member

Comment 13 by sheriffbot@chromium.org, Jul 26 2017

Labels: -Merge-Request-61 Hotlist-Merge-Approved Merge-Approved-61
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Pls merge you change to M61 branch 3163 by 5:00 PM today, Wednesday if possible so we can take it in for next week M61 last dev release. Thank you.
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 26 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f65d1cd86fd406d330807c5f48161904bd7782d8

commit f65d1cd86fd406d330807c5f48161904bd7782d8
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Wed Jul 26 18:07:39 2017

[Media Router Action] Disable "Report an issue" context menu item for incognito

The menu item for sending feedback was either no-op (guest mode) or showing an
error page (incognito) before the regression that made it crash. This CL
disables the menu item for incognito and guest mode.

TBR=takumif@chromium.org

(cherry picked from commit 192631d496023f444b4de1fa4191df76ccd599e2)

Bug:  747792 
Change-Id: I8338015b5305273c95ad022afdc056a55ffb2591
Reviewed-on: https://chromium-review.googlesource.com/583408
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489157}
Reviewed-on: https://chromium-review.googlesource.com/586077
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#63}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/f65d1cd86fd406d330807c5f48161904bd7782d8/chrome/browser/media/router/event_page_request_manager_factory.cc
[modify] https://crrev.com/f65d1cd86fd406d330807c5f48161904bd7782d8/chrome/browser/media/router/event_page_request_manager_factory.h
[modify] https://crrev.com/f65d1cd86fd406d330807c5f48161904bd7782d8/chrome/browser/ui/toolbar/media_router_contextual_menu.cc
[modify] https://crrev.com/f65d1cd86fd406d330807c5f48161904bd7782d8/chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment