[iOS] The sign-in promo in the bookmarks should displayed as a card |
||||||||
Issue descriptionIn the preview for the sign-in promo in the bookmarks there are 8 pixels margin around the sign-in promo. This has not been implemented: https://drive.google.com/open?id=0B6Wxmj9LZL6XYkNBX1R1a3RBcEU
,
Jul 23 2017
,
Jul 26 2017
,
Aug 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f6be5b9b99134adb69eb654a6c6e2e6ea167d96 commit 4f6be5b9b99134adb69eb654a6c6e2e6ea167d96 Author: Jérôme Lebel <jlebel@chromium.org> Date: Wed Aug 09 09:50:43 2017 Implement the sign-in promo in bookmarks as a card Adding margin for the sign-in promo view and removing separator for the bookmark view. iPhone, before: https://drive.google.com/open?id=0ByXziH_JVCGJaFFQRkNybndCYjg iPhone, after: https://drive.google.com/open?id=0ByXziH_JVCGJMV9Dd08yOW5qTWc iPad, before: https://drive.google.com/open?id=0ByXziH_JVCGJaThBbGhHVy1JdW8 iPad, after: https://drive.google.com/open?id=0ByXziH_JVCGJZG14YUlGSnhwZHM Mock: https://drive.google.com/corp/drive/u/0/folders/0B3pahfDhxF6yTXNSY0JQaVNIb2M Bug: 747744 , 747743 Change-Id: I9204c68813266c4c83823fb80558cb5abaac3b22 Reviewed-on: https://chromium-review.googlesource.com/581492 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#492927} [modify] https://crrev.com/4f6be5b9b99134adb69eb654a6c6e2e6ea167d96/ios/chrome/browser/ui/bookmarks/bookmark_collection_view.mm [modify] https://crrev.com/4f6be5b9b99134adb69eb654a6c6e2e6ea167d96/ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.mm
,
Aug 9 2017
,
Aug 9 2017
,
Aug 9 2017
This bug requires manual review: Less than 23 days to go before AppStore submit on M61 Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 11 2017
please provide rationale as to why this change is required to be merged to the release branch. Why is it important for M61? If we don't merge the patch, what bug will the user see? If we do merge the patch, how risky is it?
,
Aug 11 2017
Verified on iPhone6 iOS 10.3.3 on build 62.0.3180.0 Canary https://drive.google.com/a/google.com/file/d/0B6GVWQnhaMClaEVNLUJSQ05xWUU/view?usp=sharing We still see the old promo in bookmarks screen.
,
Aug 14 2017
Jerome, we don't need to merge this back to 61. We can let this roll out on the waterfall in 62.
,
Aug 16 2017
ok
,
Aug 28 2017
verified the issue in the build 61.0.03163.62 beta tested in iPhone6 and iPad(iOS10) Sign in promo looks good in bookmarks |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by jlebel@chromium.org
, Jul 23 2017