New issue
Advanced search Search tips

Issue 747744 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[iOS] The sign-in promo in the bookmarks should displayed as a card

Project Member Reported by jlebel@chromium.org, Jul 23 2017

Issue description

In the preview for the sign-in promo in the bookmarks there are 8 pixels margin around the sign-in promo. This has not been implemented:
https://drive.google.com/open?id=0B6Wxmj9LZL6XYkNBX1R1a3RBcEU

 

Comment 1 by jlebel@chromium.org, Jul 23 2017

Description: Show this description

Comment 2 by jlebel@chromium.org, Jul 23 2017

Description: Show this description

Comment 3 by jlebel@chromium.org, Jul 26 2017

Description: Show this description
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 9 2017

Status: Fixed (was: Started)
Labels: Merge-Request-61
Project Member

Comment 7 by sheriffbot@chromium.org, Aug 9 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: Less than 23 days to go before AppStore submit on M61
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by cma...@chromium.org, Aug 11 2017

please provide rationale as to why this change is required to be merged to the release branch.  Why is it important for M61?  If we don't merge the patch, what bug will the user see?  If we do merge the patch, how risky is it?

Verified on iPhone6 iOS 10.3.3 on build 62.0.3180.0 Canary
https://drive.google.com/a/google.com/file/d/0B6GVWQnhaMClaEVNLUJSQ05xWUU/view?usp=sharing
We still see the old promo in bookmarks screen.

Comment 10 by ew...@chromium.org, Aug 14 2017

Labels: -Hotlist-Merge-Review -Merge-Review-61
Jerome, we don't need to merge this back to 61. We can let this roll out on the waterfall in 62.
ok
Status: Verified (was: Fixed)
verified the issue in the build 61.0.03163.62 beta tested in iPhone6 and iPad(iOS10)
Sign in promo looks good in bookmarks 

Sign in to add a comment