[iOS] Separator in bookmarks should be removed |
||||||
Issue descriptionFor the implementation of the new sign-in promo in the bookmarks, the separator between the promo and the bookmarks should be removed. https://drive.google.com/open?id=0B6Wxmj9LZL6XYkNBX1R1a3RBcEU
,
Jul 23 2017
,
Jul 26 2017
,
Aug 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f6be5b9b99134adb69eb654a6c6e2e6ea167d96 commit 4f6be5b9b99134adb69eb654a6c6e2e6ea167d96 Author: Jérôme Lebel <jlebel@chromium.org> Date: Wed Aug 09 09:50:43 2017 Implement the sign-in promo in bookmarks as a card Adding margin for the sign-in promo view and removing separator for the bookmark view. iPhone, before: https://drive.google.com/open?id=0ByXziH_JVCGJaFFQRkNybndCYjg iPhone, after: https://drive.google.com/open?id=0ByXziH_JVCGJMV9Dd08yOW5qTWc iPad, before: https://drive.google.com/open?id=0ByXziH_JVCGJaThBbGhHVy1JdW8 iPad, after: https://drive.google.com/open?id=0ByXziH_JVCGJZG14YUlGSnhwZHM Mock: https://drive.google.com/corp/drive/u/0/folders/0B3pahfDhxF6yTXNSY0JQaVNIb2M Bug: 747744 , 747743 Change-Id: I9204c68813266c4c83823fb80558cb5abaac3b22 Reviewed-on: https://chromium-review.googlesource.com/581492 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#492927} [modify] https://crrev.com/4f6be5b9b99134adb69eb654a6c6e2e6ea167d96/ios/chrome/browser/ui/bookmarks/bookmark_collection_view.mm [modify] https://crrev.com/4f6be5b9b99134adb69eb654a6c6e2e6ea167d96/ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.mm
,
Aug 9 2017
,
Aug 15 2017
Tested on 62.0.3186.0 canary, iPhone6 iOS 10.3.3, iPhone7 iOS11, iPad Pro iOS11 Margin for the sign-in promo view are not added and separator for the bookmark view are still shown. https://drive.google.com/a/google.com/file/d/0B6GVWQnhaMClaEVNLUJSQ05xWUU/view
,
Aug 15 2017
Verified on 62.0.3186.0 canary, iPhone6 iOS 10.3.3, iPhone7 iOS11, iPad Pro iOS11 it is not consistent in showing up, I had to reinstall the app number of times for the change to show. Image without bookmarks: https://drive.google.com/a/google.com/file/d/0B6GVWQnhaMClSENIOXdqN0ZlNjA/view Image with bookmarks: https://drive.google.com/a/google.com/file/d/0B6GVWQnhaMClUnI1Z2RkVFNnYjA/view |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jlebel@chromium.org
, Jul 23 2017