New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 747733 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 751773
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: ----



Sign in to add a comment

Drag scrolling sometimes stops working

Project Member Reported by dbloch@google.com, Jul 23 2017

Issue description

Device name: Pixel

Application version: 61.0.3163.0
Operating system:    8.0.0 / OPR1.170623.011

Steps to reproduce:
(1) go to any page, e.g., www.nytimes.com
(2) slide finger vertically

Expected result:
Page scrolls.

Actual result:
Nothing happens.




 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 24 2017

Labels: Hotlist-Google
Cc: ligim...@chromium.org
Labels: Needs-Triage-M61 Needs-Bisect
Thanks for the report.

dbloch@, are you still seeing this issue?  If so, can you provide a bug report or any details that got you into that state?  We haven't been able to repro with the steps.

Comment 4 by aelias@chromium.org, Jul 25 2017

Cc: aelias@chromium.org candr...@chromium.org
Labels: -Pri-3 Pri-1
It would help me to see a video of the repro.  Small details like whether a scrollbar is shown or not might help me understand the root cause.

I also suggest trying flows that create CCT in between switching to Chrome tabs in case that is required to repro.

Comment 5 by dbloch@google.com, Jul 25 2017

I'm no longer seeing it.  Maybe fixed in 61.0.3063.0?

Thanks.
Status: WontFix (was: Unconfirmed)
Thanks for the update.

Closing this issue as per comment #5.

Thanks!!
Cc: -aelias@chromium.org aska...@chromium.org
Labels: -Needs-Triage-M61 ReleaseBlock-Stable M-61
Owner: aelias@chromium.org
Status: Assigned (was: WontFix)
Have seen broken scrolling issue on Canary with these steps:

1.  Have some tabs open.
2.  Swipe away Chrome from Recents.
3.  Re-launch Chrome.
4.  Switch tabs (by swiping between tabs or using tab switcher)
5.  Scroll up/down with finger held down.
6.  Repeat steps 3 and 4 a couple times, if needed

Notes:
- Bug is not consistent with steps above
- Seen it on Pixel/Pixel XL on O and N
- Fling works fine
- Links are clickable on the page
- Video and logcat are at go/chrome-androidlogs1/7/747733
This issue doesn't seem easy to bisect. 
I have been trying for over a day now and I keep getting different results. I have observed that its easier to hit in recent builds (M62) compared to M61 builds. Ex., On 61.0.3149.0, the issue didn't repro at first but it did after trying several times.

The scroll bar is not visible when scroll is disabled. It shows up during fling (which works).
Let me know if I can provide any other info. 
Cc: aelias@chromium.org
Owner: jinsuk...@chromium.org
Jinsuk will try to investigate.  Because only drag-scroll is broken, maybe it's in his area (browser not issuing ScrollUpdate events perhaps?)
Summary: Drag scrolling sometimes stops working (was: scrolling doesn't work on canary)
I think taking a chrome://tracing trace during the nonworking scroll gesture might help a lot to understand the cause.
No luck repro'ing the issue so far. The closest thing I can get is drag-scroll not working on a tab in the newly opened Chrome (after removing it from the Android recents) when it is still showing the snapshot thumbnail. But the scroll starts working fine once the page finishes loading. The problem that fling works while drag-scroll doesn't has never happened to me (yet). I'll keep looking to find more clues / repro it.
Cc: jinsuk...@chromium.org
Owner: sahel@chromium.org
OK I found a step that always reproduces the issue. While a tab is loading a page with its thumbnail snapshot on the screen, "fling" the page (so steps at #7 almost works, except you should fling the page before step 5 to reproduce it). The fling won't work which is kind of expected but this makes drag-scroll stop working even after the page finishes loading, while fling starts working.

Bisect points that the culprit is r479871 for  Issue 730197  which drops scroll event on certain situations. sahel@ would you be able to take care of this, given that you are more familiar with the flow/background?


Cc: sahel@chromium.org tdres...@chromium.org
Labels: -Needs-Bisect
Owner: jinsuk...@chromium.org
Thanks for the bisect!  There's no evidence r479871 fixed a serious bug and the true fix may be hard to find, and it looks like this reverts cleanly.  Jinsuk, could you revert and cherry-pick the revert, so sahel@ can take his time to fix and reland?
Will do. sahel@ I hope you don't mind having it reverted. 
Owner: sahel@chromium.org
The revert patch applies cleanly but unfortunately it breaks several tests:

https://chromium-review.googlesource.com/c/607729

SitePerProcessBrowserTest.ScrollBubblingFromOOPIFTest

org.chromium.content.browser.ContentViewScrollingTest#testOnScrollChanged
org.chromium.content.browser.ContentViewScrollingTest#testScrollTo
org.chromium.content.browser.ContentViewScrollingTest#testJoystickScroll
org.chromium.content.browser.ContentViewScrollingTest#testFling
org.chromium.content.browser.ContentViewScrollingTest#testScrollBy
org.chromium.content.browser.ContentViewScrollingTest#testOverScroll

I'm afraid this still needs further investigation by sahel@. 
The comment 12 produces the bug correctly, but reverting the cl is not necessary, the below cl fixes the bug:
https://chromium-review.googlesource.com/c/601169

The problem is that if a scroll gets ignored and a fling happens after that, then the ignore_scroll flag won't be reset since no GSE happens if a fling starts.
The fix resets the ignore_scroll flag on GSB.

Mergedinto: 751773
Status: Duplicate (was: Assigned)

Sign in to add a comment