New issue
Advanced search Search tips

Issue 747727 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
justincohen@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

iOS should build with linker warnings as errors but apparently doesn't

Project Member Reported by thakis@chromium.org, Jul 23 2017 
 issue 747726  suggests that we don't pass -Werror to the linker on iOS. We should.

It's supposed to be enabled at https://cs.chromium.org/chromium/src/build/config/compiler/BUILD.gn?type=cs&q=werror+file:%5C.gn&sq=package:chromium&l=1208 ; not sure why it isn't.

Maybe justincohen has set treat_warnings_as_errors to false locally? (If so, this is WontFix)

Comment 1 by justincohen@chromium.org, Jul 23 2017 

It is passing -Werror:

 ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Xlinker -rpath -Xlinker @executable_path/Frameworks -Xlinker -rpath -Xlinker @loader_path/Frameworks -Xlinker -rpath -Xlinker @executable_path/Frameworks -Xlinker -objc_abi_version -Xlinker 2 -arch arm64 -Werror -Wl,-dead_strip -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS11.0.sdk -stdlib=libc++ -miphoneos-version-min=9.0 -Wl,-ObjC -F /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/Library/Frameworks -F . -F ../../ios_internal/google_internal/piper/src/google3/googlemac/iPhone/Releases/Cast/v2/v2_10_0/GoogleCastSDK/Release -F . -L. -o <snip> -framework UIKit -framework CoreFoundation -framework CoreGraphics -framework CoreText -framework Foundation -framework XCTest -framework OCHamcrest -framework CFNetwork -framework Security -framework SystemConfiguration -framework AssetsLibrary -framework AudioToolbox -framework AVFoundation -framework CoreMedia -framework GoogleCast -framework MediaAccessibility -framework MediaPlayer -framework QuartzCore -framework EarlGrey -framework WebKit -framework MobileCoreServices -lresolv -framework ImageIO -lsqlite3 -framework Accelerate -framework CoreBluetooth -framework CoreLocation -framework LocalAuthentication -framework CoreSpotlight -framework AdSupport -framework SafariServices -framework MessageUI -framework PassKit -framework Photos -framework StoreKit -lz
ld: warning: ignoring file <snip>/src/third_party/llvm-build/Release+Asserts/lib/clang/6.0.0/lib/darwin/libclang_rt.ios.a, missing required architecture arm64 in file <snip>/src/third_party/llvm-build/Release+Asserts/lib/clang/6.0.0/lib/darwin/libclang_rt.ios.a (5 slices)

Comment 2 by edchin@chromium.org, Jul 24 2017

Owner: justincohen@chromium.org
Status: Assigned (was: Untriaged)
Justin, is this resolved?

Comment 3 by justincohen@chromium.org, Jul 24 2017

Owner: ----
Status: Available (was: Assigned)
No, I have no idea why this linker warning isn't treated as an error.  

We pass -Werror.  Perhaps it's a bug in llvm, or perhaps it's WAI.
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 25

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by sczs@chromium.org, Jul 25

Status: Available (was: Untriaged)
►

Sign in to add a comment