New issue
Advanced search Search tips

Issue 747725 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug

Blocking:
issue 746505



Sign in to add a comment

iOS build broken due to -Wformat warnings

Project Member Reported by thakis@chromium.org, Jul 23 2017

Issue description

the clang tot bot is currently red due to -Wformat warnings. You need either something like https://chromium-review.googlesource.com/c/582074/16/third_party/google_toolbox_for_mac/BUILD.gn for some internal code, or you need to fix these warnings in googlekit.

See also  issue 747643  for the same for GTM; that's already covered by that bug.

Alternatively, we could disable -Wformat for iOS builds globally until this is fixed.

This blocks rolling clang, so it's high priority.

(Even though this is visible on the internal clang/ios tot bot, nobody noticed this for 2 weeks. We really need a clang/ios bot on the public tot bot.)


https://uberchromegw.corp.google.com/i/internal.bling.fyi/builders/clang-tot-device/
 
Cc: stkhapugin@chromium.org
Status: Fixed (was: Untriaged)
Silenced by https://chromereviews.googleplex.com/601847013/, filed b/63982401 for proper fix.
Also https://chromereviews.googleplex.com/601857013#, not the problem only exists on 32bit builds.

Sign in to add a comment