No chrome integration tests for devtools throttling. |
||||
Issue descriptionI broke dev tools throttling in Chrome in https://codereview.chromium.org/2978443002 (Which completely rewrote network stack configuration, in preparation for building out the nascent network service). Not a single test failed, despite the fact that the entire throttling infrastructure was no longer hooked up to the network stack in chrome/. We should have integrations tests for this feature in Chrome, if we care about this feature (And I assume we do). With the creation of the network service, in particular, this seems pretty likely to break again.
,
Jul 24 2017
Over to Will.
,
Jul 27 2017
I've written the test but I can't land it because it's failing w/ PlzNavigate enabled: https://bugs.chromium.org/p/chromium/issues/detail?id=749884
,
Aug 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc578c3afc0ef430f57f6cfbce83eb6c8684e748 commit cc578c3afc0ef430f57f6cfbce83eb6c8684e748 Author: Will Chen <chenwilliam@chromium.org> Date: Tue Aug 08 01:58:37 2017 DevTools: sanity test for network throttling This provides a basic sanity check that DevTools network throttling is wired up properly. Despite already having a browser test EmulateNetworkConditions it didn't catch a real regression from a refactoring CL. Bug: 747724 Change-Id: Id4e177623c677bb017c27378c9ca18602a4af417 Reviewed-on: https://chromium-review.googlesource.com/585845 Commit-Queue: Will Chen <chenwilliam@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#492502} [modify] https://crrev.com/cc578c3afc0ef430f57f6cfbce83eb6c8684e748/chrome/browser/devtools/devtools_sanity_browsertest.cc [modify] https://crrev.com/cc578c3afc0ef430f57f6cfbce83eb6c8684e748/third_party/WebKit/Source/devtools/front_end/Tests.js
,
Sep 21 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by caseq@chromium.org
, Jul 24 2017Components: Platform>DevTools>Mobile
Owner: dgozman@chromium.org
Status: Assigned (was: Untriaged)