Issue metadata
Sign in to add a comment
|
Options UI for extensions are too big when DPI is high
Reported by
xuhaiyan...@gmail.com,
Jul 23 2017
|
||||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36 Steps to reproduce the problem: 1. Find a high DPI Windows device that has DPI scaling enabled. 2. Download the attached extension and load it. 3. Click on the extension icon. 4. See that the extension options UI is a lot wider (and taller) than it should. Screenshot: http://i.imgur.com/4zlvtOp.png My device is Surface Pro 4, which has 200% scaling, notice that the window is 200% as wide (and tall) as it should. What is the expected behavior? The modal to be just enough to contain the content. What went wrong? The modal is too big. Did this work before? No Chrome version: 59.0.3071.115 Channel: stable OS Version: 10.0 Flash Version:
,
Aug 12 2017
Could you please provide update on this? Thanks.
,
Aug 14 2017
This seems much more likely to be bsep's https://chromium.googlesource.com/chromium/src/+/f449a7f4828a5610b1e21b8d2e378555fa59ca7b change I don't have a Windows machine handy at the moment. bsep, can you repro this more easily?
,
Aug 25 2017
I think everything here is working as intended... I can't tell what you expect to happen or what the bisect was looking for. I disabled Use Zoom For DSF just to make sure, and the content is exactly the same size, albeit much blurrier. Your content is 500 CSS pixels wide, which is what was declared. On my 150% scaling machine the box is 750 physical pixels wide, which is... 150% as big. In the screenshot you posted it is 1000 physical pixels wide, which is what I would expect from a 200% machine. The extensions UI is not, and shouldn't be, exempt from scaling. As far as the height goes, you're using a <p> tag, which adds a margin above and below your text, which is why there's extra space there.
,
Aug 25 2017
DPI scaling is using more physical pixels to display the same content, so 500 CSS pixels will use 1000 physical pixels to display (in the case of 200% scaling), and not add 500 white pixels to the left. Surface Pro 4 have 2736 physical pixels across, the 500 CSS pixels options UI is taking well over half the screen to display, it looks like it is taking 2000 physical pixels. Chromium should look the same across all devices right? How is it working as intended when it looks like [ http://i.imgur.com/ce0KVEJ.png ] on my PC but [ http://i.imgur.com/4zlvtOp.png ] on my tablet?
,
Aug 25 2017
Oh! I'm sorry, you are right, that is a bug. I didn't notice it in your screenshot because it had already been fixed and did not reproduce for me. Please look forward to it in M61. Marking as duplicate. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by brajkumar@chromium.org
, Jul 24 2017Components: Platform>Extensions
Labels: -Type-Bug M-62 hasbisect Type-Bug-Regression
Owner: enne@chromium.org
Status: Assigned (was: Unconfirmed)