New issue
Advanced search Search tips

Issue 747697 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 724628



Sign in to add a comment

net-misc/iperf-2.0.5 does not build with libc++

Project Member Reported by manojgupta@chromium.org, Jul 23 2017

Issue description

iperf-2.0.5-r2: x86_64-cros-linux-gnu-clang++ -DHAVE_CONFIG_H -I. -I. -I..  -I../include -I../include  -Wall -O2 -pipe -O2 -pipe -O2 -pipe -march=core2 -fno-exceptions -fno-unwind-tables   -fno-asynchronous-unwind-tables  -clang-syntax  -c -o delay.o delay.cpp

iperf-2.0.5-r2: In file included from delay.cpp:53:
iperf-2.0.5-r2: In file included from ../include/Timestamp.hpp:63:
iperf-2.0.5-r2: In file included from ../include/headers.h:85:
iperf-2.0.5-r2: In file included from /usr/bin/../include/c++/v1/math.h:312:
iperf-2.0.5-r2: /usr/bin/../include/c++/v1/type_traits:694:29: error: redefinition of '__libcpp_is_integral<int>'
iperf-2.0.5-r2: template <>          struct __libcpp_is_integral<int>                : public true_type {};
iperf-2.0.5-r2:                             ^~~~~~~~~~~~~~~~~~~~~~~~~
iperf-2.0.5-r2: /usr/bin/../include/c++/v1/type_traits:683:29: note: previous definition is here
iperf-2.0.5-r2: template <>          struct __libcpp_is_integral<bool>               : public true_type {};
iperf-2.0.5-r2:                             ^
iperf-2.0.5-r2: /usr/bin/../include/c++/v1/type_traits:1894:20: error: redefinition of '__make_signed<int, 1>'
iperf-2.0.5-r2: template <> struct __make_signed<  signed int,       true> {typedef int       type;};
iperf-2.0.5-r2:                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
iperf-2.0.5-r2: /usr/bin/../include/c++/v1/type_traits:1891:20: note: previous definition is here
iperf-2.0.5-r2: template <> struct __make_signed<bool,               true> {};

Interestingly, net-misc/iperf-3.1.3 builds without any issues. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/8355664c39ee36822c44fbd32946a0a67a1d6553

commit 8355664c39ee36822c44fbd32946a0a67a1d6553
Author: Manoj Gupta <manojgupta@google.com>
Date: Thu Jul 27 03:04:01 2017

iperf-2: Update to gentoo stable 2.0.9.

iperf-2.0.9 can be built with clang with libc++.

ebuild changes from upstream:
EAPI: 6 -> 5
KEYWORDS -> *

BUG= chromium:747697 
TEST=emerge-caroline iperf:2 works with and without libc++.

Change-Id: I943489a19713f94acbfac1bb9bbfdd2759acb6d4
Reviewed-on: https://chromium-review.googlesource.com/584203
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Kan Yan <kyan@google.com>
Reviewed-by: Grant Grundler <grundler@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/5e319f4cbcc63c92279fc1e791dc41270b57e6e8/net-misc/iperf/files/iperf-fix-format-security-ftbfs.patch
[delete] https://crrev.com/5e319f4cbcc63c92279fc1e791dc41270b57e6e8/net-misc/iperf/iperf-2.0.5-r2.ebuild
[delete] https://crrev.com/5e319f4cbcc63c92279fc1e791dc41270b57e6e8/net-misc/iperf/files/iperf-bidirectional-tcp-server.patch
[delete] https://crrev.com/5e319f4cbcc63c92279fc1e791dc41270b57e6e8/net-misc/iperf/files/iperf-ipv6_mcast_check.patch
[add] https://crrev.com/8355664c39ee36822c44fbd32946a0a67a1d6553/net-misc/iperf/iperf-2.0.9.ebuild
[delete] https://crrev.com/5e319f4cbcc63c92279fc1e791dc41270b57e6e8/net-misc/iperf/files/iperf-cast-to-max_size_t-instead-of-int.patch
[modify] https://crrev.com/8355664c39ee36822c44fbd32946a0a67a1d6553/net-misc/iperf/Manifest
[delete] https://crrev.com/5e319f4cbcc63c92279fc1e791dc41270b57e6e8/net-misc/iperf/files/iperf-die-on-bind-fail.patch
[delete] https://crrev.com/5e319f4cbcc63c92279fc1e791dc41270b57e6e8/net-misc/iperf/files/iperf-fix-bandwidth-limit.patch

Owner: manojgupta@chromium.org
Status: Verified (was: Untriaged)

Sign in to add a comment