Height of inline-block element with hidden overflow is incorrect in specific hierarchy
Reported by
smusika...@gmail.com,
Jul 22 2017
|
|||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.72 Safari/537.36 Steps to reproduce the problem: See test case attachment. What is the expected behavior? What went wrong? The height of the second <li> should be the same as the first (32px), but it is not. Did this work before? Yes 58 Does this work in other browsers? Yes Chrome version: 60.0.3112.72 Channel: beta OS Version: 10.0 Flash Version: My web application has exhibited this visual regression starting with 59. This may or may not be related to what other users have been complaining about at https://productforums.google.com/forum/#!topic/chrome/IO4USajnHOQ
,
Jul 24 2017
Sorry for the regression! I would take a look of this issue.
,
Jul 28 2017
,
Jul 31 2017
cathiechen: Have you had a chance to look into this?
,
Jul 31 2017
Yes, almost finished. Here is the code review: https://chromium-review.googlesource.com/c/593433
,
Jul 31 2017
Awesome, thank you.
,
Aug 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d80f2f901ba7e631b1779c7acac4d9aebd48fe9b commit d80f2f901ba7e631b1779c7acac4d9aebd48fe9b Author: cathiechen <cathiechen@tencent.com> Date: Tue Aug 01 04:05:09 2017 Fixed line-break while placing ListMarker in front of an overflow:hidden element. In order to display ListMarker, it shouldn't attach to Layout tree as a child of overflow:hidden element, but as a sibling is OK. Bug: 747695 Change-Id: Icaa312310c6fc30aeb78bc7359ca894835db122d Reviewed-on: https://chromium-review.googlesource.com/593433 Commit-Queue: cathie chen <cathiechen@tencent.com> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#490846} [modify] https://crrev.com/d80f2f901ba7e631b1779c7acac4d9aebd48fe9b/third_party/WebKit/LayoutTests/fast/lists/list-marker-before-overflow-hidden-expected.html [modify] https://crrev.com/d80f2f901ba7e631b1779c7acac4d9aebd48fe9b/third_party/WebKit/LayoutTests/fast/lists/list-marker-before-overflow-hidden.html [add] https://crrev.com/d80f2f901ba7e631b1779c7acac4d9aebd48fe9b/third_party/WebKit/LayoutTests/fast/lists/list-marker-inside-overflow-hidden-expected.html [add] https://crrev.com/d80f2f901ba7e631b1779c7acac4d9aebd48fe9b/third_party/WebKit/LayoutTests/fast/lists/list-marker-inside-overflow-hidden.html [modify] https://crrev.com/d80f2f901ba7e631b1779c7acac4d9aebd48fe9b/third_party/WebKit/Source/core/layout/LayoutListItem.cpp
,
Aug 1 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by jmukthavaram@chromium.org
, Jul 24 2017Labels: -Pri-2 hasbisect-per-revision M-59 OS-Linux OS-Mac Pri-1
Owner: e...@chromium.org
Status: Assigned (was: Unconfirmed)