Chromium build fails when compiling code references to NSTouchBar
Reported by
brazen...@gmail.com,
Jul 22 2017
|
||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/603.3.8 (KHTML, like Gecko) Version/10.1.2 Safari/603.3.8 Steps to reproduce the problem: 1. On a fresh install of macOS Sierra (10.12.6), install Xcode 8.3.3 from the App Store. 2. Per build instructions (https://chromium.googlesource.com/chromium/src/+/master/docs/mac_build_instructions.md), install depot_tools, then fetch chromium 4. In src directory, run `gn args out/{outdir}` and set these args: is_debug = false, is_component_build = false, symbol_level = 0, dcheck_always_on = false, enable_nacl = false, remove_webcore_debug_symbols = true, use_goma = false 5. Run `ninja -C out/{outdir} chrome` What is the expected behavior? The build should complete without errors. What went wrong? The following errors were thrown, followed by an exit of the build process. Retries of the build command (step 5) failed during reattempt to compile the referenced files. Did this work before? N/A Chrome version: Channel: stable OS Version: OS X 10.12.6 Flash Version: The attached file contains the console output.
,
Jul 24 2017
As this issue related to chromium builds,adding 'TE-NeedsTriageHelp' label for further investigation from dev. Thanks in advance..!!
,
Jul 24 2017
,
Jul 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a10b0cc3a3c52b16ea8734aab307ebee28c3496 commit 1a10b0cc3a3c52b16ea8734aab307ebee28c3496 Author: spqchan <spqchan@chromium.org> Date: Wed Jul 26 17:24:33 2017 Add missing availability annotations for macOS 10.12. https://chromium-review.googlesource.com/c/572149/ was landed without any availability annotations. This causes "-Wunguarded-availability" warnings to be triggered when compiling against the 10.12 SDK. Bug: 747693 Change-Id: I08a6bc1937bebf17f1d05f6185cb6233472b36a3 Reviewed-on: https://chromium-review.googlesource.com/583850 Reviewed-by: Erik Chen <erikchen@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#489679} [modify] https://crrev.com/1a10b0cc3a3c52b16ea8734aab307ebee28c3496/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.h [modify] https://crrev.com/1a10b0cc3a3c52b16ea8734aab307ebee28c3496/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm [modify] https://crrev.com/1a10b0cc3a3c52b16ea8734aab307ebee28c3496/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa_unittest.mm [modify] https://crrev.com/1a10b0cc3a3c52b16ea8734aab307ebee28c3496/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm [modify] https://crrev.com/1a10b0cc3a3c52b16ea8734aab307ebee28c3496/chrome/browser/ui/cocoa/web_textfield_touch_bar_controller.h
,
Jul 26 2017
I noticed the same behaviour when trying to build on macOS 10.12.6. I managed to build Chromium to the end by changing four lines in the code to include API_AVAILABLE checks. You can test out if it works for you with the attached patch.
,
Jul 26 2017
#5 arttuplerala@, thanks for the heads up. I already landed a patch with the API_AVAILABLE checks :) Please let me know if this are still any issues
,
Jul 27 2017
,
Jul 28 2017
,
Jul 28 2017
Can this be merged to M61?
,
Jul 29 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 30 2017
Pls merge you change to M61 branch 3163 before 3:00 PM PT on Monday so we can take it in for next week last M61 Dev release. Thank you.
,
Jul 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/975e3ad6c66f9a4bd0980362ccc57955bbaf83ef commit 975e3ad6c66f9a4bd0980362ccc57955bbaf83ef Author: spqchan <spqchan@chromium.org> Date: Mon Jul 31 17:22:11 2017 Add missing availability annotations for macOS 10.12. https://chromium-review.googlesource.com/c/572149/ was landed without any availability annotations. This causes "-Wunguarded-availability" warnings to be triggered when compiling against the 10.12 SDK. Bug: 747693 Change-Id: I08a6bc1937bebf17f1d05f6185cb6233472b36a3 Reviewed-on: https://chromium-review.googlesource.com/583850 Reviewed-by: Erik Chen <erikchen@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#489679} (cherry picked from commit 1a10b0cc3a3c52b16ea8734aab307ebee28c3496) Whitelisting logic should not check non-ws non-http urls Safebrowsing only works on certain schemes. Further the whitelisting logic has certain assumptions about the URLs that are checked for whitelisting. Early out if the url does not have the right scheme. BUG= 750280 TBR=sgurun@google.com (cherry picked from commit 6146a7c8cdf03d79a6a0df09c7341a65602c55cf) Reviewed-on: https://chromium-review.googlesource.com/592227 Commit-Queue: Selim Gurun <sgurun@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#490589} Reviewed-on: https://chromium-review.googlesource.com/594327 Reviewed-by: Selim Gurun <sgurun@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/3163@{#157} Cr-Original-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} Change-Id: I6507e8e0197ed3c1a3dd0eb10e7379cf5ceb459b Reviewed-on: https://chromium-review.googlesource.com/594469 Reviewed-by: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#159} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/975e3ad6c66f9a4bd0980362ccc57955bbaf83ef/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.h [modify] https://crrev.com/975e3ad6c66f9a4bd0980362ccc57955bbaf83ef/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm [modify] https://crrev.com/975e3ad6c66f9a4bd0980362ccc57955bbaf83ef/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa_unittest.mm [modify] https://crrev.com/975e3ad6c66f9a4bd0980362ccc57955bbaf83ef/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm [modify] https://crrev.com/975e3ad6c66f9a4bd0980362ccc57955bbaf83ef/chrome/browser/ui/cocoa/web_textfield_touch_bar_controller.h
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46ad97266bb8921b888babb045e48ac347d8653d commit 46ad97266bb8921b888babb045e48ac347d8653d Author: spqchan <spqchan@chromium.org> Date: Fri Aug 04 19:09:43 2017 Fix an Availability Annotation Change an availability check to an availability annotation. Bug: 747693 Change-Id: I77b5e0c4d71b9771dc076b9802f0fb81a84c0c26 Reviewed-on: https://chromium-review.googlesource.com/597347 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#492093} [modify] https://crrev.com/46ad97266bb8921b888babb045e48ac347d8653d/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by meh...@chromium.org
, Jul 23 2017Components: UI>Browser>Touchbar