New issue
Advanced search Search tips

Issue 747676 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android
Pri: 3
Type: Bug

Blocked on:
issue 840822
issue 747675
issue 767901



Sign in to add a comment

Consider building libc++ with _LIBCPP_ABI_UNSTABLE

Project Member Reported by thakis@chromium.org, Jul 22 2017

Issue description

On Linux and Android, we don't care about libc++ ABI stability. If we define _LIBCPP_ABI_UNSTABLE we get a bunch of presumably beneficial changes that break ABI (https://github.com/llvm-mirror/libcxx/blob/master/include/__config#L52).

We might want to turn that on.

We might want to wait until we use the same libc++ on Android on Linux ( issue 747675 ) before doing that, to keep the config matrix a bit smaller.

 
Blockedon: 767901
Owner: thomasanderson@chromium.org
Status: Assigned (was: Untriaged)
Blockedon: 840822
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f0b0a857e911b152d694c20852b2424ce7868da

commit 0f0b0a857e911b152d694c20852b2424ce7868da
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Thu Dec 20 02:24:57 2018

Build with _LIBCPP_ABI_UNSTABLE

BUG= 747676 
R=thakis

Change-Id: Ib3e8d058b380764ee55de77b5993b3ecbf7137e9
Reviewed-on: https://chromium-review.googlesource.com/c/1379066
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618079}
[modify] https://crrev.com/0f0b0a857e911b152d694c20852b2424ce7868da/build/config/posix/BUILD.gn
[modify] https://crrev.com/0f0b0a857e911b152d694c20852b2424ce7868da/build/config/win/BUILD.gn

Status: Fixed (was: Assigned)

Sign in to add a comment