crash on wake-up when connected to a tether network |
|||||||
Issue descriptionChromium 62.0.3164.0 (Official Build) (64-bit) Revision 08b90b79808b8a223d6e9fb76c0c05c7a3b0c077-refs/heads/master@{#488823} Platform 9734.0.0 (Official Build) dev-channel caroline test Firmware Version Google_Caroline.7820.263.0 Customization ID SAMSUNG-CAROLINE What steps will reproduce the problem? (1) connect to an instant tether network (2) close the lid of the chromebook (3) open it 5 - 10 seconds later What is the expected result? resumes where i left off What happens instead? chrome crashes :( was a little tricky but i was able to get it to happen with GDB attached by unplugging the ethernet dongle right before closing the lid and plugging it back in after opening. warning: Could not find DWO CU obj/chromeos/chromeos/network_state_handler.dwo(0x698a202676d646e) referenced by CU at offset 0x6d36b [in module /opt/google/chrome/chrome] warning: (Internal error: pc 0x5a197aa59b00 in read in psymtab, but not in symtab.) warning: (Internal error: pc 0x5a197aa59b00 in read in psymtab, but not in symtab.) warning: (Internal error: pc 0x5a197aa59a40 in read in psymtab, but not in symtab.) warning: (Internal error: pc 0x5a197aa59b00 in read in psymtab, but not in symtab.) warning: (Internal error: pc 0x5a197aa59b00 in read in psymtab, but not in symtab.) Thread 1 "chrome" received signal SIGSEGV, Segmentation fault. warning: (Internal error: pc 0x5a197aa59b00 in read in psymtab, but not in symtab.) warning: (Internal error: pc 0x5a197aa59b00 in read in psymtab, but not in symtab.) warning: (Internal error: pc 0x5a197aa59b00 in read in psymtab, but not in symtab.) warning: (Internal error: pc 0x5a197aa59b00 in read in psymtab, but not in symtab.) chromeos::NetworkStateHandler::SetTetherScanState(bool) () at ../../chromeos/network/device_state.h:37 37 ../../chromeos/network/device_state.h: No such file or directory. warning: (Internal error: pc 0x5a197aa59b00 in read in psymtab, but not in symtab.) warning: (Internal error: pc 0x5a197aa59b00 in read in psymtab, but not in symtab.)
,
Jul 25 2017
,
Jul 26 2017
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3919113ac18dab0feae2bdae522395faf316894 commit e3919113ac18dab0feae2bdae522395faf316894 Author: Kyle Horimoto <khorimoto@google.com> Date: Thu Jul 27 22:44:55 2017 [CrOS Tether] Shut down Tether before disabling in NetworkStateHandler. Previously, we would disable Tether networks in NetworkStateHandler before shutting down the Tether component, leaving open the possibility that after Tether networks were disabled but before the component was shut down, Tether code could interact with NetworkStateHandler. This race condition caused occasional browser crashes. This CL also: (1) Changes some TetherService function names to be more appropriate. (2) Changes a DCHECK() in NetworkStateHandler to an error log and an early return to prevent the possibility of a browser crash when it was not necessary to do so. Bug: 747644 , 672263 Change-Id: I8687ffa141efd9fe0eac0875fb58f4556dd24452 Reviewed-on: https://chromium-review.googlesource.com/585400 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#490029} [modify] https://crrev.com/e3919113ac18dab0feae2bdae522395faf316894/chrome/browser/chromeos/login/session/chrome_session_manager.cc [modify] https://crrev.com/e3919113ac18dab0feae2bdae522395faf316894/chrome/browser/chromeos/login/session/user_session_manager.cc [modify] https://crrev.com/e3919113ac18dab0feae2bdae522395faf316894/chrome/browser/chromeos/tether/fake_tether_service.cc [modify] https://crrev.com/e3919113ac18dab0feae2bdae522395faf316894/chrome/browser/chromeos/tether/fake_tether_service.h [modify] https://crrev.com/e3919113ac18dab0feae2bdae522395faf316894/chrome/browser/chromeos/tether/tether_service.cc [modify] https://crrev.com/e3919113ac18dab0feae2bdae522395faf316894/chrome/browser/chromeos/tether/tether_service.h [modify] https://crrev.com/e3919113ac18dab0feae2bdae522395faf316894/chromeos/network/network_state_handler.cc
,
Jul 27 2017
,
Jul 28 2017
Approving merge to M61 Chrome OS.
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5eeae84502befc21112dc94f916ff6ca2c69a617 commit 5eeae84502befc21112dc94f916ff6ca2c69a617 Author: Kyle Horimoto <khorimoto@google.com> Date: Fri Jul 28 17:19:13 2017 [CrOS Tether] Shut down Tether before disabling in NetworkStateHandler. Previously, we would disable Tether networks in NetworkStateHandler before shutting down the Tether component, leaving open the possibility that after Tether networks were disabled but before the component was shut down, Tether code could interact with NetworkStateHandler. This race condition caused occasional browser crashes. This CL also: (1) Changes some TetherService function names to be more appropriate. (2) Changes a DCHECK() in NetworkStateHandler to an error log and an early return to prevent the possibility of a browser crash when it was not necessary to do so. TBR=khorimoto@google.com (cherry picked from commit e3919113ac18dab0feae2bdae522395faf316894) Bug: 747644 , 672263 Change-Id: I8687ffa141efd9fe0eac0875fb58f4556dd24452 Reviewed-on: https://chromium-review.googlesource.com/585400 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#490029} Reviewed-on: https://chromium-review.googlesource.com/592129 Cr-Commit-Position: refs/branch-heads/3163@{#100} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/5eeae84502befc21112dc94f916ff6ca2c69a617/chrome/browser/chromeos/login/session/chrome_session_manager.cc [modify] https://crrev.com/5eeae84502befc21112dc94f916ff6ca2c69a617/chrome/browser/chromeos/login/session/user_session_manager.cc [modify] https://crrev.com/5eeae84502befc21112dc94f916ff6ca2c69a617/chrome/browser/chromeos/tether/fake_tether_service.cc [modify] https://crrev.com/5eeae84502befc21112dc94f916ff6ca2c69a617/chrome/browser/chromeos/tether/fake_tether_service.h [modify] https://crrev.com/5eeae84502befc21112dc94f916ff6ca2c69a617/chrome/browser/chromeos/tether/tether_service.cc [modify] https://crrev.com/5eeae84502befc21112dc94f916ff6ca2c69a617/chrome/browser/chromeos/tether/tether_service.h [modify] https://crrev.com/5eeae84502befc21112dc94f916ff6ca2c69a617/chromeos/network/network_state_handler.cc
,
Jul 28 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by khorimoto@chromium.org
, Jul 22 2017Components: UI>Shell>Networking>Tethering
Labels: -Restrict-View-Google -Hotlist-Google M-61
Status: Assigned (was: Untriaged)