New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 747635 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Task

Blocking:
issue 724708



Sign in to add a comment

EasyUnlock v2: Refactor ProximityAuthPrefManager to have profile and local state based implementations

Project Member Reported by tengs@chromium.org, Jul 22 2017

Issue description

At the moment, code to sync (and fetch) EasyUnlock prefs to local state is implemented an ad-hoc manner. We should instead gather all the prefs in one place.
 

Comment 1 by tengs@chromium.org, Jul 22 2017

Blocking: -747601 724708
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f31990b520b86a7f7e26b25fc7946ff6013db0c

commit 3f31990b520b86a7f7e26b25fc7946ff6013db0c
Author: Tim Song <tengs@chromium.org>
Date: Tue Jul 25 03:12:25 2017

[EasyUnlock] Refactor ProximityAuthPrefManager to an interface.

This CL splits ProximityAuthPrefManager into an interface and an user profile
based implementation. In a future CL, we will add an implementation based on the
local state before the user logs in.

BUG= 747635 

Change-Id: Ife070f97db0eb39882f626e7c4cb64172aa2ac5c
Reviewed-on: https://chromium-review.googlesource.com/582217
Commit-Queue: Tim Song <tengs@chromium.org>
Reviewed-by: Gustavo Sacomoto <sacomoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489206}
[modify] https://crrev.com/3f31990b520b86a7f7e26b25fc7946ff6013db0c/chrome/browser/signin/easy_unlock_service.cc
[modify] https://crrev.com/3f31990b520b86a7f7e26b25fc7946ff6013db0c/chrome/browser/signin/easy_unlock_service_regular.cc
[modify] https://crrev.com/3f31990b520b86a7f7e26b25fc7946ff6013db0c/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc
[modify] https://crrev.com/3f31990b520b86a7f7e26b25fc7946ff6013db0c/components/proximity_auth/BUILD.gn
[modify] https://crrev.com/3f31990b520b86a7f7e26b25fc7946ff6013db0c/components/proximity_auth/promotion_manager_unittests.cc
[modify] https://crrev.com/3f31990b520b86a7f7e26b25fc7946ff6013db0c/components/proximity_auth/proximity_auth_pref_manager.h
[rename] https://crrev.com/3f31990b520b86a7f7e26b25fc7946ff6013db0c/components/proximity_auth/proximity_auth_profile_pref_manager.cc
[add] https://crrev.com/3f31990b520b86a7f7e26b25fc7946ff6013db0c/components/proximity_auth/proximity_auth_profile_pref_manager.h
[rename] https://crrev.com/3f31990b520b86a7f7e26b25fc7946ff6013db0c/components/proximity_auth/proximity_auth_profile_pref_manager_unittest.cc
[modify] https://crrev.com/3f31990b520b86a7f7e26b25fc7946ff6013db0c/components/proximity_auth/proximity_auth_system.cc
[modify] https://crrev.com/3f31990b520b86a7f7e26b25fc7946ff6013db0c/components/proximity_auth/proximity_auth_system_unittest.cc
[modify] https://crrev.com/3f31990b520b86a7f7e26b25fc7946ff6013db0c/components/proximity_auth/proximity_monitor_impl_unittest.cc

Comment 3 by tengs@chromium.org, Jul 25 2017

Cc: sacomoto@chromium.org omrilio@chromium.org
Labels: -Pri-2 Merge-Request-61 Pri-1
Please add appropriate OSs.

Comment 5 by tengs@chromium.org, Jul 25 2017

Labels: OS-Chrome
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 26 2017

Labels: -Merge-Request-61 Hotlist-Merge-Approved Merge-Approved-61
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by sheriffbot@chromium.org, Jul 31 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by sheriffbot@chromium.org, Aug 4 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 7 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63516ef4b688e4a5fc007ba98acad24a88acb864

commit 63516ef4b688e4a5fc007ba98acad24a88acb864
Author: Tim Song <tengs@chromium.org>
Date: Mon Aug 07 17:11:23 2017

[EasyUnlock] Refactor ProximityAuthPrefManager to an interface.

This CL splits ProximityAuthPrefManager into an interface and an user profile
based implementation. In a future CL, we will add an implementation based on the
local state before the user logs in.

BUG= 747635 
TBR=tengs@chromium.org

(cherry picked from commit 3f31990b520b86a7f7e26b25fc7946ff6013db0c)

Change-Id: Ife070f97db0eb39882f626e7c4cb64172aa2ac5c
Reviewed-on: https://chromium-review.googlesource.com/582217
Commit-Queue: Tim Song <tengs@chromium.org>
Reviewed-by: Gustavo Sacomoto <sacomoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489206}
Reviewed-on: https://chromium-review.googlesource.com/604091
Reviewed-by: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#350}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/63516ef4b688e4a5fc007ba98acad24a88acb864/chrome/browser/signin/easy_unlock_service.cc
[modify] https://crrev.com/63516ef4b688e4a5fc007ba98acad24a88acb864/chrome/browser/signin/easy_unlock_service_regular.cc
[modify] https://crrev.com/63516ef4b688e4a5fc007ba98acad24a88acb864/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc
[modify] https://crrev.com/63516ef4b688e4a5fc007ba98acad24a88acb864/components/proximity_auth/BUILD.gn
[modify] https://crrev.com/63516ef4b688e4a5fc007ba98acad24a88acb864/components/proximity_auth/promotion_manager_unittests.cc
[modify] https://crrev.com/63516ef4b688e4a5fc007ba98acad24a88acb864/components/proximity_auth/proximity_auth_pref_manager.h
[rename] https://crrev.com/63516ef4b688e4a5fc007ba98acad24a88acb864/components/proximity_auth/proximity_auth_profile_pref_manager.cc
[add] https://crrev.com/63516ef4b688e4a5fc007ba98acad24a88acb864/components/proximity_auth/proximity_auth_profile_pref_manager.h
[rename] https://crrev.com/63516ef4b688e4a5fc007ba98acad24a88acb864/components/proximity_auth/proximity_auth_profile_pref_manager_unittest.cc
[modify] https://crrev.com/63516ef4b688e4a5fc007ba98acad24a88acb864/components/proximity_auth/proximity_auth_system.cc
[modify] https://crrev.com/63516ef4b688e4a5fc007ba98acad24a88acb864/components/proximity_auth/proximity_auth_system_unittest.cc
[modify] https://crrev.com/63516ef4b688e4a5fc007ba98acad24a88acb864/components/proximity_auth/proximity_monitor_impl_unittest.cc

Status: Fixed (was: Assigned)

Comment 11 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment