New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 747633 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Restore opacity when transient elements are shown again.

Project Member Reported by vollick@chromium.org, Jul 22 2017

Issue description

We set opacity to 0.0 when hiding elements in the transience manager which makes it tricky to see them when they come back.

 
Labels: Merge-Request-61
Fix is here https://chromium-review.googlesource.com/c/582069/
Cc: amineer@chromium.org
Hey Alex, I was hoping to get your advice on this. I've got a fix (which I didn't associate with this bug) listed above, but I was wondering if you'd prefer we merge back a revert of the CL that introduced the issue (https://chromium-review.googlesource.com/c/579870/). 

Both are small, and the fix has been reverted for the time being so we could quiclk go either way.
Labels: -Merge-Request-61
Am relanding fix, but removed the merge request while that's in progress.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2485c414664902ebdc0b297b65ef52e0a6cc080

commit c2485c414664902ebdc0b297b65ef52e0a6cc080
Author: Ian Vollick <vollick@chromium.org>
Date: Sat Jul 22 01:37:03 2017

Reland "[vr] Restore opacity when transient elements are shown again."

This is a reland of c140538983d4575003bb31ee4f522da635e1a3c9
Original change's description:
> [vr] Restore opacity when transient elements are shown again.
> 
> We'd previously set opacity to 0.0 when hiding elements in the
> transience manager which makes it tricky to see them when they come
> back. With this change, we inform the manager of the desired "opacity
> when visible" and it will restore elements to that opacity when
> shown again.
> 
> Bug: None
> Change-Id: I1a941c3032c35adab5afed17a8afc60bd41230f5
> Reviewed-on: https://chromium-review.googlesource.com/582069
> Commit-Queue: Ian Vollick <vollick@chromium.org>
> Reviewed-by: Christopher Grant <cjgrant@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#488788}

TBR=cjgrant@chromium.org

Bug:  747633 
Change-Id: I340ed94f61f016243dc4495d687cab1d58ea2e67
Reviewed-on: https://chromium-review.googlesource.com/582529
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488833}
[modify] https://crrev.com/c2485c414664902ebdc0b297b65ef52e0a6cc080/chrome/browser/vr/elements/simple_textured_element.h
[modify] https://crrev.com/c2485c414664902ebdc0b297b65ef52e0a6cc080/chrome/browser/vr/elements/transience_manager.cc
[modify] https://crrev.com/c2485c414664902ebdc0b297b65ef52e0a6cc080/chrome/browser/vr/elements/transience_manager.h
[modify] https://crrev.com/c2485c414664902ebdc0b297b65ef52e0a6cc080/chrome/browser/vr/elements/transience_manager_unittest.cc
[modify] https://crrev.com/c2485c414664902ebdc0b297b65ef52e0a6cc080/chrome/browser/vr/elements/transient_url_bar.cc

Labels: Merge-Request-61
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 23 2017

Labels: -Merge-Request-61 Hotlist-Merge-Approved Merge-Approved-61
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 24 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5169107588c83be8adfb044e11bd0767a54a46b1

commit 5169107588c83be8adfb044e11bd0767a54a46b1
Author: Ian Vollick <vollick@chromium.org>
Date: Mon Jul 24 13:52:21 2017

Reland "[vr] Restore opacity when transient elements are shown again."

This is a reland of c140538983d4575003bb31ee4f522da635e1a3c9
Original change's description:
> [vr] Restore opacity when transient elements are shown again.
>
> We'd previously set opacity to 0.0 when hiding elements in the
> transience manager which makes it tricky to see them when they come
> back. With this change, we inform the manager of the desired "opacity
> when visible" and it will restore elements to that opacity when
> shown again.
>
> Bug: None
> Change-Id: I1a941c3032c35adab5afed17a8afc60bd41230f5
> Reviewed-on: https://chromium-review.googlesource.com/582069
> Commit-Queue: Ian Vollick <vollick@chromium.org>
> Reviewed-by: Christopher Grant <cjgrant@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#488788}

TBR=cjgrant@chromium.org, vollick@chromium.org

(cherry picked from commit c2485c414664902ebdc0b297b65ef52e0a6cc080)

Bug:  747633 
Change-Id: I340ed94f61f016243dc4495d687cab1d58ea2e67
Reviewed-on: https://chromium-review.googlesource.com/582529
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#488833}
Reviewed-on: https://chromium-review.googlesource.com/582967
Cr-Commit-Position: refs/branch-heads/3163@{#9}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/5169107588c83be8adfb044e11bd0767a54a46b1/chrome/browser/vr/elements/simple_textured_element.h
[modify] https://crrev.com/5169107588c83be8adfb044e11bd0767a54a46b1/chrome/browser/vr/elements/transience_manager.cc
[modify] https://crrev.com/5169107588c83be8adfb044e11bd0767a54a46b1/chrome/browser/vr/elements/transience_manager.h
[modify] https://crrev.com/5169107588c83be8adfb044e11bd0767a54a46b1/chrome/browser/vr/elements/transience_manager_unittest.cc
[modify] https://crrev.com/5169107588c83be8adfb044e11bd0767a54a46b1/chrome/browser/vr/elements/transient_url_bar.cc

Status: Fixed (was: Assigned)
Labels: M-61

Sign in to add a comment