Bug: Media Remoting UI still show when player is destroyed while remoting. |
||
Issue descriptionWhen a WebMediaPlayer is destroyed during remoting due to the stream ending, if the HTMLMediaElement is not destroyed, the media remoting status should changed to indicate remoting was ended and the remoting UI should be hidden.
,
Jul 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8ccb20171a04e37331e651d1a209449bcb9e4a7 commit b8ccb20171a04e37331e651d1a209449bcb9e4a7 Author: Xiangjun Zhang <xjz@chromium.org> Date: Mon Jul 24 21:44:21 2017 Bug Fix: Notify media element remoting ended when player is destroyed. When WebMediaPlayer is destroyed while remoting, it should notify the HTMLMediaElement that remoting was ended and the remoting UI should be hidden. Bug: 747632 Change-Id: Ie1e8189403e496c187a55c860f3e54b6bd1d9ab7 Reviewed-on: https://chromium-review.googlesource.com/581950 Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#489084} [modify] https://crrev.com/b8ccb20171a04e37331e651d1a209449bcb9e4a7/media/remoting/renderer_controller.cc [modify] https://crrev.com/b8ccb20171a04e37331e651d1a209449bcb9e4a7/media/remoting/renderer_controller_unittest.cc
,
Jul 24 2017
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87299140b105e06f3f8b10fc71867d45116b44e3 commit 87299140b105e06f3f8b10fc71867d45116b44e3 Author: Xiangjun Zhang <xjz@chromium.org> Date: Wed Sep 13 20:35:03 2017 Hide Media Remoting UI when media player is cleared. When WebMediaPlayer is destroyed while remoting, the remoting UI should be hidden. Previous approach (https://chromium-review.googlesource.com/c/581950) added the notification in RendererController's destructor, which requires proper destruct order in WebMediaPlayerImpl, and potentially cause crash. This CL reverted previous change and instead hide the remoting UI directly in media element when media player is cleared. Bug: 747632 ,761699 Change-Id: I10452f93785a8e5814b4cffe466846d55962fa1e Reviewed-on: https://chromium-review.googlesource.com/600950 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#501741} [modify] https://crrev.com/87299140b105e06f3f8b10fc71867d45116b44e3/media/blink/webmediaplayer_impl.cc [modify] https://crrev.com/87299140b105e06f3f8b10fc71867d45116b44e3/media/remoting/renderer_controller.cc [modify] https://crrev.com/87299140b105e06f3f8b10fc71867d45116b44e3/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp [modify] https://crrev.com/87299140b105e06f3f8b10fc71867d45116b44e3/third_party/WebKit/Source/core/html/HTMLVideoElement.h [modify] https://crrev.com/87299140b105e06f3f8b10fc71867d45116b44e3/third_party/WebKit/Source/core/html/media/MediaRemotingInterstitial.cpp [modify] https://crrev.com/87299140b105e06f3f8b10fc71867d45116b44e3/third_party/WebKit/Source/core/html/media/MediaRemotingInterstitial.h [modify] https://crrev.com/87299140b105e06f3f8b10fc71867d45116b44e3/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp |
||
►
Sign in to add a comment |
||
Comment 1 by orgu...@gmail.com
, Jul 22 2017