New issue
Advanced search Search tips

Issue 747631 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

PageStateSerializationTest backwards compat dat files have wrong versions encoded

Project Member Reported by dcheng@chromium.org, Jul 22 2017

Issue description

serialized_v23.dat has version 24 encoded in the header:
00000000: c2b4 0300 0018 0000 0001 0000 0010 0000 

serialized_v22.dat has version 23 encoded in the header:
00000000: c2ac 0300 0017 0000 0001 0000 0010 0000

serialized_v21.dat has version 21 encoded in the header:
00000000: c2b4 0300 0015 0000 0001 0000 0010 0000

serialized_v20.dat has version 20 encoded in the header:
00000000: c2a4 0300 0014 0000 0001 0000 0010 0000 

My understanding is that the serialized version should match the version in the filename, so we'll need to fix version 23 and version 22's dat. We should also update the test to assert that the versions are correct (which will require poking a small hole in page_state_serialization.h for testing).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57ca87857c9c5b70f32a0638fa867c28c4331fb7

commit 57ca87857c9c5b70f32a0638fa867c28c4331fb7
Author: Daniel Cheng <dcheng@chromium.org>
Date: Wed Aug 16 19:07:27 2017

Fix backwards compatibility page state tests to use the right version.

These tests are supposed to test backwards compatibility *from* the
specified version to the current version. However, since the test never
actually verified the version numnber of the decoded page state, it was
very easy to accidentally generate the wrong page state version.

Bug: 747631
Change-Id: I09fad27d42ef4e52eaf70e6f2a9a2efd53817c1a
Reviewed-on: https://chromium-review.googlesource.com/615223
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Charlie Reis (OOO Aug 17-24) <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494890}
[modify] https://crrev.com/57ca87857c9c5b70f32a0638fa867c28c4331fb7/content/common/page_state_serialization.cc
[modify] https://crrev.com/57ca87857c9c5b70f32a0638fa867c28c4331fb7/content/common/page_state_serialization.h
[modify] https://crrev.com/57ca87857c9c5b70f32a0638fa867c28c4331fb7/content/common/page_state_serialization_unittest.cc
[modify] https://crrev.com/57ca87857c9c5b70f32a0638fa867c28c4331fb7/content/test/data/page_state/serialized_v16.dat
[modify] https://crrev.com/57ca87857c9c5b70f32a0638fa867c28c4331fb7/content/test/data/page_state/serialized_v18.dat
[modify] https://crrev.com/57ca87857c9c5b70f32a0638fa867c28c4331fb7/content/test/data/page_state/serialized_v22.dat
[modify] https://crrev.com/57ca87857c9c5b70f32a0638fa867c28c4331fb7/content/test/data/page_state/serialized_v23.dat

Sign in to add a comment