[Autofill] When matching types for upload, card numbers should be compared to last four for server cards |
||
Issue descriptionIf you have a server card Visa **** 1111 and end up submitting 4111....1111, the logic to determine the types for upload will not match against the card number because it is masked. In this case (when comparing against server cards), the logic should match against the last four digits (1111 == 1111).
,
Jul 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d39707c9e91d3357c33d70168c9e6760d906f5ad commit d39707c9e91d3357c33d70168c9e6760d906f5ad Author: Mathieu Perreault <mathp@chromium.org> Date: Mon Jul 24 16:02:22 2017 [Autofill] Compare with last four for masked card when determining type Previously, we would compare the user input with the full card number in order to determine the final type. For masked card, the full card number is not known. In this case, we compare the user's last four characters against the masked card's last four digits to determine a match. Bug: 747630 Test: components_unittests Change-Id: I2be44ba18a9c5f89e08d1d590d57267293f7bce4 Reviewed-on: https://chromium-review.googlesource.com/582345 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#488983} [modify] https://crrev.com/d39707c9e91d3357c33d70168c9e6760d906f5ad/components/autofill/core/browser/autofill_metrics_unittest.cc [modify] https://crrev.com/d39707c9e91d3357c33d70168c9e6760d906f5ad/components/autofill/core/browser/credit_card.cc [modify] https://crrev.com/d39707c9e91d3357c33d70168c9e6760d906f5ad/components/autofill/core/browser/credit_card_unittest.cc
,
Jul 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9591bc52000d1e510736db72de6f60f85427042e commit 9591bc52000d1e510736db72de6f60f85427042e Author: Mathieu Perreault <mathp@chromium.org> Date: Mon Jul 24 19:57:08 2017 [Reland] Compare with last four for masked card when determining type Previously, we would compare the user input with the full card number in order to determine the final type. For masked card, the full card number is not known. In this case, we compare the user's last four characters against the masked card's last four digits to determine a match. Bug: 747630 Test: components_unittests Change-Id: I292ec2bb98dd4248865d66f2c82ecbc3949fd2ca Reviewed-on: https://chromium-review.googlesource.com/582345 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#488983} Reviewed-on: https://chromium-review.googlesource.com/583728 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#489054} [modify] https://crrev.com/9591bc52000d1e510736db72de6f60f85427042e/components/autofill/core/browser/autofill_metrics_unittest.cc [modify] https://crrev.com/9591bc52000d1e510736db72de6f60f85427042e/components/autofill/core/browser/credit_card.cc [modify] https://crrev.com/9591bc52000d1e510736db72de6f60f85427042e/components/autofill/core/browser/credit_card_unittest.cc
,
Aug 1 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by ma...@chromium.org
, Jul 22 2017