Issue 747629 link

Starred by 1 user

Issue metadata

Status:	Verified
Owner:	█ sha...@chromium.org Last visit > 30 days ago
Closed:	Sep 2017
Cc:	█ rspangler@chromium.org adurbin@chromium.org
Components:	OS>Firmware>EC
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	Bug
merge-merged-firmware-cr50-9308.B merge-merged-firmware-cr50-9308.24.B

ec: Consider removing jtag_pre_init()

Project Member Reported by sha...@chromium.org, Jul 22 2017

Issue description

JTAG is not a commonly-used feature. If someone wants to use it, they can set proper regs. by hand, eg. in a custom console command or HOOK_INIT function. Let's remove jtag_pre_init() since it's just an empty function (and sometimes a nearly-empty file) for some chips.

Comment 1 by sha...@chromium.org, Jul 22 2017

Components: OS>Firmware>EC
Labels: OS-Chrome

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/1029239bc18c1a8e1bff5f7aad040cdfe421dbd2

commit 1029239bc18c1a8e1bff5f7aad040cdfe421dbd2
Author: Randall Spangler <rspangler@chromium.org>
Date: Thu Aug 24 18:29:02 2017

g: Move chip pre-init to chip_pre_init()

Currently, chip/g uses jtag_pre_init() to do some chip
pre-initialization that isn't actually related to JTAG.  This has been
harmless, but it's currently the only chip which actually does "JTAG"
pre-init, and we'd like to get rid of that.  So, move that
functionality to a new optional chip_pre_init() function.

BUG= chromium:747629 
BRANCH=cr50
TEST=make buildall
     boot cr50
     make all dis; confirm chip_pre_init() is called early in <main>

Change-Id: I3cae0747ab0c3cc974fce9f108947207b38e035f
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/629876
Reviewed-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org>

[modify] https://crrev.com/1029239bc18c1a8e1bff5f7aad040cdfe421dbd2/chip/g/jtag.c
[add] https://crrev.com/1029239bc18c1a8e1bff5f7aad040cdfe421dbd2/chip/g/pre_init.c
[modify] https://crrev.com/1029239bc18c1a8e1bff5f7aad040cdfe421dbd2/chip/g/config_chip.h
[modify] https://crrev.com/1029239bc18c1a8e1bff5f7aad040cdfe421dbd2/include/config.h
[modify] https://crrev.com/1029239bc18c1a8e1bff5f7aad040cdfe421dbd2/common/main.c
[modify] https://crrev.com/1029239bc18c1a8e1bff5f7aad040cdfe421dbd2/chip/g/build.mk
[modify] https://crrev.com/1029239bc18c1a8e1bff5f7aad040cdfe421dbd2/include/board_config.h

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/0898c7a63a4ccb0f11c1c61bb085d8d062f664ab

commit 0898c7a63a4ccb0f11c1c61bb085d8d062f664ab
Author: Shawn Nematbakhsh <shawnn@chromium.org>
Date: Thu Sep 07 22:01:05 2017

cleanup: Remove jtag_pre_init()

Use our newly-created chip_pre_init() for doing JTAG initialization.

BUG= chromium:747629 
BRANCH=None
TEST=`make buildall -j`

Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Change-Id: Ic5771895a214a9f1aa9bd289eef576f52adf973f
Reviewed-on: https://chromium-review.googlesource.com/629676
Commit-Ready: Shawn N <shawnn@chromium.org>
Tested-by: Shawn N <shawnn@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>

[delete] https://crrev.com/096ea20ed18095a967e1829b6ae60b13453416be/chip/nrf51/jtag.c
[delete] https://crrev.com/096ea20ed18095a967e1829b6ae60b13453416be/chip/stm32/jtag-stm32l.c
[delete] https://crrev.com/096ea20ed18095a967e1829b6ae60b13453416be/chip/stm32/jtag-stm32f4.c
[modify] https://crrev.com/0898c7a63a4ccb0f11c1c61bb085d8d062f664ab/chip/lm4/system.c
[modify] https://crrev.com/0898c7a63a4ccb0f11c1c61bb085d8d062f664ab/chip/stm32/build.mk
[delete] https://crrev.com/096ea20ed18095a967e1829b6ae60b13453416be/chip/npcx/jtag.c
[modify] https://crrev.com/0898c7a63a4ccb0f11c1c61bb085d8d062f664ab/chip/nrf51/build.mk
[delete] https://crrev.com/096ea20ed18095a967e1829b6ae60b13453416be/chip/g/jtag.c
[modify] https://crrev.com/0898c7a63a4ccb0f11c1c61bb085d8d062f664ab/core/host/disabled.c
[delete] https://crrev.com/096ea20ed18095a967e1829b6ae60b13453416be/include/jtag.h
[delete] https://crrev.com/096ea20ed18095a967e1829b6ae60b13453416be/chip/stm32/jtag-stm32f3.c
[modify] https://crrev.com/0898c7a63a4ccb0f11c1c61bb085d8d062f664ab/chip/npcx/config_chip.h
[delete] https://crrev.com/096ea20ed18095a967e1829b6ae60b13453416be/chip/mec1322/jtag.c
[delete] https://crrev.com/096ea20ed18095a967e1829b6ae60b13453416be/chip/stm32/jtag-stm32l4.c
[modify] https://crrev.com/0898c7a63a4ccb0f11c1c61bb085d8d062f664ab/chip/it83xx/build.mk
[modify] https://crrev.com/0898c7a63a4ccb0f11c1c61bb085d8d062f664ab/chip/mec1322/build.mk
[modify] https://crrev.com/0898c7a63a4ccb0f11c1c61bb085d8d062f664ab/chip/npcx/system.c
[delete] https://crrev.com/096ea20ed18095a967e1829b6ae60b13453416be/chip/stm32/jtag-stm32f0.c
[delete] https://crrev.com/096ea20ed18095a967e1829b6ae60b13453416be/chip/it83xx/jtag.c
[modify] https://crrev.com/0898c7a63a4ccb0f11c1c61bb085d8d062f664ab/chip/lm4/build.mk
[modify] https://crrev.com/0898c7a63a4ccb0f11c1c61bb085d8d062f664ab/chip/npcx/build.mk
[delete] https://crrev.com/096ea20ed18095a967e1829b6ae60b13453416be/chip/ish/jtag.c
[modify] https://crrev.com/0898c7a63a4ccb0f11c1c61bb085d8d062f664ab/chip/lm4/config_chip.h
[modify] https://crrev.com/0898c7a63a4ccb0f11c1c61bb085d8d062f664ab/chip/g/build.mk
[modify] https://crrev.com/0898c7a63a4ccb0f11c1c61bb085d8d062f664ab/chip/ish/build.mk
[modify] https://crrev.com/0898c7a63a4ccb0f11c1c61bb085d8d062f664ab/board/samus/board.c
[modify] https://crrev.com/0898c7a63a4ccb0f11c1c61bb085d8d062f664ab/board/samus/board.h
[modify] https://crrev.com/0898c7a63a4ccb0f11c1c61bb085d8d062f664ab/chip/stm32/system.c
[modify] https://crrev.com/0898c7a63a4ccb0f11c1c61bb085d8d062f664ab/common/main.c
[delete] https://crrev.com/096ea20ed18095a967e1829b6ae60b13453416be/chip/lm4/jtag.c
[modify] https://crrev.com/0898c7a63a4ccb0f11c1c61bb085d8d062f664ab/chip/stm32/config_chip.h
[modify] https://crrev.com/0898c7a63a4ccb0f11c1c61bb085d8d062f664ab/chip/it83xx/config_chip.h
[modify] https://crrev.com/0898c7a63a4ccb0f11c1c61bb085d8d062f664ab/chip/it83xx/system.c

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 7 2017

Labels: merge-merged-firmware-cr50-9308.B

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/cb7691658dd6271e0f43fb31263982a9dfdcf854

commit cb7691658dd6271e0f43fb31263982a9dfdcf854
Author: Randall Spangler <rspangler@chromium.org>
Date: Thu Sep 07 22:34:12 2017

g: Move chip pre-init to chip_pre_init()

Currently, chip/g uses jtag_pre_init() to do some chip
pre-initialization that isn't actually related to JTAG.  This has been
harmless, but it's currently the only chip which actually does "JTAG"
pre-init, and we'd like to get rid of that.  So, move that
functionality to a new optional chip_pre_init() function.

BUG= chromium:747629 
BRANCH=cr50
TEST=make buildall
     boot cr50
     make all dis; confirm chip_pre_init() is called early in <main>

Change-Id: I3cae0747ab0c3cc974fce9f108947207b38e035f
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/629876
Reviewed-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org>
(cherry picked from commit 1029239bc18c1a8e1bff5f7aad040cdfe421dbd2)
Reviewed-on: https://chromium-review.googlesource.com/656388
Commit-Queue: Vadim Bendebury <vbendeb@chromium.org>
Tested-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>

[modify] https://crrev.com/cb7691658dd6271e0f43fb31263982a9dfdcf854/chip/g/jtag.c
[add] https://crrev.com/cb7691658dd6271e0f43fb31263982a9dfdcf854/chip/g/pre_init.c
[modify] https://crrev.com/cb7691658dd6271e0f43fb31263982a9dfdcf854/chip/g/config_chip.h
[modify] https://crrev.com/cb7691658dd6271e0f43fb31263982a9dfdcf854/include/config.h
[modify] https://crrev.com/cb7691658dd6271e0f43fb31263982a9dfdcf854/common/main.c
[modify] https://crrev.com/cb7691658dd6271e0f43fb31263982a9dfdcf854/chip/g/build.mk
[modify] https://crrev.com/cb7691658dd6271e0f43fb31263982a9dfdcf854/include/board_config.h

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/58c58000843a5c544a0f74abdb51d2985353642f

commit 58c58000843a5c544a0f74abdb51d2985353642f
Author: Shawn Nematbakhsh <shawnn@chromium.org>
Date: Mon Sep 11 21:34:19 2017

cleanup: Remove jtag_pre_init()

Use our newly-created chip_pre_init() for doing JTAG initialization.

 Conflicts:
	chip/npcx/build.mk

BUG= chromium:747629 
BRANCH=None
TEST=`make buildall -j`

Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Change-Id: Ic5771895a214a9f1aa9bd289eef576f52adf973f
Reviewed-on: https://chromium-review.googlesource.com/629676
Commit-Ready: Shawn N <shawnn@chromium.org>
Tested-by: Shawn N <shawnn@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
(cherry picked from commit 0898c7a63a4ccb0f11c1c61bb085d8d062f664ab)
Reviewed-on: https://chromium-review.googlesource.com/660892
Commit-Queue: Vadim Bendebury <vbendeb@chromium.org>
Tested-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>

[delete] https://crrev.com/b31512fe872257a6a34019e9f80d2c0352d3c544/chip/nrf51/jtag.c
[delete] https://crrev.com/b31512fe872257a6a34019e9f80d2c0352d3c544/chip/stm32/jtag-stm32l.c
[delete] https://crrev.com/b31512fe872257a6a34019e9f80d2c0352d3c544/chip/stm32/jtag-stm32f4.c
[modify] https://crrev.com/58c58000843a5c544a0f74abdb51d2985353642f/chip/lm4/system.c
[modify] https://crrev.com/58c58000843a5c544a0f74abdb51d2985353642f/chip/stm32/build.mk
[delete] https://crrev.com/b31512fe872257a6a34019e9f80d2c0352d3c544/chip/npcx/jtag.c
[modify] https://crrev.com/58c58000843a5c544a0f74abdb51d2985353642f/chip/nrf51/build.mk
[delete] https://crrev.com/b31512fe872257a6a34019e9f80d2c0352d3c544/chip/g/jtag.c
[modify] https://crrev.com/58c58000843a5c544a0f74abdb51d2985353642f/core/host/disabled.c
[delete] https://crrev.com/b31512fe872257a6a34019e9f80d2c0352d3c544/include/jtag.h
[delete] https://crrev.com/b31512fe872257a6a34019e9f80d2c0352d3c544/chip/stm32/jtag-stm32f3.c
[modify] https://crrev.com/58c58000843a5c544a0f74abdb51d2985353642f/chip/npcx/config_chip.h
[delete] https://crrev.com/b31512fe872257a6a34019e9f80d2c0352d3c544/chip/mec1322/jtag.c
[delete] https://crrev.com/b31512fe872257a6a34019e9f80d2c0352d3c544/chip/stm32/jtag-stm32l4.c
[modify] https://crrev.com/58c58000843a5c544a0f74abdb51d2985353642f/chip/it83xx/build.mk
[modify] https://crrev.com/58c58000843a5c544a0f74abdb51d2985353642f/chip/mec1322/build.mk
[modify] https://crrev.com/58c58000843a5c544a0f74abdb51d2985353642f/chip/npcx/system.c
[delete] https://crrev.com/b31512fe872257a6a34019e9f80d2c0352d3c544/chip/stm32/jtag-stm32f0.c
[delete] https://crrev.com/b31512fe872257a6a34019e9f80d2c0352d3c544/chip/it83xx/jtag.c
[modify] https://crrev.com/58c58000843a5c544a0f74abdb51d2985353642f/chip/lm4/build.mk
[modify] https://crrev.com/58c58000843a5c544a0f74abdb51d2985353642f/chip/npcx/build.mk
[delete] https://crrev.com/b31512fe872257a6a34019e9f80d2c0352d3c544/chip/ish/jtag.c
[modify] https://crrev.com/58c58000843a5c544a0f74abdb51d2985353642f/chip/lm4/config_chip.h
[modify] https://crrev.com/58c58000843a5c544a0f74abdb51d2985353642f/chip/g/build.mk
[modify] https://crrev.com/58c58000843a5c544a0f74abdb51d2985353642f/chip/ish/build.mk
[modify] https://crrev.com/58c58000843a5c544a0f74abdb51d2985353642f/board/samus/board.c
[modify] https://crrev.com/58c58000843a5c544a0f74abdb51d2985353642f/board/samus/board.h
[modify] https://crrev.com/58c58000843a5c544a0f74abdb51d2985353642f/chip/stm32/system.c
[modify] https://crrev.com/58c58000843a5c544a0f74abdb51d2985353642f/common/main.c
[delete] https://crrev.com/b31512fe872257a6a34019e9f80d2c0352d3c544/chip/lm4/jtag.c
[modify] https://crrev.com/58c58000843a5c544a0f74abdb51d2985353642f/chip/stm32/config_chip.h
[modify] https://crrev.com/58c58000843a5c544a0f74abdb51d2985353642f/chip/it83xx/config_chip.h
[modify] https://crrev.com/58c58000843a5c544a0f74abdb51d2985353642f/chip/it83xx/system.c

Comment 6 by sha...@chromium.org, Sep 25 2017

Status: Verified (was: Untriaged)

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 16 2017

Labels: merge-merged-firmware-cr50-9308.24.B

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/ecfec3d7fd7a3330ca1ec6ab98bf4803fab8ff01

commit ecfec3d7fd7a3330ca1ec6ab98bf4803fab8ff01
Author: Shawn Nematbakhsh <shawnn@chromium.org>
Date: Sat Dec 16 00:56:12 2017

cleanup: Remove jtag_pre_init()

Use our newly-created chip_pre_init() for doing JTAG initialization.

 Conflicts:
	chip/npcx/build.mk

BUG= chromium:747629 
BRANCH=None
TEST=`make buildall -j`

Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Change-Id: Ic5771895a214a9f1aa9bd289eef576f52adf973f
Reviewed-on: https://chromium-review.googlesource.com/629676
Commit-Ready: Shawn N <shawnn@chromium.org>
Tested-by: Shawn N <shawnn@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
(cherry picked from commit 0898c7a63a4ccb0f11c1c61bb085d8d062f664ab)
Reviewed-on: https://chromium-review.googlesource.com/660892
Commit-Queue: Vadim Bendebury <vbendeb@chromium.org>
Tested-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
(cherry picked from commit 58c58000843a5c544a0f74abdb51d2985353642f)
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/828413

[delete] https://crrev.com/a737b09f93018be2f3b2f679ff003cc6ee975758/chip/nrf51/jtag.c
[delete] https://crrev.com/a737b09f93018be2f3b2f679ff003cc6ee975758/chip/stm32/jtag-stm32l.c
[delete] https://crrev.com/a737b09f93018be2f3b2f679ff003cc6ee975758/chip/stm32/jtag-stm32f4.c
[modify] https://crrev.com/ecfec3d7fd7a3330ca1ec6ab98bf4803fab8ff01/chip/lm4/system.c
[modify] https://crrev.com/ecfec3d7fd7a3330ca1ec6ab98bf4803fab8ff01/chip/stm32/build.mk
[delete] https://crrev.com/a737b09f93018be2f3b2f679ff003cc6ee975758/chip/npcx/jtag.c
[modify] https://crrev.com/ecfec3d7fd7a3330ca1ec6ab98bf4803fab8ff01/chip/nrf51/build.mk
[delete] https://crrev.com/a737b09f93018be2f3b2f679ff003cc6ee975758/chip/g/jtag.c
[modify] https://crrev.com/ecfec3d7fd7a3330ca1ec6ab98bf4803fab8ff01/core/host/disabled.c
[delete] https://crrev.com/a737b09f93018be2f3b2f679ff003cc6ee975758/include/jtag.h
[delete] https://crrev.com/a737b09f93018be2f3b2f679ff003cc6ee975758/chip/stm32/jtag-stm32f3.c
[modify] https://crrev.com/ecfec3d7fd7a3330ca1ec6ab98bf4803fab8ff01/chip/npcx/config_chip.h
[delete] https://crrev.com/a737b09f93018be2f3b2f679ff003cc6ee975758/chip/mec1322/jtag.c
[delete] https://crrev.com/a737b09f93018be2f3b2f679ff003cc6ee975758/chip/stm32/jtag-stm32l4.c
[modify] https://crrev.com/ecfec3d7fd7a3330ca1ec6ab98bf4803fab8ff01/chip/it83xx/build.mk
[modify] https://crrev.com/ecfec3d7fd7a3330ca1ec6ab98bf4803fab8ff01/chip/mec1322/build.mk
[modify] https://crrev.com/ecfec3d7fd7a3330ca1ec6ab98bf4803fab8ff01/chip/npcx/system.c
[delete] https://crrev.com/a737b09f93018be2f3b2f679ff003cc6ee975758/chip/stm32/jtag-stm32f0.c
[delete] https://crrev.com/a737b09f93018be2f3b2f679ff003cc6ee975758/chip/it83xx/jtag.c
[modify] https://crrev.com/ecfec3d7fd7a3330ca1ec6ab98bf4803fab8ff01/chip/lm4/build.mk
[modify] https://crrev.com/ecfec3d7fd7a3330ca1ec6ab98bf4803fab8ff01/chip/npcx/build.mk
[delete] https://crrev.com/a737b09f93018be2f3b2f679ff003cc6ee975758/chip/ish/jtag.c
[modify] https://crrev.com/ecfec3d7fd7a3330ca1ec6ab98bf4803fab8ff01/chip/lm4/config_chip.h
[modify] https://crrev.com/ecfec3d7fd7a3330ca1ec6ab98bf4803fab8ff01/chip/g/build.mk
[modify] https://crrev.com/ecfec3d7fd7a3330ca1ec6ab98bf4803fab8ff01/chip/ish/build.mk
[modify] https://crrev.com/ecfec3d7fd7a3330ca1ec6ab98bf4803fab8ff01/board/samus/board.c
[modify] https://crrev.com/ecfec3d7fd7a3330ca1ec6ab98bf4803fab8ff01/board/samus/board.h
[modify] https://crrev.com/ecfec3d7fd7a3330ca1ec6ab98bf4803fab8ff01/chip/stm32/system.c
[modify] https://crrev.com/ecfec3d7fd7a3330ca1ec6ab98bf4803fab8ff01/common/main.c
[delete] https://crrev.com/a737b09f93018be2f3b2f679ff003cc6ee975758/chip/lm4/jtag.c
[modify] https://crrev.com/ecfec3d7fd7a3330ca1ec6ab98bf4803fab8ff01/chip/stm32/config_chip.h
[modify] https://crrev.com/ecfec3d7fd7a3330ca1ec6ab98bf4803fab8ff01/chip/it83xx/config_chip.h
[modify] https://crrev.com/ecfec3d7fd7a3330ca1ec6ab98bf4803fab8ff01/chip/it83xx/system.c

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/5cce8ce519bdde8c49cd5718febfcad78c48c17a

commit 5cce8ce519bdde8c49cd5718febfcad78c48c17a
Author: Randall Spangler <rspangler@chromium.org>
Date: Tue Jan 02 20:47:03 2018

g: Move chip pre-init to chip_pre_init()

Currently, chip/g uses jtag_pre_init() to do some chip
pre-initialization that isn't actually related to JTAG.  This has been
harmless, but it's currently the only chip which actually does "JTAG"
pre-init, and we'd like to get rid of that.  So, move that
functionality to a new optional chip_pre_init() function.

Conflicts:
	chip/g/build.mk
	chip/g/jtag.c

BUG= chromium:747629 
BRANCH=cr50
TEST=make buildall
     boot cr50
     make all dis; confirm chip_pre_init() is called early in <main>

Change-Id: I3cae0747ab0c3cc974fce9f108947207b38e035f
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/629876
Reviewed-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org>
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
(cherry picked from commit 1029239bc18c1a8e1bff5f7aad040cdfe421dbd2)
Reviewed-on: https://chromium-review.googlesource.com/847692

[add] https://crrev.com/5cce8ce519bdde8c49cd5718febfcad78c48c17a/chip/g/pre_init.c
[modify] https://crrev.com/5cce8ce519bdde8c49cd5718febfcad78c48c17a/chip/g/config_chip.h
[modify] https://crrev.com/5cce8ce519bdde8c49cd5718febfcad78c48c17a/include/config.h
[modify] https://crrev.com/5cce8ce519bdde8c49cd5718febfcad78c48c17a/common/main.c
[modify] https://crrev.com/5cce8ce519bdde8c49cd5718febfcad78c48c17a/chip/g/build.mk
[modify] https://crrev.com/5cce8ce519bdde8c49cd5718febfcad78c48c17a/include/board_config.h

►

Issue 747629 link

Issue metadata

ec: Consider removing jtag_pre_init()

Issue description

Comment 1 by sha...@chromium.org, Jul 22 2017

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Aug 24 2017

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Sep 7 2017

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Sep 7 2017

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Sep 11 2017

Comment 5 Deleted

Comment 6 by sha...@chromium.org, Sep 25 2017

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Dec 16 2017

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Jan 2 2018

Comment 8 Deleted

Sign in to add a comment