New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 747626 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[MD settings] set URL route for OnStartup sub-page startupPages

Project Member Reported by dschuyler@chromium.org, Jul 21 2017

Issue description

Set URL route for OnStartup sub-page to chrome://settings/startupPages. In an email conversation we'd discussed changing that "startupPages" seemed more approachable that others considered (startupUrls or onStartup).
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2dc1b0f5d089cd78bf907b38be2aeb53f40648fe

commit 2dc1b0f5d089cd78bf907b38be2aeb53f40648fe
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Wed Jul 26 02:18:20 2017

[MD settings] change route for startupUrls to startupPages

This CL changes the route name for the OnStartup settings sub-page. The
new route is chrome://settings/startupPages.

Bug:  747626 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1d13908fb6e2ca9a4e09e6032caa05c796bfddc6
Reviewed-on: https://chromium-review.googlesource.com/582467
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489530}
[modify] https://crrev.com/2dc1b0f5d089cd78bf907b38be2aeb53f40648fe/chrome/browser/resources/settings/on_startup_page/on_startup_page.html
[modify] https://crrev.com/2dc1b0f5d089cd78bf907b38be2aeb53f40648fe/chrome/browser/resources/settings/on_startup_page/on_startup_page.js
[modify] https://crrev.com/2dc1b0f5d089cd78bf907b38be2aeb53f40648fe/chrome/browser/resources/settings/route.js

Status: Fixed (was: Started)

Sign in to add a comment