[A11y] Voiceover problems with extension permission dialogue |
|||
Issue descriptionWhen attempting to install the extension titled "Momentum", the following issues occurred on Mac (most likely reproducible on all platforms): 1) The Momentum logo has no label, so it just says "image". If we can't use the logo label (e.g. Momentum logo" then we should make it empty alt text so screen readers skip it. 2) The star rating section needs some help. With VoiceOver, you have to navigate through each start (for which you just hear "image"). Then you get to the number of ratings and all you hear is a number, without any context of what that means. So you hear "image" then press ctrl option right, hear "image", ctrl option right "image", ctrl option right, "10282"... for example. This is really not intuitive. What it should do is somehow summarize more intuitively, like "rated 5 stars by 10382 people". 3) For some reazon, when I navigate through this UI with VoiceOver, every line is verbalizing twice. If I press ctrl option right to move forward to the next item, liek "it can", I hear "it can, it can". Same for everything on there except the buttons. Link to extension used to reproduce: https://chrome.google.com/webstore/detail/momentum/laookkfknpbbblfpciffpaejjkokdgca
,
Oct 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e93c564e8644d2a49b6bd00d5140ef4687a2bb6a commit e93c564e8644d2a49b6bd00d5140ef4687a2bb6a Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Oct 05 01:45:16 2017 [Extensions Mac A11y] Don't VoiceOver the icon in the install dialog The icon in the install dialog is just the icon of the extension, whose name is included in the title. Currently, this icon simply says "image" when VoiceOver is used to highlight the element. We could add an alt-text of "<Extension name> icon", but this doesn't add any additional context beyond what the title (immediately before the image) provides. Instead, remove the icon from the VoiceOver tree entirely. Bug: 747624 Change-Id: Ic5373ca4a766b72696839062ffa89d8780d97e35 Reviewed-on: https://chromium-review.googlesource.com/701918 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#506617} [modify] https://crrev.com/e93c564e8644d2a49b6bd00d5140ef4687a2bb6a/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d2f869ce2bca91b5ba5ccae1289e08f24104aef commit 2d2f869ce2bca91b5ba5ccae1289e08f24104aef Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Nov 30 21:30:15 2017 [Extensions A11y] Update a11y text for inline installation dialog The extension inline install dialog contains a section for the webstore ratings. This is rendered as a star rating (n / 5 filled stars) and a user count displayed in parentheses. For example, ***** (345) Unfortunately, the accessible text for this is lacking - each star (filled or not) simply says "graphic", followed by the number. So the content read by a screen reader would be: "graphic graphic graphic graphic graphic 345" which is very unhelpful. Introduce a custom view for the ratings section, which hides the star graphics and the user label from the accessibility tree. Instead, provide custom accessible text to give meaning. Now, the screen reader will read: "Rated 5.0 by 345 users" Bug: 747624 Change-Id: I96d829efd098cc6795389b3190f0c2a901f55a93 Reviewed-on: https://chromium-review.googlesource.com/782711 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#520693} [modify] https://crrev.com/2d2f869ce2bca91b5ba5ccae1289e08f24104aef/chrome/app/generated_resources.grd [modify] https://crrev.com/2d2f869ce2bca91b5ba5ccae1289e08f24104aef/chrome/browser/extensions/extension_install_prompt.h [modify] https://crrev.com/2d2f869ce2bca91b5ba5ccae1289e08f24104aef/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc [modify] https://crrev.com/2d2f869ce2bca91b5ba5ccae1289e08f24104aef/chrome/browser/ui/views/extensions/extension_install_dialog_view.h [modify] https://crrev.com/2d2f869ce2bca91b5ba5ccae1289e08f24104aef/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc
,
Dec 15 2017
,
Dec 15 2017
lpalmaro@, can you take a look at the dialog on Windows again? It should be significantly improved. Note there's still issue 730953 which affects this dialog, but dmazzoni@ suggested we hold off on that one until we know what a good pattern is that we can apply more broadly.
,
Dec 15 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by lpalmaro@chromium.org
, Oct 3 2017Owner: jawag@chromium.org
Status: Assigned (was: Untriaged)