tegrarcm does not build with libc++ |
|||
Issue descriptionRoot cause: tegrarcm depends on dev-libs/crypto++. Currently dev-libs/crypto++ is built with g++ which uses stdlibc++. There are string objects passed in the crypto++ library interfaces which are ABI incompatible with libc++. So tegrarcm needs to use same c+= library as crypto++ i.e. stdlibc++.
,
Jul 23 2017
,
Jul 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/09b70bde1c54eb8b5d428fcd2ade90b66859c13b commit 09b70bde1c54eb8b5d428fcd2ade90b66859c13b Author: Manoj Gupta <manojgupta@google.com> Date: Tue Jul 25 03:32:47 2017 tegrarcm: Force building using libstdc++. tegrarcm depends on dev-libs/crypto++. Currently dev-libs/crypto++ is built with g++ which uses stdlibc++. There are string objects passed in the crypto++ library interfaces which are ABI incompatible with libc++. So tegrarcm needs to use same C++ std library as crypto++ i.e. stdlibc++. BUG= chromium:747618 TEST=tegrarcm builds with and without libc++. Change-Id: I5c8a012efdc044bc9cdc7890a55c682f8ee9c175 Reviewed-on: https://chromium-review.googlesource.com/582447 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org> [add] https://crrev.com/09b70bde1c54eb8b5d428fcd2ade90b66859c13b/chromeos/config/env/dev-embedded/tegrarcm
,
Jul 25 2017
Disabled libc++ for tegrarcm for now. Will revisit once crypto++ is built with clang.
,
Jul 25 2017
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/afaee5fb320c16d5cf917f75441f136011b82eda commit afaee5fb320c16d5cf917f75441f136011b82eda Author: Manoj Gupta <manojgupta@google.com> Date: Fri Jul 28 22:04:21 2017 tegrarcm: Remove forced use of libstdc++. The ABI incompatibility issue with crypto++ is fixed as cypto++ can be compiled with clang now. So remove forced use of libstdc++. CQ-DEPEND=CL:590673 BUG= chromium:747618 TEST=tegrarcm builds with libc++. Change-Id: Ife44c4d79adde98dcc8b4eae512c02e215ec573a Reviewed-on: https://chromium-review.googlesource.com/590732 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org> [delete] https://crrev.com/cf0d5207e185caf49fd3d311149cac5a9eca4e9d/chromeos/config/env/dev-embedded/tegrarcm |
|||
►
Sign in to add a comment |
|||
Comment 1 by manojgupta@chromium.org
, Jul 21 2017