fukino@ - Could you please take a look?

I confirmed the following issue in the video.

1. Select a Drive file by clicking it.
2. Press ESC to unselect it.
3. Select the same file.

Expected behavior: Share icon on toolbar is shown.
Actual behavior: Share icon is not shown.


I could not find other issues in the video.
If there are any, could you let me know?

Please not that following behavior is working as intended.
1) When multiple Drive files are selected, we don't have "Share with others" options so share icon will disappear.
2) When only one file file is selected, we have "Share with others" option, that's why we have share icon on toolbar.

In case 2), there are multiple options in share menu in the video, but it is a separate bug.  issue 747200 .

+mkarkada@ - Can we close this given fukino@'s explanation?

@fukino, @weifangsun,
Here are couple of my observations:

1. When multiple Drive files are selected, share option is disabled. I believe this is WAI.

2. When only one file is selected, we have only "Share with others" option now. But sometimes, this share option is disabled and sometimes share option gets enabled. This behavior is flickering.

3. When only one file is selected, I don't see multiple options in share menu now.

Tested on Chrome OS 9765.53.0/61.0.3163.80.

Thank you!

mkarkada@ -

For (1), agreed when multiple Drive files are selected, the "Share with others" option is disabled - WAI. Once  crbug.com/751864  is fixed, the ability Share via Android apps however should be available.

Skipping to (3), I believe this is also related to  crbug.com/751864 . Whether you have 1 or more files selected, Android apps won't be available until this bug is fixed in M63.

For (2), I was able to reproduce the behavior where the Share icon is not being presented to consistently when only 1 file is selected so let's keep this bug open for this issue.

Moving to M63 to fix.

Sure, thank you for your explanations!

mkarkada@, this should have been fixed in M64 and later.
Could you verify the  issue 2 ) in comment #8?

Please note that, since  issue 740063  was fixed, you will see other options (e.g. "Upload to Photos" etc...) in share menu when only one Drive file is selected.

Hi fukino, here are by observations on M64 official beta build (10176.54.0, 64.0.3282.101):

1. Issue no.2 in comment #8 is still existing. With only one file/ folder/ zip archive selected, the behavior of share option being enabled or disabled is still flickering. Please refer the issue videos in this link:
https://pantheon.corp.google.com/storage/browser/chromiumos-test-logs/bugfiles/cr/747607/

2. When one drive file is selected, share options with android apps are now available.

3. When multiple drive files are selected, share options with android apps are also available. But, 'Share with others' option is disabled.

mkarkada@, thank you for the confirmation!
2 and 3 are expected behaviors.
Regarding 1, I was able to reproduce the issue. I'll work on it.

<files-triage>

The  issue 2  in comment #8 is working on ToT now. I observed the bug a few weeks ago, but with recent changes this looks like it's been fixed. Please re-open if the issue reappears.