New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 747599 link

Starred by 2 users

Issue metadata

Status: Archived
Owner: ----
Closed: Jan 10
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Add a min required chrome-sdk version in Chrome.

Project Member Reported by dcasta...@chromium.org, Jul 21 2017

Issue description

Certain CLs in Chrome have specific cros sdk dependencies.

For example https://chromium-review.googlesource.com/c/549095/ Chromium CL depends on a define BO_USE_TEXTURING that was added with https://chromium.googlesource.com/chromiumos/platform/minigbm/+/3909dc011bf32c13858fb80c33a3cce68769cb26 in minigbm.

In the normal Chromium workflow many developers don't update the cros sdk all the times, but they just git pull Chromium and build.

This ends up in confusing errors and unnecessary reverts: https://chromium-review.googlesource.com/c/582347/

It'd be nice to be able to specify the required cros version in Chromium (maybe in a build file), and have a more meaningful message suggesting to clear the sdk (cros chrome-sdk --clear-sdk-cache) when the Chromium build requires a newer cros sdk than the one currently being used to build.
 
Cc: dpranke@chromium.org mcasas@chromium.org
Labels: OS-Chrome
dpranke@ this has bit me a few times but I admit I wouldn't know
where to start looking for a solution, any pointers would be very
appreciated :-)
How would you determine the SDK version? Would you use something besides //chromeos/CHROMEOS_LKGM ?

If you wanted to enforce this at GN-time (like we do on Mac and Win), you can look at //build/config/win/visual_studio_version.gni or //build/config/mac/mac_sdk.gni. The basic idea is to launch a script to read something from somewhere to get the version, and then compare it to the minimum supported version in the gni file.


Cc: hoegsberg@chromium.org
The SDK version would be explicitly determined by the owner of the Chromium CL that adds the dependency to a specific CrOS SDK version.

It can't be //chromeos/CHROMEOS_LKGM since that would force everyone to update their local SDK any time we have a new one, even if there is no new dependency.

A typical workflow is to pull down an sdk with 'cros chrome-sdk', then, at a later time, pull new code for Chromium, that might introduce a dependency to a new sdk.
Re-running 'cros chrome-sdk' won't download a new sdk unless --clear-sdk is specified.
So if a new dependency is introduced, you'll likely get a build error.

Enforcing it at GN-time would work.
When a new dependency is introduced, the author of the Chromium CL could bump up soomething like a min-version-required in a file in the Chromium tree. GN would then read that, and make clear a new chrome-sdk is needed if that's the case.
Status: Archived (was: Untriaged)
Archiving P3s older than 1 year with no owner or component.

Sign in to add a comment