New issue
Advanced search Search tips

Issue 747598 link

Starred by 1 user
Status: Fixed
Owner:
m...@chromium.org
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Inconsistent arg types in cc::AnimationDelegate::NotifyAnimationTakeover()

Project Member Reported by m...@chromium.org, Jul 21 2017 
This interface method has two arguments that pass time values using two different types (TimeTicks versus double). As this is Chromium code, TimeTicks should be used for both args, and only convert to double where Chromium code calls into the external library.

Comment 1 by m...@chromium.org, Jul 27 2017

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46ec749a9ddf6a20d640cdf8882bfee50defa025

commit 46ec749a9ddf6a20d640cdf8882bfee50defa025
Author: Yuri Wiitala <miu@chromium.org>
Date: Fri Jul 28 02:36:31 2017

Make AnimDelegate::NotifyAnimationTakeover() time arg types consistent.

During recent clean-up work, it was noted that this method took two time
arguments having the same value semantics, but used different types for
each arg. This change makes them both consistent by using
base::TimeTicks.

Bug:  747598 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I078d030bcc2b3dd7f6f8fdbc8545291a76332dd4
Reviewed-on: https://chromium-review.googlesource.com/588035
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490218}
[modify] https://crrev.com/46ec749a9ddf6a20d640cdf8882bfee50defa025/cc/animation/animation_delegate.h
[modify] https://crrev.com/46ec749a9ddf6a20d640cdf8882bfee50defa025/cc/animation/animation_events.h
[modify] https://crrev.com/46ec749a9ddf6a20d640cdf8882bfee50defa025/cc/animation/animation_player.cc
[modify] https://crrev.com/46ec749a9ddf6a20d640cdf8882bfee50defa025/cc/animation/element_animations_unittest.cc
[modify] https://crrev.com/46ec749a9ddf6a20d640cdf8882bfee50defa025/cc/animation/scroll_offset_animations_impl.h
[modify] https://crrev.com/46ec749a9ddf6a20d640cdf8882bfee50defa025/cc/test/animation_timelines_test_common.cc
[modify] https://crrev.com/46ec749a9ddf6a20d640cdf8882bfee50defa025/cc/test/animation_timelines_test_common.h
[modify] https://crrev.com/46ec749a9ddf6a20d640cdf8882bfee50defa025/cc/test/test_hooks.h
[modify] https://crrev.com/46ec749a9ddf6a20d640cdf8882bfee50defa025/cc/trees/layer_tree_host_unittest_animation.cc
[modify] https://crrev.com/46ec749a9ddf6a20d640cdf8882bfee50defa025/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.cpp
[modify] https://crrev.com/46ec749a9ddf6a20d640cdf8882bfee50defa025/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.h
[modify] https://crrev.com/46ec749a9ddf6a20d640cdf8882bfee50defa025/ui/compositor/layer_animator.h

Comment 3 by m...@chromium.org, Jul 31 2017

Status: Fixed (was: Started)
►

Sign in to add a comment