New issue
Advanced search Search tips

Issue 747596 link

Starred by 2 users
Status: Untriaged
Owner: ----
Cc:
michae...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Use ES6 arrow function instead of .bind(this) where possible.

Project Member Reported by dpa...@chromium.org, Jul 21 2017 
ES6 arrow function is allowed by the ES6 styluguide [1] and it eliminates the need to call bind(this) when defining a callback function. There is an automated way to do this conversion using a tool called lebab [2] (with a slight local modification needed to only convert bind(this) and not other cases).

I am taking this approach for MD Settings at [3]. This bug is to track similar work for the remaining WebUI pages (that we care about, meaning non obsolete), thinking of Downloads, History, Bookmarks and Print preview.

[1] https://chromium.googlesource.com/chromium/src/+/master/docs/es6_chromium.md#Arrow-Functions
[2] https://github.com/lebab/lebab#safe-transforms

https://codereview.chromium.org/2984843003
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e535c2e3896a52940acf23e83d7505755fff5ea3

commit e535c2e3896a52940acf23e83d7505755fff5ea3
Author: dpapad <dpapad@chromium.org>
Date: Mon Jul 24 21:12:22 2017

MD Settings: Convert all usages of .bind(this) to use ES6 arrow function.

Conversion happened with an automated tool. After the conversion some new
legitimate compiler errors surfaced, which I fixed.

BUG=747596
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2984843003
Cr-Commit-Position: refs/heads/master@{#489075}

[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/about_page/about_page.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/about_page/channel_switcher_dialog.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/about_page/detailed_build_info.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/animation/animation.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/appearance_page/appearance_page.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/appearance_page/home_url_input.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/basic_page/basic_page.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/certificate_manager_page/certificate_delete_confirmation_dialog.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/certificate_manager_page/certificate_list.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/certificate_manager_page/certificate_manager_page.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/certificate_manager_page/certificate_password_decryption_dialog.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/certificate_manager_page/certificate_password_encryption_dialog.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/controls/pref_control_behavior.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/controls/settings_dropdown_menu.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/controls/settings_idle_load.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/device_page/layout_behavior.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/device_page/storage.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/downloads_page/downloads_page.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/internet_page/internet_detail_page.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/internet_page/internet_page.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/internet_page/internet_subpage.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/internet_page/network_apnlist.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/internet_page/network_nameservers.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/internet_page/network_property_list.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/internet_page/network_proxy.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/internet_page/network_siminfo.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/internet_page/network_summary.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/languages_page/add_languages_dialog.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/languages_page/edit_dictionary_page.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/languages_page/languages.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/languages_page/languages_page.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/on_startup_page/startup_url_dialog.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/people_page/fingerprint_list.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/people_page/import_data_dialog.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/people_page/lock_screen.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/people_page/lock_state_behavior.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/people_page/manage_profile.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/people_page/password_prompt_dialog.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/people_page/people_page.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/people_page/setup_fingerprint_dialog.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/people_page/sync_page.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/people_page/user_list.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/people_page/users_page.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/prefs/prefs.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/search_engines_page/search_engines_page.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/search_page/search_page.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/search_settings.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/settings_main/settings_main.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/settings_page/main_page_behavior.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/settings_page/settings_section.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/settings_ui/settings_ui.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/site_settings/add_site_dialog.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/site_settings/category_default_setting.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/site_settings/cookie_tree_behavior.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/site_settings/edit_exception_dialog.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/site_settings/media_picker.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/site_settings/usb_devices.js
[modify] https://crrev.com/e535c2e3896a52940acf23e83d7505755fff5ea3/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43a2519653a59c0f34b71cf7d6a35647a8c96e9a

commit 43a2519653a59c0f34b71cf7d6a35647a8c96e9a
Author: dpapad <dpapad@chromium.org>
Date: Tue Jul 25 17:31:45 2017

Print preview: Convert all usages of .bind(this) to use ES6 arrow function.

Bug: 747596
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idedc1753e7e20b62548375e22c3e04bc2a48f92a
Reviewed-on: https://chromium-review.googlesource.com/583779
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489353}
[modify] https://crrev.com/43a2519653a59c0f34b71cf7d6a35647a8c96e9a/chrome/browser/resources/print_preview/common/overlay.js
[modify] https://crrev.com/43a2519653a59c0f34b71cf7d6a35647a8c96e9a/chrome/browser/resources/print_preview/data/destination_store.js
[modify] https://crrev.com/43a2519653a59c0f34b71cf7d6a35647a8c96e9a/chrome/browser/resources/print_preview/previewarea/preview_area.js
[modify] https://crrev.com/43a2519653a59c0f34b71cf7d6a35647a8c96e9a/chrome/browser/resources/print_preview/print_preview.js
[modify] https://crrev.com/43a2519653a59c0f34b71cf7d6a35647a8c96e9a/chrome/browser/resources/print_preview/search/destination_list.js
[modify] https://crrev.com/43a2519653a59c0f34b71cf7d6a35647a8c96e9a/chrome/browser/resources/print_preview/search/destination_search.js
[modify] https://crrev.com/43a2519653a59c0f34b71cf7d6a35647a8c96e9a/chrome/browser/resources/print_preview/settings/advanced_options_settings.js
[modify] https://crrev.com/43a2519653a59c0f34b71cf7d6a35647a8c96e9a/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js
[modify] https://crrev.com/43a2519653a59c0f34b71cf7d6a35647a8c96e9a/chrome/browser/resources/print_preview/settings/copies_settings.js
[modify] https://crrev.com/43a2519653a59c0f34b71cf7d6a35647a8c96e9a/chrome/browser/resources/print_preview/settings/more_settings.js
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/325bf2f159f80cb9cd718e2f6cf525991cf4ff17

commit 325bf2f159f80cb9cd718e2f6cf525991cf4ff17
Author: dpapad <dpapad@chromium.org>
Date: Wed Jul 26 18:47:34 2017

MD Bookmarks: Convert all usages of .bind(this) to use ES6 arrow function.

Bug: 747596
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib3f17040a2c46f60a0213943da2ff56c13f5c3d3
Reviewed-on: https://chromium-review.googlesource.com/585849
Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489712}
[modify] https://crrev.com/325bf2f159f80cb9cd718e2f6cf525991cf4ff17/chrome/browser/resources/md_bookmarks/app.js
[modify] https://crrev.com/325bf2f159f80cb9cd718e2f6cf525991cf4ff17/chrome/browser/resources/md_bookmarks/command_manager.js
[modify] https://crrev.com/325bf2f159f80cb9cd718e2f6cf525991cf4ff17/chrome/browser/resources/md_bookmarks/dialog_focus_manager.js
[modify] https://crrev.com/325bf2f159f80cb9cd718e2f6cf525991cf4ff17/chrome/browser/resources/md_bookmarks/dnd_manager.js
[modify] https://crrev.com/325bf2f159f80cb9cd718e2f6cf525991cf4ff17/chrome/browser/resources/md_bookmarks/folder_node.js
[modify] https://crrev.com/325bf2f159f80cb9cd718e2f6cf525991cf4ff17/chrome/browser/resources/md_bookmarks/item.js
[modify] https://crrev.com/325bf2f159f80cb9cd718e2f6cf525991cf4ff17/chrome/browser/resources/md_bookmarks/list.js
[modify] https://crrev.com/325bf2f159f80cb9cd718e2f6cf525991cf4ff17/chrome/browser/resources/md_bookmarks/router.js
[modify] https://crrev.com/325bf2f159f80cb9cd718e2f6cf525991cf4ff17/chrome/browser/resources/md_bookmarks/store.js
[modify] https://crrev.com/325bf2f159f80cb9cd718e2f6cf525991cf4ff17/chrome/browser/resources/md_bookmarks/store_client.js
[modify] https://crrev.com/325bf2f159f80cb9cd718e2f6cf525991cf4ff17/chrome/browser/resources/md_bookmarks/toast_manager.js
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ade00cae06ef85328db519f6e4899088d10c1be

commit 9ade00cae06ef85328db519f6e4899088d10c1be
Author: dpapad <dpapad@chromium.org>
Date: Wed Jul 26 22:44:15 2017

MD History: Convert all usages of .bind(this) to use ES6 arrow function.

Bug: 747596
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I84a6c88c1221d105ae5c21f041b5dfc27db1b08e
Reviewed-on: https://chromium-review.googlesource.com/585843
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489781}
[modify] https://crrev.com/9ade00cae06ef85328db519f6e4899088d10c1be/.eslintrc.js
[modify] https://crrev.com/9ade00cae06ef85328db519f6e4899088d10c1be/chrome/browser/resources/md_history/app.js
[modify] https://crrev.com/9ade00cae06ef85328db519f6e4899088d10c1be/chrome/browser/resources/md_history/history_item.js
[modify] https://crrev.com/9ade00cae06ef85328db519f6e4899088d10c1be/chrome/browser/resources/md_history/history_list.js
[modify] https://crrev.com/9ade00cae06ef85328db519f6e4899088d10c1be/chrome/browser/resources/md_history/synced_device_manager.js
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1bfdc156f8f321b3594f8a99b6f68c5375ea5cf

commit a1bfdc156f8f321b3594f8a99b6f68c5375ea5cf
Author: dpapad <dpapad@chromium.org>
Date: Thu Jul 27 23:37:18 2017

MD Extensions: Convert all usages of .bind(this) to use ES6 arrow function.

Bug: 747596
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iec0f19f471edbf80309071baacd96d7bf8351ef1
Reviewed-on: https://chromium-review.googlesource.com/585846
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490113}
[modify] https://crrev.com/a1bfdc156f8f321b3594f8a99b6f68c5375ea5cf/.eslintrc.js
[modify] https://crrev.com/a1bfdc156f8f321b3594f8a99b6f68c5375ea5cf/chrome/browser/resources/md_extensions/drop_overlay.js
[modify] https://crrev.com/a1bfdc156f8f321b3594f8a99b6f68c5375ea5cf/chrome/browser/resources/md_extensions/error_page.js
[modify] https://crrev.com/a1bfdc156f8f321b3594f8a99b6f68c5375ea5cf/chrome/browser/resources/md_extensions/manager.js
[modify] https://crrev.com/a1bfdc156f8f321b3594f8a99b6f68c5375ea5cf/chrome/browser/resources/md_extensions/options_dialog.js
[modify] https://crrev.com/a1bfdc156f8f321b3594f8a99b6f68c5375ea5cf/chrome/browser/resources/md_extensions/pack_dialog.js
[modify] https://crrev.com/a1bfdc156f8f321b3594f8a99b6f68c5375ea5cf/chrome/browser/resources/md_extensions/service.js
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f536c4c802e3c1ea288ad0953cf594b95f3e287a

commit f536c4c802e3c1ea288ad0953cf594b95f3e287a
Author: dpapad <dpapad@chromium.org>
Date: Wed Aug 02 22:44:25 2017

MD user-manager: Convert all usages of .bind(this) to use ES6 arrow function.

Bug: 747596
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I28e93a4b0be176718df12048fed66e4d696bd4de
Reviewed-on: https://chromium-review.googlesource.com/597111
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491535}
[modify] https://crrev.com/f536c4c802e3c1ea288ad0953cf594b95f3e287a/chrome/browser/resources/md_user_manager/control_bar.js
[modify] https://crrev.com/f536c4c802e3c1ea288ad0953cf594b95f3e287a/chrome/browser/resources/md_user_manager/create_profile.js
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9afc2809d2d5b1b0828798384bf920edd492575d

commit 9afc2809d2d5b1b0828798384bf920edd492575d
Author: dpapad <dpapad@chromium.org>
Date: Wed Aug 09 22:01:43 2017

PDF viewer: Convert all usages of .bind(this) to use ES6 arrow function.


Bug: 747596
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7e9a23f01c6519a84e8637eb33b92b46e9d57587
Reviewed-on: https://chromium-review.googlesource.com/606744
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493157}
[modify] https://crrev.com/9afc2809d2d5b1b0828798384bf920edd492575d/chrome/browser/resources/pdf/browser_api.js
[modify] https://crrev.com/9afc2809d2d5b1b0828798384bf920edd492575d/chrome/browser/resources/pdf/elements/viewer-page-indicator/viewer-page-indicator.js
[modify] https://crrev.com/9afc2809d2d5b1b0828798384bf920edd492575d/chrome/browser/resources/pdf/elements/viewer-toolbar-dropdown/viewer-toolbar-dropdown.js
[modify] https://crrev.com/9afc2809d2d5b1b0828798384bf920edd492575d/chrome/browser/resources/pdf/pdf.js
[modify] https://crrev.com/9afc2809d2d5b1b0828798384bf920edd492575d/chrome/browser/resources/pdf/pdf_scripting_api.js
[modify] https://crrev.com/9afc2809d2d5b1b0828798384bf920edd492575d/chrome/browser/resources/pdf/toolbar_manager.js
[modify] https://crrev.com/9afc2809d2d5b1b0828798384bf920edd492575d/chrome/browser/resources/pdf/viewport.js
[modify] https://crrev.com/9afc2809d2d5b1b0828798384bf920edd492575d/chrome/browser/resources/pdf/zoom_manager.js
Project Member

Comment 8 by sheriffbot@chromium.org, Aug 10

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
►

Sign in to add a comment