New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 747594 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit 15 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug

Blocking:
issue 747432



Sign in to add a comment

"Clear text" button in Bookmark text field is not accessible

Project Member Reported by liaoyuke@chromium.org, Jul 21 2017

Issue description

What steps will reproduce the problem?
(1) Add at least one page to bookmark
(2) Enable voice over
(3) Go to the page that edits any bookmark
(4) click on the "Name" cell.

What is the expected result?
The "Clear text" button (the "X") should be accessible.

What happens instead?
It's not accessible.
 
Labels: -Pri-3 Pri-1
Bouncing to P1 as this is blocking running Bookmarks EG tests on Xcode9/iOS 11.

Comment 2 by sczs@chromium.org, Jul 22 2017

Cc: -sczs@chromium.org
Owner: sczs@chromium.org
Status: Assigned (was: Available)
Labels: ReleaseBlock-Beta Proj-iOS11 M-62
Labels: -ReleaseBlock-Beta -Proj-iOS11
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e8cac2a96b0553324b2860479084fe84dd0528e

commit 4e8cac2a96b0553324b2860479084fe84dd0528e
Author: sczs <sczs@chromium.org>
Date: Thu Jul 27 17:26:05 2017

[ios] Fix Bookmark text field edit item accessibility

The "X" clear text button was previously not accessible via voice-over, they could only access the
whole cell, because of this users couldn't really tap the X button when using voice over.
Now they can select the Textfield and clear text button separately. 

This CL makes the textField accessible instead of the Cell, as Apple recommends:
https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/iPhoneAccessibility/Making_Application_Accessible/Making_Application_Accessible.html#//apple_ref/doc/uid/TP40008785-CH102-SW3
(We might have to edit other cells in order to make their Subviews accessible) 

Screenshot Before: 
https://drive.google.com/open?id=0Byo6-Nuda2jgcjVlZTNrZmI2cGc

Screenshot After:
https://drive.google.com/open?id=0Byo6-Nuda2jgVzZMYTctTmM1Vnc

Screenshot from Apple Settings (Device):
https://drive.google.com/open?id=0Byo6-Nuda2jgUXZHRGlSLTFUV28

Bug:  747594 
Change-Id: I70394c062227a33f7b7a74228675c2e74385faca
Reviewed-on: https://chromium-review.googlesource.com/583533
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490009}
[modify] https://crrev.com/4e8cac2a96b0553324b2860479084fe84dd0528e/ios/chrome/browser/ui/bookmarks/cells/bookmark_text_field_item.mm

Checked on the chrome canary version 62.0.3170.0, on iPad Air and iPhone 6 plus with iOS 11 beta, iPad Air and iPhone 6s plus with iOS with iOS 10.3.3.  "x" is accessible and read with voice over : on.

Comment 7 by sczs@chromium.org, Aug 1 2017

Status: Verified (was: Assigned)

Sign in to add a comment