TouchInjectorWin does not use the right coordinate |
|||
Issue descriptionWhen the secondary monitor is at the left of the primary monitor, the coordinate of system starts from a negative value. But in every client, we are always sending the touch point info in pixel coordinate, i.e. the top-left monitor starts from (0, 0). But POINTER_INFO.ptPixelLocation is in the coordinate of system. So we inject the touch event in the wrong location. This impacts all the clients AFAICT.
,
Jul 21 2017
I believe the priority of this issue should be raised to 1. P.S. I have not tried this on other platforms. They may have similar issue.
,
Jul 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ec344cb06ebf5cc8ecd9f60a98a33374afc9e8f commit 7ec344cb06ebf5cc8ecd9f60a98a33374afc9e8f Author: Zijie He <zijiehe@google.com> Date: Sun Jul 23 21:47:47 2017 [Chromoting] Update comments of MouseEvent and TouchEventPoint The coordinates of MouseEvent and TouchEventPoint are not clearly documented in the protobuf. So the TouchInjectorWin wrongly uses the TouchEventPoint in system coordinates instead of host pixel coordinates. Bug: 747591 Change-Id: I271e00bce192916a426a5e1eb8b79f6ae4883e76 Reviewed-on: https://chromium-review.googlesource.com/581949 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Zijie He <zijiehe@chromium.org> Cr-Commit-Position: refs/heads/master@{#488896} [modify] https://crrev.com/7ec344cb06ebf5cc8ecd9f60a98a33374afc9e8f/remoting/proto/event.proto
,
Jul 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/813dbe329fabf45d9decf4bef90b8909237327cc commit 813dbe329fabf45d9decf4bef90b8909237327cc Author: Zijie He <zijiehe@google.com> Date: Mon Jul 24 18:55:11 2017 [Chromoting] Use right coordinate in TouchInjectorWin Windows host used to use wrong coordinate to process touch input event: Windows API uses system coordinate, but TouchEventPointer is in pixel coordinate. Unfortunately, this break cannot be covered by a test case: it depends on the a specific display configuration (secondary monitor is on the left side of primary monitor). I believe we cannot support it on try bot. Bug: 747591 Change-Id: I5a76db1f7cb37315159c191ce388a1753ef32b46 Reviewed-on: https://chromium-review.googlesource.com/581953 Commit-Queue: Zijie He <zijiehe@chromium.org> Reviewed-by: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#489037} [modify] https://crrev.com/813dbe329fabf45d9decf4bef90b8909237327cc/remoting/host/touch_injector_win.cc
,
Jul 24 2017
,
Jul 25 2017
Verified Fixed in 60.0.3112.78. Cursor is in correct position on all parts of the screen
,
Jul 25 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by zijiehe@chromium.org
, Jul 21 2017