Mihai, this looks similar to 657924 and this functionality has been changing a lot recently. Any ideas about what's going on?

This works fine on ToT (I just tested now). May I ask you to test again on beta or dev?

Unable to repro on Canary, so yes, seems fixed at ToT.  Just broken for all
stable users.

Does this still repro on the latest M61 Beta? Could someone with a Windows machine test?

If not, then I think we can close this out (nothing else we can do at this point).

If so, then we should find out which CL fixed this issue, and make sure it gets merged back to 61 before the next beta cut.

Taking on the bug as I am the only eng with a windows machine in the sign-in team. I will only be able to test beta next week though as I am OOO from Friday to Tuesday.

Mihai - please test this ASAP. If we want to try to get this into 61 (if it's not already there), it should happen soon.

I can reproduce this issue on Chrome Canary - the sync settings page is not presented after I click on "Settings" from the sync confirmation screen. We'll need to investigate it.

I am raising its priority and marking it as Release Block Stable for M62.

Can you also repro on M61? If so, we should update the milestone to M61. We need to fix this ASAP.

Could you also check what value gets emitted in Sync.InitialState when you follow these repro steps and get into a state where sync is off and says it's been "stopped via Google Dashboard" in settings? Looking at this timeline (https://uma.googleplex.com/p/chrome/timeline_v2/?sid=cd040303916c392867f0409bca8a8e38), it doesn't seem like the number of users in this state spiked in M59 or M60, which is good. But it's possible that we're not properly recording that histogram for users that fall into this state via this bug.

So, I wasn't able to reproduce this on my personal Win10 machine on current M60 stable, M61 Beta, or M62 Canary. It's also worth noting that on M61/M62, there's no checkbox, it's a "Settings" link (as Mihai described in c#8).

Mihai - can you confirm whether this affects all versions of Windows or only pre-Win10? Wonder why I wasn't able to repro it (but it's encouraging that it's not happening every time and the UMA data makes it seem like we aren't seeing a spike of users in this state).

I hit this issue on Chrome Canary on my Windows 10 corp desktop machine. I have a crash  on-going, but I should get to this bug once I fix the crash.

I managed to find the issue of the bug (based on the repro case, I am very sure this exists on 61 as well):
1. The user needs to sign in with a managed account in a profile that was never signed in previously
2. On the "Link your Chromium data" dialog, select to create a new profile.
3. The newly created profile displays the sync confirmation dialog on top of the welcome page.
4. When the user selects "Settings" link (or ticks the checkbox) we hit the bug. 

Explanation: There is a race condition here:
1. The sign-in code asks opens sync settings by navigating to chrome://settings/syncSetup
2. The welcome tab, navigates to NTP as sign-in is successful.

The navigation done from the welcome page, overrides the one from sign-in code and this is why the user ends up on the NTP.

The solution consists in changing the welcome tab to navigate to the NTP inside itself (avoid navigating to the NTP on the current tab).

Here are the videos with this change in https://chromium-review.googlesource.com/618868: https://drive.google.com/corp/drive/u/1/folders/0Bw1MJ8m7U5kbR3R4ZVpRNGRrNzg

Chatted with Mihai offline.

- Don't need to merge this to 61, since it only affects users that sign in with a managed account in an existing profile and hit the button to create a new profile
- Shouldn't be opening the welcome page in the newly created profile anyways (Mihai will look into that as a follow-up)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a23a3780851d942b72b679165d9545230260b167

commit a23a3780851d942b72b679165d9545230260b167
Author: Mihai Sardarescu <msarda@chromium.org>
Date: Thu Aug 17 17:59:45 2017

On sign-in, welcome page should open the NTP in the same tab.

This CL fixes the following race condition that happen on a successful sign-in
when the chrome://welcome page is displayed:
1. The sign-in code opens sync settings by navigating to chrome://settings/syncSetup
2. The welcome tab, navigates to NTP as sign-in is successful.

This CL changes the welcome tab to navigate to the NTP in the same tab
(avoids navigating to the NTP on the current active tab).

Here are the videos with this change:
https://drive.google.com/corp/drive/u/1/folders/0Bw1MJ8m7U5kbR3R4ZVpRNGRrNzg

Bug:  747575 
Change-Id: I9eef3e514b63179804b7352187c3b7633acefb68
Reviewed-on: https://chromium-review.googlesource.com/618868
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495217}
[modify] https://crrev.com/a23a3780851d942b72b679165d9545230260b167/chrome/browser/ui/webui/welcome_handler.cc

Tested the issue using #62.0.3192.0 on Win 10 and the fix is working as expected. Observed, able to navigate to settings page and on clicking Okay got it, welcome tab is navigating to NTP.

Please find the screen cast for the same. Hence adding verified labels.

Thanks!!

Deleted: Aug 21 2017 2_10 PM.webm 5.8 MB

	Aug 21 2017 2_10 PM.webm 5.8 MB View Download

The repro steps shown in the test video aren't quite correct. Here are the repro steps you should be using:

- Completely fresh Chrome install (remove user data dir)
- Launch Chrome, do a few navigations
- Tap on the user menu, tap on "Sign in to Chrome"
- Sign in to Chrome with a *managed* account (e.g. @google.com)
- In the "enterprise confirmation dialogue" that appears, click "Create new profile"
- In the new profile that gets created, tap on the "Settings" link in the confirmation dialogue that appears
- Confirm that sync settings opens in a new tab, and that the first tab (with chrome://welcome) navigates to the NTP

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/149dd272ba1a3beb0b631e87eb74422a97ca40cb

commit 149dd272ba1a3beb0b631e87eb74422a97ca40cb
Author: Mihai Sardarescu <msarda@chromium.org>
Date: Thu Aug 24 13:42:23 2017

Do not show welcome page when sign-in is in progress.

This CL avoids displaying the chrome://welcome page when a sign-in is
in progress. This may happen when the user choosed to use a new profile
when going throught the Chrome sign-in flow.

Bug:  747575 
Change-Id: I576ef6189c0d054ef3c9aa16286b96744ae8c534
Reviewed-on: https://chromium-review.googlesource.com/620752
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497027}
[modify] https://crrev.com/149dd272ba1a3beb0b631e87eb74422a97ca40cb/chrome/browser/ui/startup/startup_tab_provider.cc
[modify] https://crrev.com/149dd272ba1a3beb0b631e87eb74422a97ca40cb/chrome/browser/ui/startup/startup_tab_provider.h
[modify] https://crrev.com/149dd272ba1a3beb0b631e87eb74422a97ca40cb/chrome/browser/ui/startup/startup_tab_provider_unittest.cc