New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 747571 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 747563


Participants' hotlists:
Downloads-Foreground-Service


Sign in to add a comment

[Downloads Foreground Service] Create separate class for keep alive foreground service

Project Member Reported by jming@chromium.org, Jul 21 2017

Issue description

Create DownloadServiceManager that takes start/stop commands for a foreground service.
 

Comment 1 by jming@chromium.org, Jul 21 2017

Blocking: 747563

Comment 2 by jming@chromium.org, Jul 27 2017

Summary: [Downloads Foreground Service] Create separate class for keep alive foreground service (was: [Downloads Foreground Service] Refactor foreground service logic)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc46b05b55683ecf63128f6062811093fcf2ad79

commit cc46b05b55683ecf63128f6062811093fcf2ad79
Author: Joy Ming <jming@chromium.org>
Date: Fri Aug 11 00:41:59 2017

Create a class to start and stop the foreground service for downloads.

This is one of the steps in the refactor to make downloads a foreground
service. This step creates a separate class that manages starting and
stoping the foreground service. Currently, this is not being used by
any of the classes, but will eventually be integrated to be called
every time there is a change in a download (ie. a download has been
started, paused, resumed, completed, canceled, or deleted).

Bug:  747571 , 747563 
Change-Id: Ie9a7ee2950481b5c403e09ede535f763ef44d653
Reviewed-on: https://chromium-review.googlesource.com/572147
Commit-Queue: Joy Ming <jming@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493619}
[add] https://crrev.com/cc46b05b55683ecf63128f6062811093fcf2ad79/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadForegroundService.java
[add] https://crrev.com/cc46b05b55683ecf63128f6062811093fcf2ad79/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadForegroundServiceManager.java
[modify] https://crrev.com/cc46b05b55683ecf63128f6062811093fcf2ad79/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java
[modify] https://crrev.com/cc46b05b55683ecf63128f6062811093fcf2ad79/chrome/android/java_sources.gni
[add] https://crrev.com/cc46b05b55683ecf63128f6062811093fcf2ad79/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadForegroundServiceManagerTest.java

Comment 4 by jming@chromium.org, Aug 11 2017

Status: Fixed (was: Assigned)

Sign in to add a comment