New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 747567 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 747563


Participants' hotlists:
Downloads-Foreground-Service


Sign in to add a comment

[Downloads Foreground Service] Make non-progress related updates from native->Java not batched

Project Member Reported by jming@chromium.org, Jul 21 2017

Issue description

Refactor native to Java updates through DownloadManager / OfflinePagesBridge so that the alerts are immediate for state changes and batches for progress updates.
 

Comment 1 by jming@chromium.org, Jul 21 2017

Blocking: 747563

Comment 2 by jming@chromium.org, Jul 21 2017

Summary: [Downloads Foreground Service] Refactor download status (native -> Java) (was: [Downloads Foreground Service] Refactor notification interaction (native -> Java))

Comment 3 by jming@chromium.org, Jul 27 2017

Summary: [Downloads Foreground Service] Refactor out SystemDownloadNotifier (was: [Downloads Foreground Service] Refactor download status (native -> Java))
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/399f968b1df1818493aa5b8b2031764a8ebccd4f

commit 399f968b1df1818493aa5b8b2031764a8ebccd4f
Author: Joy Ming <jming@chromium.org>
Date: Fri Jul 28 17:34:22 2017

Refactor non-progress download updates to not be batched.

Before this CL, all updates from native to Java (DownloadManagerService
to SystemDownloadNotifier) were batched and sent every second. However,
for the refactor that makes downloads a foreground service, immediate
updates are required for the cases that are not related to progress, or
where a download is paused, cancelled, completed, or interrupted. This
CL refactors the DownloadManagerService so that the updates are
immediate except for those related to download progress, which continue
to be batched.

Bug:  747567 , 747563 
Change-Id: I687fd42d14be8cda3b4ea4cd287220037e15b7a0
Reviewed-on: https://chromium-review.googlesource.com/585776
Commit-Queue: Joy Ming <jming@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490445}
[modify] https://crrev.com/399f968b1df1818493aa5b8b2031764a8ebccd4f/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
[modify] https://crrev.com/399f968b1df1818493aa5b8b2031764a8ebccd4f/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java

Comment 5 by jming@chromium.org, Jul 28 2017

Status: Fixed (was: Assigned)
Summary: [Downloads Foreground Service] Make non-progress related updates from native->Java not batched (was: [Downloads Foreground Service] Refactor out SystemDownloadNotifier)

Sign in to add a comment