New issue
Advanced search Search tips

Issue 747557 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Task



Sign in to add a comment

Remove InstallVerifier.ModuleMatch histogram and all related code

Project Member Reported by robertshield@chromium.org, Jul 21 2017

Issue description

Looks like it has done its time and is now somewhat redundant. We should clean this up.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9cff12b94e2eb935595e7705ecb40dbe0f977f5

commit b9cff12b94e2eb935595e7705ecb40dbe0f977f5
Author: Gabriel Charette <gab@chromium.org>
Date: Fri Jul 21 23:38:51 2017

Post VerifyInstallation() to TaskScheduler instead of BlockingPool.

TODO(robertshield): remove this call and everything that falls off of it.

R=robertshield@chromium.org, thakis@chromium.org

Bug:  667892 , 747557
Change-Id: I1ddad1db01f18db6b7121945c1313933c9e2e16b
Reviewed-on: https://chromium-review.googlesource.com/581634
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488797}
[modify] https://crrev.com/b9cff12b94e2eb935595e7705ecb40dbe0f977f5/chrome/browser/chrome_browser_main_win.cc

Project Member

Comment 2 by sheriffbot@chromium.org, Jul 23

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: proberge@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46729f08956dcda4a85c728815e6776ad5bf874f

commit 46729f08956dcda4a85c728815e6776ad5bf874f
Author: Robert Shield <robertshield@chromium.org>
Date: Fri Aug 03 22:05:05 2018

Remove much of the no-longer-used module verifier code.

Bug: 747557
Change-Id: I2997faa2de1cb384287afc5d4eb23c352b8ea7a5
Reviewed-on: https://chromium-review.googlesource.com/1157864
Reviewed-by: Chris Sharp <csharp@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580665}
[modify] https://crrev.com/46729f08956dcda4a85c728815e6776ad5bf874f/chrome/browser/BUILD.gn
[modify] https://crrev.com/46729f08956dcda4a85c728815e6776ad5bf874f/chrome/browser/chrome_browser_main_win.cc
[delete] https://crrev.com/4d7aa7ab92d8505a6ca8e7ae6f147dd36f8d10e4/chrome/browser/install_verification/win/install_verification.cc
[delete] https://crrev.com/4d7aa7ab92d8505a6ca8e7ae6f147dd36f8d10e4/chrome/browser/install_verification/win/install_verification.h
[delete] https://crrev.com/4d7aa7ab92d8505a6ca8e7ae6f147dd36f8d10e4/chrome/browser/install_verification/win/loaded_module_verification.cc
[delete] https://crrev.com/4d7aa7ab92d8505a6ca8e7ae6f147dd36f8d10e4/chrome/browser/install_verification/win/loaded_module_verification.h
[delete] https://crrev.com/4d7aa7ab92d8505a6ca8e7ae6f147dd36f8d10e4/chrome/browser/install_verification/win/loaded_module_verification_unittest.cc
[delete] https://crrev.com/4d7aa7ab92d8505a6ca8e7ae6f147dd36f8d10e4/chrome/browser/install_verification/win/module_ids.cc
[delete] https://crrev.com/4d7aa7ab92d8505a6ca8e7ae6f147dd36f8d10e4/chrome/browser/install_verification/win/module_ids.h
[delete] https://crrev.com/4d7aa7ab92d8505a6ca8e7ae6f147dd36f8d10e4/chrome/browser/install_verification/win/module_ids_unittest.cc
[modify] https://crrev.com/46729f08956dcda4a85c728815e6776ad5bf874f/chrome/browser/install_verification/win/module_verification_common.cc
[modify] https://crrev.com/46729f08956dcda4a85c728815e6776ad5bf874f/chrome/browser/install_verification/win/module_verification_common.h
[modify] https://crrev.com/46729f08956dcda4a85c728815e6776ad5bf874f/chrome/test/BUILD.gn

Sign in to add a comment