New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 747552 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[MD settings] remove class entries made redundant by <slot> in cr-dialog

Project Member Reported by dschuyler@chromium.org, Jul 21 2017

Issue description

cr-dialog was converted from <content> to <slot> and the classes for content selection were left in place as an interim step. This is a follow-up issue to remove the old class entries.
 
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81c6fb8cfb6514216cac0107767e35884573a59b

commit 81c6fb8cfb6514216cac0107767e35884573a59b
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Tue Aug 01 20:19:16 2017

[MD settings] remove old cr-dialog classes

This CL removes old class="..." entries for cr-dialog .title, .body,
.button-container, and .footer. The CSS that used those classes have
changed to [slot=...] instead.

Bug:  747552 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ice802ab9cd238e24c8e66809e5d7907141a0b339
Reviewed-on: https://chromium-review.googlesource.com/584001
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491095}
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/chromeos/emulator/audio_settings.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/chromeos/emulator/bluetooth_settings.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/chromeos/login/offline_gaia.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/chromeos/login/saml_confirm_password.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/md_bookmarks/command_manager.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/md_bookmarks/command_manager.js
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/md_bookmarks/edit_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/md_extensions/load_error.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/md_extensions/options_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/md_extensions/pack_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/md_history/history_list.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/md_user_manager/error_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/md_user_manager/import_supervised_user.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/pdf/elements/viewer-error-screen/viewer-error-screen.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/pdf/elements/viewer-password-screen/viewer-password-screen.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/about_page/channel_switcher_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/about_page/update_warning_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/android_apps_page/android_apps_subpage.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/certificate_manager_page/certificate_delete_confirmation_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/certificate_manager_page/certificate_password_decryption_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/certificate_manager_page/certificate_password_encryption_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/certificate_manager_page/certificates_error_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/clear_browsing_data_dialog/history_deletion_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/device_page/display_overscan_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/device_page/drive_cache_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/internet_page/network_proxy.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/internet_page/network_siminfo.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/internet_page/tether_connection_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/languages_page/add_languages_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/on_startup_page/startup_url_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/people_page/import_data_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/people_page/password_prompt_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/people_page/setup_fingerprint_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/people_page/setup_pin_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/people_page/users_add_user_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/reset_page/powerwash_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/reset_page/reset_profile_banner.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/site_settings/add_site_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/site_settings/edit_exception_dialog.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/site_settings/site_data.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/browser/resources/settings/site_settings/site_details.html
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/test/data/webui/settings/certificate_manager_page_test.js
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/test/data/webui/settings/easy_unlock_browsertest_chromeos.js
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/test/data/webui/settings/reset_page_test.js
[modify] https://crrev.com/81c6fb8cfb6514216cac0107767e35884573a59b/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js

Status: Fixed (was: Started)

Sign in to add a comment