Issue metadata
Sign in to add a comment
|
fast/clip/css-clip-filter-order.html.html failing with spv2 |
||||||||||||||||||||||
Issue descriptionThis test is now failing on the svp2 trybot: https://storage.googleapis.com/chromium-layout-test-archives/linux_layout_tests_slimming_paint_v2/5628/layout-test-results/results.html Could this be caused by: [SPv2] Apply non-composited effects in group https://chromium.googlesource.com/chromium/src/+/f62169afa7f911143f50059c52ac0d9442284e96
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21cfe2d238708828554124c8a6f98895e3f39577 commit 21cfe2d238708828554124c8a6f98895e3f39577 Author: Tien-Ren Chen <trchen@chromium.org> Date: Fri Jul 28 01:58:10 2017 [Blink] Restore CSS clip and filter application order There was a previous bug [1] that prevented overflow clip from being applied in the presence of a filter on the same element. The CL [2] fixed the overflow/filter interaction but inadvertently changed clip/filter interaction: Buggy behavior prior to [2]: output <-- clip/clip-path/mask <-- filter <-- children Buggy behavior after [2]: output <-- clip/clip-path/mask <-- filter <-- clip <-- overflow <-- children This CL restores clip/filter interaction so that they will be applied in the following order: output <-- clip/clip-path/mask <-- filter <-- overflow <-- children [1] https://crbug.com/734116 [2] https://chromium-review.googlesource.com/c/567520 BUG= 734116 , 747511 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I1b2e1441de89fd486f50bba10c8a20108d557dc2 Reviewed-on: https://chromium-review.googlesource.com/588137 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#490201} [modify] https://crrev.com/21cfe2d238708828554124c8a6f98895e3f39577/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [modify] https://crrev.com/21cfe2d238708828554124c8a6f98895e3f39577/third_party/WebKit/LayoutTests/fast/clip/css-clip-filter-order-expected.html [add] https://crrev.com/21cfe2d238708828554124c8a6f98895e3f39577/third_party/WebKit/LayoutTests/paint/filters/clip-filter-overflow-clip-expected.html [add] https://crrev.com/21cfe2d238708828554124c8a6f98895e3f39577/third_party/WebKit/LayoutTests/paint/filters/clip-filter-overflow-clip.html [add] https://crrev.com/21cfe2d238708828554124c8a6f98895e3f39577/third_party/WebKit/LayoutTests/paint/filters/clip-under-filter-2-expected.html [add] https://crrev.com/21cfe2d238708828554124c8a6f98895e3f39577/third_party/WebKit/LayoutTests/paint/filters/clip-under-filter-2.html [modify] https://crrev.com/21cfe2d238708828554124c8a6f98895e3f39577/third_party/WebKit/LayoutTests/paint/filters/clip-under-filter-expected.png [modify] https://crrev.com/21cfe2d238708828554124c8a6f98895e3f39577/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp [modify] https://crrev.com/21cfe2d238708828554124c8a6f98895e3f39577/third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp [modify] https://crrev.com/21cfe2d238708828554124c8a6f98895e3f39577/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
,
Jul 28 2017
Please merge this fix to M61 also.
,
Jul 28 2017
Pls apply appropriate OSs. Thank you.
,
Jul 28 2017
,
Jul 29 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 30 2017
Pls merge you change to M61 branch 3163 before 3:00 PM PT on Monday so we can take it in for next week last M61 Dev release. Thank you.
,
Jul 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f6679fa0478c177d446ec6679e3135f5eaef352 commit 9f6679fa0478c177d446ec6679e3135f5eaef352 Author: Tien-Ren Chen <trchen@chromium.org> Date: Mon Jul 31 22:03:46 2017 [Blink] Restore CSS clip and filter application order There was a previous bug [1] that prevented overflow clip from being applied in the presence of a filter on the same element. The CL [2] fixed the overflow/filter interaction but inadvertently changed clip/filter interaction: Buggy behavior prior to [2]: output <-- clip/clip-path/mask <-- filter <-- children Buggy behavior after [2]: output <-- clip/clip-path/mask <-- filter <-- clip <-- overflow <-- children This CL restores clip/filter interaction so that they will be applied in the following order: output <-- clip/clip-path/mask <-- filter <-- overflow <-- children [1] https://crbug.com/734116 [2] https://chromium-review.googlesource.com/c/567520 BUG= 734116 , 747511 TBR=trchen@chromium.org (cherry picked from commit 21cfe2d238708828554124c8a6f98895e3f39577) Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I1b2e1441de89fd486f50bba10c8a20108d557dc2 Reviewed-on: https://chromium-review.googlesource.com/588137 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#490201} Reviewed-on: https://chromium-review.googlesource.com/595107 Reviewed-by: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#189} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/9f6679fa0478c177d446ec6679e3135f5eaef352/third_party/WebKit/LayoutTests/fast/clip/css-clip-filter-order-expected.html [add] https://crrev.com/9f6679fa0478c177d446ec6679e3135f5eaef352/third_party/WebKit/LayoutTests/paint/filters/clip-filter-overflow-clip-expected.html [add] https://crrev.com/9f6679fa0478c177d446ec6679e3135f5eaef352/third_party/WebKit/LayoutTests/paint/filters/clip-filter-overflow-clip.html [add] https://crrev.com/9f6679fa0478c177d446ec6679e3135f5eaef352/third_party/WebKit/LayoutTests/paint/filters/clip-under-filter-2-expected.html [add] https://crrev.com/9f6679fa0478c177d446ec6679e3135f5eaef352/third_party/WebKit/LayoutTests/paint/filters/clip-under-filter-2.html [modify] https://crrev.com/9f6679fa0478c177d446ec6679e3135f5eaef352/third_party/WebKit/LayoutTests/paint/filters/clip-under-filter-expected.png [modify] https://crrev.com/9f6679fa0478c177d446ec6679e3135f5eaef352/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp [modify] https://crrev.com/9f6679fa0478c177d446ec6679e3135f5eaef352/third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp [modify] https://crrev.com/9f6679fa0478c177d446ec6679e3135f5eaef352/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
,
Aug 1 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by trchen@chromium.org
, Jul 21 2017Labels: -Pri-3 Pri-1
Owner: trchen@chromium.org
Status: Started (was: Assigned)