New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 747508 link

Starred by 2 users
Status: Fixed
Owner:
caseq@chromium.org
Closed: Sep 2017
Cc:
█ allada@chromium.org
pfeldman@chromium.org
dgozman@chromium.org
█ eostroukhov@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: support reading Blobs via protocol

Project Member Reported by caseq@chromium.org, Jul 21 2017 
There's a common need in several DevTools agents to return large objects, some of them already available as Blobs. It appears to be practical to support retrieval of Blobs as streams in the IO domain, so the retrieval logic can be reused across different agents and front-end modules.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da6245e7c4b489a4dc73be76fcb54483add1eb2b

commit da6245e7c4b489a4dc73be76fcb54483add1eb2b
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Fri Jul 21 21:15:06 2017

DevTools: add IO.resolveBlob

This adds a protocol method to obtain the UUID of a Blob based on a
remote object id.
The intended usage is in conjunction with IO.read that would be able
to read the contents of a Blob on the browser side.

Bug:  747508 

Change-Id: I18b7395833265665d80493f611888285f9730458
Reviewed-on: https://chromium-review.googlesource.com/580353
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488751}
[modify] https://crrev.com/da6245e7c4b489a4dc73be76fcb54483add1eb2b/content/browser/devtools/protocol_config.json
[add] https://crrev.com/da6245e7c4b489a4dc73be76fcb54483add1eb2b/third_party/WebKit/LayoutTests/inspector-protocol/io/blob-uuid-expected.txt
[add] https://crrev.com/da6245e7c4b489a4dc73be76fcb54483add1eb2b/third_party/WebKit/LayoutTests/inspector-protocol/io/blob-uuid.js
[modify] https://crrev.com/da6245e7c4b489a4dc73be76fcb54483add1eb2b/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/da6245e7c4b489a4dc73be76fcb54483add1eb2b/third_party/WebKit/Source/core/inspector/BUILD.gn
[add] https://crrev.com/da6245e7c4b489a4dc73be76fcb54483add1eb2b/third_party/WebKit/Source/core/inspector/InspectorIOAgent.cpp
[add] https://crrev.com/da6245e7c4b489a4dc73be76fcb54483add1eb2b/third_party/WebKit/Source/core/inspector/InspectorIOAgent.h
[modify] https://crrev.com/da6245e7c4b489a4dc73be76fcb54483add1eb2b/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/da6245e7c4b489a4dc73be76fcb54483add1eb2b/third_party/WebKit/Source/core/inspector/inspector_protocol_config.json
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2052514c9d3b7622da7cc5bd87fcd607339b8004

commit 2052514c9d3b7622da7cc5bd87fcd607339b8004
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Sat Jul 22 03:10:58 2017

DevTools: support reading Blobs in IO handler

This adds support for reading Blobs by specifying a handle of blob:<uuid>
to IO.read.

Bug:  747508 
Change-Id: Ic01c40044d1afc0b16027d4be5760bf1502ab513
Reviewed-on: https://chromium-review.googlesource.com/580632
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488847}
[modify] https://crrev.com/2052514c9d3b7622da7cc5bd87fcd607339b8004/content/browser/devtools/devtools_io_context.cc
[modify] https://crrev.com/2052514c9d3b7622da7cc5bd87fcd607339b8004/content/browser/devtools/devtools_io_context.h
[modify] https://crrev.com/2052514c9d3b7622da7cc5bd87fcd607339b8004/content/browser/devtools/protocol/io_handler.cc
[modify] https://crrev.com/2052514c9d3b7622da7cc5bd87fcd607339b8004/content/browser/devtools/protocol/io_handler.h
[modify] https://crrev.com/2052514c9d3b7622da7cc5bd87fcd607339b8004/content/browser/devtools/protocol/tracing_handler.cc
[add] https://crrev.com/2052514c9d3b7622da7cc5bd87fcd607339b8004/third_party/WebKit/LayoutTests/inspector-protocol/io/blob-streams-expected.txt
[add] https://crrev.com/2052514c9d3b7622da7cc5bd87fcd607339b8004/third_party/WebKit/LayoutTests/inspector-protocol/io/blob-streams.js
[modify] https://crrev.com/2052514c9d3b7622da7cc5bd87fcd607339b8004/third_party/WebKit/LayoutTests/inspector-protocol/io/blob-uuid-expected.txt
[modify] https://crrev.com/2052514c9d3b7622da7cc5bd87fcd607339b8004/third_party/WebKit/LayoutTests/inspector-protocol/io/blob-uuid.js
[modify] https://crrev.com/2052514c9d3b7622da7cc5bd87fcd607339b8004/third_party/WebKit/Source/core/inspector/InspectorIOAgent.cpp
[modify] https://crrev.com/2052514c9d3b7622da7cc5bd87fcd607339b8004/third_party/WebKit/Source/core/inspector/InspectorIOAgent.h
[modify] https://crrev.com/2052514c9d3b7622da7cc5bd87fcd607339b8004/third_party/WebKit/Source/core/inspector/browser_protocol.json

Comment 3 by caseq@chromium.org, Sep 22 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment