New issue
Advanced search Search tips

Issue 747502 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

rebaseline after new blur code

Reported by reed@chromium.org, Jul 21 2017

Issue description

Skia now detects degenerate kernels and draws (faster) unblurred.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79b662ab38a9fe9e7a34c7781aa19c2b1bd3268e

commit 79b662ab38a9fe9e7a34c7781aa19c2b1bd3268e
Author: Mike Reed <reed@google.com>
Date: Fri Jul 21 20:01:12 2017

need to rebaseline after skia blur change

NOTRY=True

Bug:  747502 
Change-Id: I0344ca15013427f6f9f5dcb5f04f0faeb65bcc30
Reviewed-on: https://chromium-review.googlesource.com/581793
Commit-Queue: Mike Reed <reed@chromium.org>
Reviewed-by: Cary Clark <caryclark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488740}
[modify] https://crrev.com/79b662ab38a9fe9e7a34c7781aa19c2b1bd3268e/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c6a2f67fa5dafc2524e76ab30b9f8ac0ad7f41a

commit 7c6a2f67fa5dafc2524e76ab30b9f8ac0ad7f41a
Author: Mike Reed <reed@google.com>
Date: Sun Jul 23 00:04:17 2017

more reabselines not caught by CQ

Bug:  747502 
Change-Id: Id63eb509437c63115833944d4c62e8559e14f00c
Reviewed-on: https://chromium-review.googlesource.com/582431
Commit-Queue: Mike Reed <reed@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488875}
[modify] https://crrev.com/7c6a2f67fa5dafc2524e76ab30b9f8ac0ad7f41a/third_party/WebKit/LayoutTests/TestExpectations

Labels: BugSource-Chromium PaintTeamTriaged-20170808 Test-Layout
Owner: schenney@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d814cad5db040db6248d42ea5164bff59f709162

commit d814cad5db040db6248d42ea5164bff59f709162
Author: Stephen Chenney <schenney@chromium.org>
Date: Wed Aug 09 20:00:49 2017

Rebase shadows on RRect tests after Skia roll

TBR=fmalita@chromium.org
BUG= 747502 

Change-Id: I870db313b56f0bbf4d555da68dc83eb058ee6117
Reviewed-on: https://chromium-review.googlesource.com/606931
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493112}
[modify] https://crrev.com/d814cad5db040db6248d42ea5164bff59f709162/third_party/WebKit/LayoutTests/TestExpectations
[rename] https://crrev.com/d814cad5db040db6248d42ea5164bff59f709162/third_party/WebKit/LayoutTests/fast/borders/border-radius-with-box-shadow-expected.png
[add] https://crrev.com/d814cad5db040db6248d42ea5164bff59f709162/third_party/WebKit/LayoutTests/platform/linux/paint/roundedrects/input-with-rounded-rect-and-shadow-expected.png
[delete] https://crrev.com/a921e0d1aaa8282fe656566610af6cc97640d94c/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-radius-with-box-shadow-expected.png
[modify] https://crrev.com/d814cad5db040db6248d42ea5164bff59f709162/third_party/WebKit/LayoutTests/platform/mac/paint/roundedrects/circle-with-shadow-expected.png
[modify] https://crrev.com/d814cad5db040db6248d42ea5164bff59f709162/third_party/WebKit/LayoutTests/platform/mac/paint/roundedrects/input-with-rounded-rect-and-shadow-expected.png
[modify] https://crrev.com/d814cad5db040db6248d42ea5164bff59f709162/third_party/WebKit/LayoutTests/platform/win/paint/roundedrects/input-with-rounded-rect-and-shadow-expected.png

Status: Fixed (was: Assigned)

Sign in to add a comment