All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=747500

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=5d82d3a02d9f069f0fee54a0df3240aac7fbc9a04ac2e315a63c88e49b7759fe


Bot(s) for this bug's original alert(s):

chromium-rel-mac-retina

Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8973437108912814784

=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: mac_retina_perf_bisect
  Benchmark    : battor.trivial_pages
  Metric       : story:power_avg/TrivialGifPageSharedPageState

Revision             Result                   N
chromium@485918      10.7357 +- 0.519842      21      good
chromium@486084      10.7304 +- 0.317148      21      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=TrivialGifPageSharedPageState battor.trivial_pages

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8973437108912814784


For feedback, file a bug with component Speed>Bisection

Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8973182926192212800

Kicked off bisect with larger range.

=== Auto-CCing suspected CL author pdr@chromium.org ===

Hi pdr@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : pdr
  Commit : 2b21ab04f7543ad0a20e02a92c60400b4e8e7f68
  Date   : Thu Jul 13 01:18:19 2017
  Subject: Remove ImageQualityController

Bisect Details
  Configuration: mac_retina_perf_bisect
  Benchmark    : battor.trivial_pages
  Metric       : story:power_avg/TrivialGifPageSharedPageState
  Change       : 6.99% | 6.90013488661 -> 7.31799308137

Revision             Result                    N
chromium@485918      6.90013 +- 0.843558       9       good
chromium@486121      6.88346 +- 0.876833       14      good
chromium@486172      6.8593 +- 0.607361        9       good
chromium@486185      6.80199 +- 0.0592215      6       good
chromium@486191      6.85915 +- 0.393845       6       good
chromium@486194      6.81329 +- 0.114062       6       good
chromium@486196      6.81154 +- 0.076515       6       good
chromium@486197      7.35235 +- 0.0783865      9       bad       <--
chromium@486222      7.34039 +- 0.0982873      9       bad
chromium@486323      7.31799 +- 0.110177       9       bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=TrivialGifPageSharedPageState battor.trivial_pages

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8973182926192212800


For feedback, file a bug with component Speed>Bisection

I am not able to reproduce this on my retina mac locally (without battor) but I think I see why we regressed. This testcase has a huge animated gif and the ImageQualityController patch changed the filter quality from high to medium. This shouldn't have an effect but I suspect a bug further down the pipeline.

I'm going to put up a patch that restores the medium quality for animated images and see if that fixes the regression.

Well I put up a patch but then Vlad put up a better one that fixes the real issue: https://chromium-review.googlesource.com/c/585404.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/030df82ef689b9aff91b700c72c08e9cf9215347

commit 030df82ef689b9aff91b700c72c08e9cf9215347
Author: Vladimir Levin <vmpstr@chromium.org>
Date: Fri Aug 04 19:02:55 2017

cc: Use at most medium filter quality in gpu image decode cache.

This patch ensures that when passing a draw image to Skia, we only use
at most medium filter quality. This is on par with the software decode
cache and saves power.

R=ericrk@chromium.org, pdr@chromium.org

Bug:  747500 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Idc42c1a176ebd6394ae23324a37724b82278d9cc
Reviewed-on: https://chromium-review.googlesource.com/585404
Commit-Queue: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492091}
[modify] https://crrev.com/030df82ef689b9aff91b700c72c08e9cf9215347/cc/tiles/gpu_image_decode_cache.cc
[modify] https://crrev.com/030df82ef689b9aff91b700c72c08e9cf9215347/cc/tiles/gpu_image_decode_cache_unittest.cc
[modify] https://crrev.com/030df82ef689b9aff91b700c72c08e9cf9215347/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb-expected.png
[modify] https://crrev.com/030df82ef689b9aff91b700c72c08e9cf9215347/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb-expected.png
[modify] https://crrev.com/030df82ef689b9aff91b700c72c08e9cf9215347/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/imagemap-focus-ring-zero-outline-width-expected.png
[delete] https://crrev.com/9ecac9b13f80be30e6dc4a10405129d35a4380f3/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/sprite-no-bleed-expected.png
[modify] https://crrev.com/030df82ef689b9aff91b700c72c08e9cf9215347/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb-expected.png
[modify] https://crrev.com/030df82ef689b9aff91b700c72c08e9cf9215347/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb-expected.png
[modify] https://crrev.com/030df82ef689b9aff91b700c72c08e9cf9215347/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-border-image-source-expected.png
[modify] https://crrev.com/030df82ef689b9aff91b700c72c08e9cf9215347/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb-expected.png
[modify] https://crrev.com/030df82ef689b9aff91b700c72c08e9cf9215347/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb-expected.png
[modify] https://crrev.com/030df82ef689b9aff91b700c72c08e9cf9215347/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/imagemap-focus-ring-zero-outline-width-expected.png
[add] https://crrev.com/030df82ef689b9aff91b700c72c08e9cf9215347/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/sprite-no-bleed-expected.png
[modify] https://crrev.com/030df82ef689b9aff91b700c72c08e9cf9215347/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-border-image-source-expected.png
[modify] https://crrev.com/030df82ef689b9aff91b700c72c08e9cf9215347/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb-expected.png
[modify] https://crrev.com/030df82ef689b9aff91b700c72c08e9cf9215347/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb-expected.png
[modify] https://crrev.com/030df82ef689b9aff91b700c72c08e9cf9215347/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/imagemap-focus-ring-zero-outline-width-expected.png
[modify] https://crrev.com/030df82ef689b9aff91b700c72c08e9cf9215347/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/sprite-no-bleed-expected.png
[modify] https://crrev.com/030df82ef689b9aff91b700c72c08e9cf9215347/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/color-profile-clip-expected.png
[modify] https://crrev.com/030df82ef689b9aff91b700c72c08e9cf9215347/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/color-profile-iframe-expected.png
[modify] https://crrev.com/030df82ef689b9aff91b700c72c08e9cf9215347/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/color-profile-image-pseudo-content-expected.png
[modify] https://crrev.com/030df82ef689b9aff91b700c72c08e9cf9215347/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/color-profile-svg-foreign-object-expected.png
[modify] https://crrev.com/030df82ef689b9aff91b700c72c08e9cf9215347/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/gray-scale-jpeg-with-color-profile-expected.png
[add] https://crrev.com/030df82ef689b9aff91b700c72c08e9cf9215347/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/motion-jpeg-single-frame-expected.png
[delete] https://crrev.com/9ecac9b13f80be30e6dc4a10405129d35a4380f3/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/sprite-no-bleed-expected.png

Took a while to land, but should be fixed.

Is a merge required here? I think this missed the M62 cutoff.

We're in M62 now, aren't we? I'm not sure if we should merge to 61... I don't think it's a major enough problem

But the fix is really simple and fixes a serious gif battery performance regression.

Ok. Let's let it hit Canary for a couple of days to ensure we haven't broken anything and then I'll request a merge. Does that sound reasonable?

That sounds fantastic. Thanks for giving it another thought.

Pls apply appropriate OSs label. Thank you.

This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Before we approve merge to M61, please answer followings:
* Is this M61 regression? Is it critical?
* Is the change well baked/verified in Canary, having enough automation tests coverage and safe to merge to M61?
* Any other important details to justify the merge.

Please note M61 is already in Beta, so merge bar is very high. Thank you.

I'm not sure where this falls for the new merge rules.

Here are the facts as Vlad and I know them:
1) This was a regression on battery of ~6% on highdpi macs when playing animated gifs.
2) We're unsure what that translates to in terms of real-world mac battery performance.
3) Vlad's patch [1] fixed the regression.
4) Vlad's patch [1] is pretty simple, but not trivial.
5) The battery graph [2] has continued to regress by an additional 14.5% due to other, unrelated, changes. In other words, this release will be a battery regression no matter what.

[1] https://chromium.googlesource.com/chromium/src/+/030df82ef689b9aff91b700c72c08e9cf9215347
[2] https://chromeperf.appspot.com/report?sid=8ddd98d5d45b23097d12af8e6a96b3afe7cb5353efcec8f7f64197e7f9b2fde0&start_rev=474705&end_rev=492304

Thank you pdr@.

After discussing with abdulsyed@, approving merged to M61 branch 3163 based on comment #2 as fix is simple and fixes the regression.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/432d3c775dc266f585b4e6f00edf15249e92a8f8

commit 432d3c775dc266f585b4e6f00edf15249e92a8f8
Author: Vladimir Levin <vmpstr@chromium.org>
Date: Mon Aug 07 18:44:04 2017

cc: Use at most medium filter quality in gpu image decode cache.

This patch ensures that when passing a draw image to Skia, we only use
at most medium filter quality. This is on par with the software decode
cache and saves power.

R=ericrk@chromium.org, pdr@chromium.org
TBR=vmpstr@chromium.org

(cherry picked from commit 030df82ef689b9aff91b700c72c08e9cf9215347)

Bug:  747500 
Change-Id: Idc42c1a176ebd6394ae23324a37724b82278d9cc
Reviewed-on: https://chromium-review.googlesource.com/585404
Commit-Queue: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#492091}
Reviewed-on: https://chromium-review.googlesource.com/604232
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#363}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/432d3c775dc266f585b4e6f00edf15249e92a8f8/cc/tiles/gpu_image_decode_cache.cc
[modify] https://crrev.com/432d3c775dc266f585b4e6f00edf15249e92a8f8/cc/tiles/gpu_image_decode_cache_unittest.cc
[modify] https://crrev.com/432d3c775dc266f585b4e6f00edf15249e92a8f8/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-clip-expected.png
[modify] https://crrev.com/432d3c775dc266f585b4e6f00edf15249e92a8f8/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-iframe-expected.png
[modify] https://crrev.com/432d3c775dc266f585b4e6f00edf15249e92a8f8/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-pseudo-content-expected.png
[modify] https://crrev.com/432d3c775dc266f585b4e6f00edf15249e92a8f8/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb-expected.png
[modify] https://crrev.com/432d3c775dc266f585b4e6f00edf15249e92a8f8/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb-expected.png
[modify] https://crrev.com/432d3c775dc266f585b4e6f00edf15249e92a8f8/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-svg-foreign-object-expected.png
[modify] https://crrev.com/432d3c775dc266f585b4e6f00edf15249e92a8f8/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/imagemap-focus-ring-zero-outline-width-expected.png
[delete] https://crrev.com/08dcb9fd8fd385262fd9044a5481d4d3880590ef/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/sprite-no-bleed-expected.png
[modify] https://crrev.com/432d3c775dc266f585b4e6f00edf15249e92a8f8/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb-expected.png
[modify] https://crrev.com/432d3c775dc266f585b4e6f00edf15249e92a8f8/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb-expected.png
[modify] https://crrev.com/432d3c775dc266f585b4e6f00edf15249e92a8f8/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-border-image-source-expected.png
[modify] https://crrev.com/432d3c775dc266f585b4e6f00edf15249e92a8f8/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb-expected.png
[modify] https://crrev.com/432d3c775dc266f585b4e6f00edf15249e92a8f8/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb-expected.png
[modify] https://crrev.com/432d3c775dc266f585b4e6f00edf15249e92a8f8/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/imagemap-focus-ring-zero-outline-width-expected.png
[add] https://crrev.com/432d3c775dc266f585b4e6f00edf15249e92a8f8/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/sprite-no-bleed-expected.png
[modify] https://crrev.com/432d3c775dc266f585b4e6f00edf15249e92a8f8/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb-expected.png
[modify] https://crrev.com/432d3c775dc266f585b4e6f00edf15249e92a8f8/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb-expected.png
[modify] https://crrev.com/432d3c775dc266f585b4e6f00edf15249e92a8f8/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/sprite-no-bleed-expected.png
[modify] https://crrev.com/432d3c775dc266f585b4e6f00edf15249e92a8f8/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/gray-scale-jpeg-with-color-profile-expected.png
[add] https://crrev.com/432d3c775dc266f585b4e6f00edf15249e92a8f8/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/motion-jpeg-single-frame-expected.png
[delete] https://crrev.com/08dcb9fd8fd385262fd9044a5481d4d3880590ef/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/sprite-no-bleed-expected.png