Merge request for M61: In-Product Help UI for data saver footer not highlighted |
|||||||||
Issue descriptionThis is a followup to crbug.com/725311 The data saver menu footer is not highlighted when the IPH UI for data saver is shown.
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c338ce85529eb595e7f11f916dbf1d05f856b0c5 commit c338ce85529eb595e7f11f916dbf1d05f856b0c5 Author: Angela S <angelashao@google.com> Date: Fri Jul 21 23:21:56 2017 chrome/android: Fixed bug in highlighting data saver menu footer The data saver menu footer is supposed to be highlighted when the data saver in-product help is shown but it is not. This patch fixed it by changing the ID that is highlighted to be the inflatedID of the app menu footer view stub. BUG= 747486 Change-Id: Iaf43badcf277dd424fc02fbafa4d27e51c03737c Reviewed-on: https://chromium-review.googlesource.com/581879 Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Angela Shao <angelashao@google.com> Cr-Commit-Position: refs/heads/master@{#488785} [modify] https://crrev.com/c338ce85529eb595e7f11f916dbf1d05f856b0c5/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
,
Jul 24 2017
,
Jul 25 2017
,
Jul 25 2017
,
Jul 26 2017
,
Jul 26 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0aae78f54a0c937cbc81b32c99921312269b00ef commit 0aae78f54a0c937cbc81b32c99921312269b00ef Author: Angela S <angelashao@google.com> Date: Thu Jul 27 00:54:00 2017 chrome/android: Fixed bug in highlighting data saver menu footer The data saver menu footer is supposed to be highlighted when the data saver in-product help is shown but it is not. This patch fixed it by changing the ID that is highlighted to be the inflatedID of the app menu footer view stub. BUG= 747486 (cherry picked from commit c338ce85529eb595e7f11f916dbf1d05f856b0c5) Change-Id: Iaf43badcf277dd424fc02fbafa4d27e51c03737c Reviewed-on: https://chromium-review.googlesource.com/581879 Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Angela Shao <angelashao@google.com> Cr-Original-Commit-Position: refs/heads/master@{#488785} Reviewed-on: https://chromium-review.googlesource.com/588247 Cr-Commit-Position: refs/branch-heads/3163@{#70} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/0aae78f54a0c937cbc81b32c99921312269b00ef/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
,
Jul 27 2017
,
Aug 1 2017
data saver footer is highlighted in the current M61- 61.0.3163.20. Tezted on Gionee S6S / MRA58K , Vivo V3Max / LMY47V. Hence closing this issue. Thanks |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by chrishtr@chromium.org
, Jul 21 2017