Issue metadata
Sign in to add a comment
|
[A11y Assessment - Status Tray] Toggling setting shouldn't close the Status Tray |
||||||||||||||||||||||||
Issue descriptionOS: Chrome Tested on Canary (61) but experienced in previous versions Go to the accessibility menu within the status tray and use the keyboard (space) to toggle one of the settings, e.g. high contrast. What should happen is that the checkbox is then checked, and the status tray remains open until the user presses escape to close it. However, this is not the case. Instead, the menu closes when you press space to enable high contrast mode. Users might want to try a setting out quickly and then keep using the status tray menu, so this is an inconvenience and causes them to lose context when it closes like that.
,
Sep 28 2017
Yes, I would prefer that these are simply checkboxes that you can either click with mouse or toggle by keyboard, and when toggled, the menu remains open. Then users could either press escape or click outside the menu to close it. :)
,
Oct 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab3c1bb459dbd3e10294044b89199a1f1b52f218 commit ab3c1bb459dbd3e10294044b89199a1f1b52f218 Author: Sammie Quon <sammiequon@google.com> Date: Thu Oct 05 16:30:35 2017 tray: Do not close accessibilty detailed menu when item selected. It is desired to remain open so users can try out the features without having to tray->accessibilty->details each time. Also modified hover_highlight_view to support showing/removing checkmarks dynamically, for this purpose (other details views just recreate the whole view). Bug: 747473 Test: browser_tests TrayAccessibility.DetailMenuRemainsOpen Change-Id: I1160c29baac2afc8dc8a25dee3a87415ccef1adf Reviewed-on: https://chromium-review.googlesource.com/692680 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#506755} [modify] https://crrev.com/ab3c1bb459dbd3e10294044b89199a1f1b52f218/ash/system/tray/hover_highlight_view.cc [modify] https://crrev.com/ab3c1bb459dbd3e10294044b89199a1f1b52f218/ash/system/tray_accessibility.cc [modify] https://crrev.com/ab3c1bb459dbd3e10294044b89199a1f1b52f218/ash/system/tray_accessibility.h [modify] https://crrev.com/ab3c1bb459dbd3e10294044b89199a1f1b52f218/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
,
Oct 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4547f1c5cc664a1ed905a2ab61857596aad16d8d commit 4547f1c5cc664a1ed905a2ab61857596aad16d8d Author: Sammie Quon <sammiequon@chromium.org> Date: Thu Oct 05 22:30:58 2017 Revert "tray: Do not close accessibilty detailed menu when item selected." This reverts commit ab3c1bb459dbd3e10294044b89199a1f1b52f218. Reason for revert: <INSERT REASONING HERE> Original change's description: > tray: Do not close accessibilty detailed menu when item selected. > > It is desired to remain open so users can try out the features without > having to tray->accessibilty->details each time. Also modified > hover_highlight_view to support showing/removing checkmarks dynamically, > for this purpose (other details views just recreate the whole view). > > Bug: 747473 > Test: browser_tests TrayAccessibility.DetailMenuRemainsOpen > Change-Id: I1160c29baac2afc8dc8a25dee3a87415ccef1adf > Reviewed-on: https://chromium-review.googlesource.com/692680 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506755} TBR=stevenjb@chromium.org,sammiequon@chromium.org Change-Id: I139e7255e7162e47b95715d5c7b006844ec15c37 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 747473 Reviewed-on: https://chromium-review.googlesource.com/703934 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#506887} [modify] https://crrev.com/4547f1c5cc664a1ed905a2ab61857596aad16d8d/ash/system/tray/hover_highlight_view.cc [modify] https://crrev.com/4547f1c5cc664a1ed905a2ab61857596aad16d8d/ash/system/tray_accessibility.cc [modify] https://crrev.com/4547f1c5cc664a1ed905a2ab61857596aad16d8d/ash/system/tray_accessibility.h [modify] https://crrev.com/4547f1c5cc664a1ed905a2ab61857596aad16d8d/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
,
Oct 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5f32e00dfa1730b72c465878b249d63302cd770 commit b5f32e00dfa1730b72c465878b249d63302cd770 Author: Sammie Quon <sammiequon@google.com> Date: Tue Oct 10 19:16:12 2017 Reland "tray: Do not close accessibilty detailed menu when item selected." This is a reland of ab3c1bb459dbd3e10294044b89199a1f1b52f218 Original change's description: > tray: Do not close accessibilty detailed menu when item selected. > > It is desired to remain open so users can try out the features without > having to tray->accessibilty->details each time. Also modified > hover_highlight_view to support showing/removing checkmarks dynamically, > for this purpose (other details views just recreate the whole view). > > Bug: 747473 > Test: browser_tests TrayAccessibility.DetailMenuRemainsOpen > Change-Id: I1160c29baac2afc8dc8a25dee3a87415ccef1adf > Reviewed-on: https://chromium-review.googlesource.com/692680 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506755} Bug: 747473 Change-Id: Id35a5e412f59eca064b067810edeaef92b3bf797 Reviewed-on: https://chromium-review.googlesource.com/703954 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#507737} [modify] https://crrev.com/b5f32e00dfa1730b72c465878b249d63302cd770/ash/system/tray/hover_highlight_view.cc [modify] https://crrev.com/b5f32e00dfa1730b72c465878b249d63302cd770/ash/system/tray_accessibility.cc [modify] https://crrev.com/b5f32e00dfa1730b72c465878b249d63302cd770/ash/system/tray_accessibility.h [modify] https://crrev.com/b5f32e00dfa1730b72c465878b249d63302cd770/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
,
Oct 11 2017
,
Jan 22 2018
,
Jan 23 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by sammiequon@chromium.org
, Sep 21 2017Owner: sammiequon@chromium.org
Status: Assigned (was: Available)